-
Notifications
You must be signed in to change notification settings - Fork 39
CM-747: release chore: Upstream bump for v1.18.3 and rebase for v1.18.0 release #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CM-747: release chore: Upstream bump for v1.18.3 and rebase for v1.18.0 release #326
Conversation
|
@PillaiManish: This pull request references CM-747 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughBumps cert-manager references from v1.18.2 to v1.18.3 across manifests, embedded assets, build files, go.mod, and tests; updates related image tags and some replace directives; removes base64 icon data in the CSV. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
bundle/manifests/cert-manager-operator.clusterserviceversion.yaml (1)
307-308: Update CSV description to reference cert-manager v1.18.3The upgrade is for v1.18.3, yet the CSV description still claims we ship v1.18.2. This is inconsistent with the rest of the bump and will mislead customers and tooling that scrape the CSV metadata. Please align the description with the new operand version.
- The cert-manager Operator for Red Hat OpenShift provides seamless support for [cert-manager v1.18.2](https://github.com/cert-manager/cert-manager/tree/v1.18.2), which automates certificate management. + The cert-manager Operator for Red Hat OpenShift provides seamless support for [cert-manager v1.18.3](https://github.com/cert-manager/cert-manager/tree/v1.18.3), which automates certificate management.
🧹 Nitpick comments (3)
rebase_automation.sh (3)
14-14: Remove unused REPO_ROOT variable.The
REPO_ROOTvariable is defined but never used in the script. Consider removing it or using it consistently throughout the script instead of$SCRIPT_DIR.Apply this diff:
-REPO_ROOT="$SCRIPT_DIR"
143-143: Refactor variable declarations to avoid masking return values.Multiple variable declarations use command substitution in the same statement, which can mask failures. This is flagged by shellcheck (SC2034).
Example refactor for line 143:
- local backup_branch="backup-$(date +%Y%m%d-%H%M%S)" + local backup_branch + backup_branch="backup-$(date +%Y%m%d-%H%M%S)"Apply similar changes for:
- Lines 197-198:
old_channel_versionandnew_channel_version- Lines 272-273:
old_channel_versionandnew_channel_version- Lines 280-281:
old_channel_versionandnew_channel_version- Line 335:
temp_fileAlso applies to: 197-198, 272-273, 280-281, 335-335
315-319: Use mapfile for safer command output splitting.The script uses command substitution with array assignment, which can fail with filenames containing spaces or special characters. Use
mapfile(SC2207) for safer handling.Apply this diff for lines 315-319:
- local files_to_check=( - $(find . -type f \( -name "*.go" -o -name "*.yaml" -o -name "*.yml" -o -name "*.json" -o -name "*.md" -o -name "*.Dockerfile" \) \ - -not -path "./vendor/*" \ - -not -path "./.git/*" \ - -not -path "./testbin/*" \ - | grep -v "go.sum") - ) + local files_to_check=() + mapfile -t files_to_check < <(find . -type f \( -name "*.go" -o -name "*.yaml" -o -name "*.yml" -o -name "*.json" -o -name "*.md" -o -name "*.Dockerfile" \) \ + -not -path "./vendor/*" \ + -not -path "./.git/*" \ + -not -path "./testbin/*" | grep -v "go.sum")Similarly for line 407:
- local unique_files=($(printf '%s\n' "${changed_files[@]}" | sort -u)) + local unique_files=() + mapfile -t unique_files < <(printf '%s\n' "${changed_files[@]}" | sort -u)Also applies to: 407-407
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
⛔ Files ignored due to path filters (204)
go.sumis excluded by!**/*.sumvendor/github.com/tdakkota/asciicheck/.gitignoreis excluded by!vendor/**,!**/vendor/**vendor/github.com/tdakkota/asciicheck/.golangci.ymlis excluded by!vendor/**,!**/vendor/**vendor/github.com/tdakkota/asciicheck/Makefileis excluded by!vendor/**,!**/vendor/**vendor/github.com/tdakkota/asciicheck/README.mdis excluded by!vendor/**,!**/vendor/**vendor/github.com/tdakkota/asciicheck/asciicheck.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/mod/modfile/read.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/mod/modfile/rule.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/mod/modfile/work.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/mod/module/module.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/mod/semver/semver.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/frame.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/http2.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/trace/events.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sync/errgroup/errgroup.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/mkerrors.shis excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/syscall_darwin.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_386.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_amd64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_arm.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_arm64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_loong64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_mips.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_mips64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_mips64le.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_mipsle.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_ppc.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_ppc64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_ppc64le.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_riscv64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_s390x.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_sparc64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_386.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_amd64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_arm.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_arm64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_loong64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_mips.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_mips64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_mips64le.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_mipsle.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_ppc.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_ppc64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_ppc64le.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_riscv64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_s390x.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_sparc64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_386.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_amd64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_arm.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_arm64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_loong64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_mips.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_mips64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_mips64le.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_mipsle.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_ppc.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_ppc64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_ppc64le.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_riscv64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_s390x.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_sparc64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/term/term_windows.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/term/terminal.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/analysis.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/diagnostic.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/asmdecl/asmdecl.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/assign/assign.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/atomic/atomic.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/atomicalign/atomicalign.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/bools/bools.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/buildssa/buildssa.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/buildtag/buildtag.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/cgocall/cgocall.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/composite/composite.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/copylock/copylock.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/ctrlflow/ctrlflow.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/deepequalerrors/deepequalerrors.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/errorsas/errorsas.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/fieldalignment/fieldalignment.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/findcall/findcall.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/framepointer/framepointer.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/httpresponse/httpresponse.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/ifaceassert/ifaceassert.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/inspect/inspect.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/internal/analysisutil/util.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/loopclosure/loopclosure.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/lostcancel/lostcancel.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/nilfunc/nilfunc.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/nilness/nilness.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/pkgfact/pkgfact.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/printf/printf.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/reflectvaluecompare/reflectvaluecompare.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/shadow/shadow.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/shift/shift.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/sigchanyzer/sigchanyzer.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/sortslice/analyzer.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/stdmethods/stdmethods.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/stringintconv/string.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/structtag/structtag.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/testinggoroutine/testinggoroutine.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/testinggoroutine/util.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/tests/tests.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/unmarshal/unmarshal.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/unreachable/doc.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/unreachable/unreachable.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/unsafeptr/unsafeptr.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/unusedresult/unusedresult.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/validate.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/astutil/enclosing.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/astutil/imports.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/astutil/rewrite.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/astutil/util.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/edge/edge.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/inspector/cursor.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/inspector/inspector.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/inspector/iter.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/inspector/typeof.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/inspector/walk.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/buildutil/allpackages.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/buildutil/fakecontext.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/buildutil/tags.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/gcexportdata/gcexportdata.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/internal/cgo/cgo.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/loader/doc.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/loader/loader.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/packages/doc.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/packages/external.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/packages/golist.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/packages/golist_overlay.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/packages/loadmode_string.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/packages/packages.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/builder.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/const.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/dom.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/emit.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/func.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/instantiate.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/lift.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/mode.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/print.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/sanity.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/source.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/ssa.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/subst.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/typeset.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/util.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/wrappers.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/types/objectpath/objectpath.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/types/typeutil/callee.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/types/typeutil/map.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/analysisinternal/analysis.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/astutil/clone.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/astutil/comment.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/astutil/util.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/event/keys/keys.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/event/label/label.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/fmtstr/parse.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gcimporter/bimport.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gcimporter/exportdata.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gcimporter/gcimporter.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gcimporter/iexport.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gcimporter/iimport.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gcimporter/support.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gcimporter/ureader_yes.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gocommand/invoke.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gocommand/invoke_notunix.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gocommand/invoke_unix.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gopathwalk/walk.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/imports/fix.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/imports/imports.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/imports/mod.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/imports/mod_cache.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/imports/sortimports.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/imports/source_env.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/imports/source_modindex.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/modindex/directories.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/modindex/index.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/modindex/lookup.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/modindex/modindex.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/modindex/symbols.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/modindex/types.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/packagesinternal/packages.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/pkgbits/decoder.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/stdlib/deps.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/stdlib/import.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/stdlib/manifest.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/stdlib/stdlib.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typeparams/common.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typeparams/coretype.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typeparams/free.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typeparams/normalize.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typeparams/termlist.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typeparams/typeterm.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typesinternal/classify_call.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typesinternal/errorcode.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typesinternal/qualifier.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typesinternal/recv.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typesinternal/types.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typesinternal/varkind.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typesinternal/zerovalue.gois excluded by!vendor/**,!**/vendor/**vendor/modules.txtis excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (61)
Makefile(1 hunks)bindata/cert-manager-deployment/cainjector/cert-manager-cainjector-cr.yaml(1 hunks)bindata/cert-manager-deployment/cainjector/cert-manager-cainjector-crb.yaml(1 hunks)bindata/cert-manager-deployment/cainjector/cert-manager-cainjector-deployment.yaml(3 hunks)bindata/cert-manager-deployment/cainjector/cert-manager-cainjector-leaderelection-rb.yaml(1 hunks)bindata/cert-manager-deployment/cainjector/cert-manager-cainjector-leaderelection-role.yaml(1 hunks)bindata/cert-manager-deployment/cainjector/cert-manager-cainjector-sa.yaml(1 hunks)bindata/cert-manager-deployment/cainjector/cert-manager-cainjector-svc.yaml(1 hunks)bindata/cert-manager-deployment/cert-manager/cert-manager-controller-approve-cert-manager-io-cr.yaml(1 hunks)bindata/cert-manager-deployment/cert-manager/cert-manager-controller-approve-cert-manager-io-crb.yaml(1 hunks)bindata/cert-manager-deployment/cert-manager/cert-manager-controller-certificatesigningrequests-cr.yaml(1 hunks)bindata/cert-manager-deployment/cert-manager/cert-manager-controller-certificatesigningrequests-crb.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-cert-manager-tokenrequest-rb.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-cluster-view-cr.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-certificates-cr.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-certificates-crb.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-challenges-cr.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-challenges-crb.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-clusterissuers-cr.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-clusterissuers-crb.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-ingress-shim-cr.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-ingress-shim-crb.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-issuers-cr.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-issuers-crb.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-orders-cr.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-orders-crb.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-deployment.yaml(3 hunks)bindata/cert-manager-deployment/controller/cert-manager-edit-cr.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-leaderelection-rb.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-leaderelection-role.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-sa.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-svc.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-tokenrequest-role.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-view-cr.yaml(1 hunks)bindata/cert-manager-deployment/webhook/cert-manager-webhook-deployment.yaml(3 hunks)bindata/cert-manager-deployment/webhook/cert-manager-webhook-dynamic-serving-rb.yaml(1 hunks)bindata/cert-manager-deployment/webhook/cert-manager-webhook-dynamic-serving-role.yaml(1 hunks)bindata/cert-manager-deployment/webhook/cert-manager-webhook-mutatingwebhookconfiguration.yaml(1 hunks)bindata/cert-manager-deployment/webhook/cert-manager-webhook-sa.yaml(1 hunks)bindata/cert-manager-deployment/webhook/cert-manager-webhook-subjectaccessreviews-cr.yaml(1 hunks)bindata/cert-manager-deployment/webhook/cert-manager-webhook-subjectaccessreviews-crb.yaml(1 hunks)bindata/cert-manager-deployment/webhook/cert-manager-webhook-svc.yaml(1 hunks)bindata/cert-manager-deployment/webhook/cert-manager-webhook-validatingwebhookconfiguration.yaml(1 hunks)bundle/manifests/acme.cert-manager.io_challenges.yaml(1 hunks)bundle/manifests/acme.cert-manager.io_orders.yaml(1 hunks)bundle/manifests/cert-manager-operator.clusterserviceversion.yaml(2 hunks)bundle/manifests/cert-manager.io_certificaterequests.yaml(1 hunks)bundle/manifests/cert-manager.io_certificates.yaml(1 hunks)bundle/manifests/cert-manager.io_clusterissuers.yaml(1 hunks)bundle/manifests/cert-manager.io_issuers.yaml(1 hunks)config/crd/bases/certificaterequests.cert-manager.io-crd.yaml(1 hunks)config/crd/bases/certificates.cert-manager.io-crd.yaml(1 hunks)config/crd/bases/challenges.acme.cert-manager.io-crd.yaml(1 hunks)config/crd/bases/clusterissuers.cert-manager.io-crd.yaml(1 hunks)config/crd/bases/issuers.cert-manager.io-crd.yaml(1 hunks)config/crd/bases/orders.acme.cert-manager.io-crd.yaml(1 hunks)config/manager/manager.yaml(1 hunks)go.mod(4 hunks)images/ci/operand.Dockerfile(1 hunks)pkg/controller/deployment/deployment_overrides_test.go(3 hunks)rebase_automation.sh(1 hunks)
🧰 Additional context used
🪛 Shellcheck (0.11.0)
rebase_automation.sh
[warning] 14-14: REPO_ROOT appears unused. Verify use (or export if used externally).
(SC2034)
[warning] 143-143: Declare and assign separately to avoid masking return values.
(SC2155)
[warning] 197-197: Declare and assign separately to avoid masking return values.
(SC2155)
[warning] 198-198: Declare and assign separately to avoid masking return values.
(SC2155)
[warning] 272-272: Declare and assign separately to avoid masking return values.
(SC2155)
[warning] 273-273: Declare and assign separately to avoid masking return values.
(SC2155)
[warning] 280-280: Declare and assign separately to avoid masking return values.
(SC2155)
[warning] 281-281: Declare and assign separately to avoid masking return values.
(SC2155)
[warning] 315-319: Prefer mapfile or read -a to split command output (or quote to avoid splitting).
(SC2207)
[warning] 335-335: Declare and assign separately to avoid masking return values.
(SC2155)
[warning] 407-407: Prefer mapfile or read -a to split command output (or quote to avoid splitting).
(SC2207)
🔇 Additional comments (27)
bundle/manifests/cert-manager.io_issuers.yaml (1)
13-13: Version label bump looks consistent.
Label now reflects v1.18.3, matching the release chore scope.bindata/cert-manager-deployment/controller/cert-manager-view-cr.yaml (1)
9-9: RBAC manifest version tag aligns with v1.18.3.
No other changes needed in this snippet.bindata/cert-manager-deployment/controller/cert-manager-controller-certificates-crb.yaml (1)
9-9: Version label bump looks goodLabel now matches the v1.18.3 release target.
bundle/manifests/acme.cert-manager.io_orders.yaml (1)
13-13: CRD metadata updated correctlyThe app.kubernetes.io/version label now aligns with the v1.18.3 bundle.
bindata/cert-manager-deployment/cainjector/cert-manager-cainjector-sa.yaml (1)
10-10: ServiceAccount label alignedVersion label reflects v1.18.3 as expected.
bindata/cert-manager-deployment/controller/cert-manager-controller-ingress-shim-crb.yaml (1)
9-9: RBAC label bump confirmedIngress shim ClusterRoleBinding now references v1.18.3.
bindata/cert-manager-deployment/cert-manager/cert-manager-controller-approve-cert-manager-io-crb.yaml (1)
9-9: Approve binding label updatedLabel correctly matches the v1.18.3 release tag.
bindata/cert-manager-deployment/controller/cert-manager-edit-cr.yaml (1)
9-9: ClusterRole metadata consistentThe version label now tracks v1.18.3; looks good.
bindata/cert-manager-deployment/controller/cert-manager-controller-issuers-cr.yaml (1)
9-9: Issuers role label verifiedVersion metadata matches the v1.18.3 rollout.
Makefile (1)
7-7: Version variable aligned
The CERT_MANAGER_VERSION bump to v1.18.3 matches the rest of the manifest updates.config/crd/bases/certificaterequests.cert-manager.io-crd.yaml (1)
11-11: CRD metadata kept current
Label now reflects v1.18.3 as expected for this bump.bindata/cert-manager-deployment/controller/cert-manager-leaderelection-role.yaml (1)
9-9: Leader election role synced
Version label correctly tracks v1.18.3.bindata/cert-manager-deployment/controller/cert-manager-controller-challenges-cr.yaml (1)
9-9: Challenges ClusterRole updated
Metadata version aligns with the 1.18.3 release.bindata/cert-manager-deployment/controller/cert-manager-controller-orders-cr.yaml (1)
9-9: Orders ClusterRole in sync
Label now matches v1.18.3 as required.bindata/cert-manager-deployment/webhook/cert-manager-webhook-dynamic-serving-role.yaml (1)
9-9: Webhook role version refreshed
Metadata version correctly bumped to v1.18.3.bindata/cert-manager-deployment/controller/cert-manager-controller-ingress-shim-cr.yaml (1)
9-9: Ingress shim metadata updated
Version label now reflects v1.18.3.bundle/manifests/acme.cert-manager.io_challenges.yaml (1)
12-12: Bundle CRD version aligned
Label bump to v1.18.3 matches the overall release update.bindata/cert-manager-deployment/controller/cert-manager-controller-issuers-crb.yaml (1)
9-9: LGTM! Version label updated correctly.The version label has been consistently updated from v1.18.2 to v1.18.3, aligning with the PR's objective to perform an upstream bump.
pkg/controller/deployment/deployment_overrides_test.go (1)
36-36: LGTM! Test expectations updated correctly.All test expectations for the acme-http01-solver-image have been consistently updated from v1.18.2 to v1.18.3, ensuring tests align with the new version.
Also applies to: 124-124, 176-176
bindata/cert-manager-deployment/controller/cert-manager-deployment.yaml (1)
9-9: LGTM! Version references updated consistently.Both the version labels and container image tags have been updated from v1.18.2 to v1.18.3, maintaining consistency between metadata and runtime configuration.
Also applies to: 30-30, 37-37, 47-47
go.mod (3)
6-6: LGTM! Primary dependency updated correctly.The cert-manager dependency has been updated from v1.18.2 to v1.18.3, aligning with the PR objectives.
301-301: LGTM! Replace directives updated correctly.The replace directives have been properly updated:
- cert-manager points to openshift/jetstack-cert-manager v1.18.3
- asciicheck points to the correct golangci fork
These are consistent with the version bump and maintain the expected forked dependencies.
Also applies to: 305-305
24-24: Manual verification required: cannot execute build and tests in sandbox environment.The go.mod file updates appear syntactically valid, but direct build and test verification cannot be performed in this sandbox (Go compiler and
makecommand unavailable). The repository contains a Makefile, suggestingmake buildandmake testare intended entry points for verification.Please manually verify:
- Run
make buildto confirm the project compiles with these golang.org/x/ dependency updates- Run
make testto ensure all tests pass with the updated versions- Check for any runtime regressions with the newer versions (particularly: crypto, net, sys, tools, mod)
The following golang.org/x/ packages were updated (review lines 254-266 in go.mod for the complete list):
- golang.org/x/tools v0.36.0
- golang.org/x/crypto v0.41.0
- golang.org/x/net v0.43.0
- golang.org/x/sys v0.35.0
- And others as indirect dependencies
bindata/cert-manager-deployment/webhook/cert-manager-webhook-deployment.yaml (1)
9-9: LGTM! Webhook version references updated consistently.The webhook deployment's version labels and image tag have been updated from v1.18.2 to v1.18.3, maintaining consistency with the broader version bump.
Also applies to: 30-30, 46-46
rebase_automation.sh (1)
1-527: Helpful automation script for future rebases.This script provides valuable automation for the version bump workflow, with:
- Clear step-by-step execution
- Dry-run capability for safety
- Auto-detection of current versions
- Comprehensive logging
- Git commit integration
The script will significantly reduce manual effort and potential errors in future rebase operations. After addressing the shellcheck warnings, this will be a solid addition to the repository's tooling.
bindata/cert-manager-deployment/controller/cert-manager-svc.yaml (1)
9-9: LGTM! Service version label updated correctly.The version label has been updated from v1.18.2 to v1.18.3, maintaining consistency across all cert-manager service resources.
bindata/cert-manager-deployment/webhook/cert-manager-webhook-mutatingwebhookconfiguration.yaml (1)
11-11: LGTM! MutatingWebhookConfiguration version label updated correctly.The version label has been updated from v1.18.2 to v1.18.3, completing the consistent version bump across all cert-manager webhook resources.
|
/retest |
|
@PillaiManish: This pull request references CM-747 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
|
bharath-b-rh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just couple of nits.
|
e2e failures are not because of the changes in this PR, and are safe to overridden. cc: @lunarwhite for qe-approved |
|
Line needs an update too. |
e776dd0 to
742203c
Compare
- go mod edit -replace github.com/tdakkota/asciicheck=github.com/golangci/asciicheck@v0.1.1 - go mod tidy && go mod vendor
742203c to
cea63c9
Compare
cea63c9 to
08938bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
⛔ Files ignored due to path filters (199)
go.sumis excluded by!**/*.sumvendor/golang.org/x/mod/modfile/read.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/mod/modfile/rule.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/mod/modfile/work.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/mod/module/module.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/mod/semver/semver.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/frame.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/http2/http2.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/net/trace/events.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sync/errgroup/errgroup.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/mkerrors.shis excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/syscall_darwin.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_386.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_amd64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_arm.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_arm64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_loong64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_mips.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_mips64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_mips64le.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_mipsle.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_ppc.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_ppc64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_ppc64le.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_riscv64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_s390x.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zerrors_linux_sparc64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_386.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_amd64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_arm.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_arm64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_loong64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_mips.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_mips64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_mips64le.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_mipsle.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_ppc.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_ppc64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_ppc64le.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_riscv64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_s390x.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/zsysnum_linux_sparc64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_386.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_amd64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_arm.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_arm64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_loong64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_mips.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_mips64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_mips64le.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_mipsle.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_ppc.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_ppc64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_ppc64le.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_riscv64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_s390x.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/sys/unix/ztypes_linux_sparc64.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/term/term_windows.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/term/terminal.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/analysis.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/diagnostic.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/asmdecl/asmdecl.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/assign/assign.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/atomic/atomic.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/atomicalign/atomicalign.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/bools/bools.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/buildssa/buildssa.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/buildtag/buildtag.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/cgocall/cgocall.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/composite/composite.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/copylock/copylock.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/ctrlflow/ctrlflow.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/deepequalerrors/deepequalerrors.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/errorsas/errorsas.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/fieldalignment/fieldalignment.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/findcall/findcall.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/framepointer/framepointer.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/httpresponse/httpresponse.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/ifaceassert/ifaceassert.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/inspect/inspect.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/internal/analysisutil/util.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/loopclosure/loopclosure.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/lostcancel/lostcancel.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/nilfunc/nilfunc.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/nilness/nilness.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/pkgfact/pkgfact.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/printf/printf.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/reflectvaluecompare/reflectvaluecompare.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/shadow/shadow.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/shift/shift.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/sigchanyzer/sigchanyzer.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/sortslice/analyzer.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/stdmethods/stdmethods.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/stringintconv/string.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/structtag/structtag.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/testinggoroutine/testinggoroutine.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/testinggoroutine/util.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/tests/tests.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/unmarshal/unmarshal.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/unreachable/doc.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/unreachable/unreachable.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/unsafeptr/unsafeptr.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/passes/unusedresult/unusedresult.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/analysis/validate.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/astutil/enclosing.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/astutil/imports.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/astutil/rewrite.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/astutil/util.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/edge/edge.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/inspector/cursor.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/inspector/inspector.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/inspector/iter.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/inspector/typeof.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ast/inspector/walk.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/buildutil/allpackages.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/buildutil/fakecontext.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/buildutil/tags.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/gcexportdata/gcexportdata.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/internal/cgo/cgo.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/loader/doc.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/loader/loader.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/packages/doc.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/packages/external.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/packages/golist.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/packages/golist_overlay.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/packages/loadmode_string.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/packages/packages.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/builder.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/const.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/dom.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/emit.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/func.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/instantiate.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/lift.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/mode.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/print.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/sanity.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/source.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/ssa.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/subst.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/typeset.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/util.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/ssa/wrappers.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/types/objectpath/objectpath.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/types/typeutil/callee.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/go/types/typeutil/map.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/analysisinternal/analysis.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/astutil/clone.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/astutil/comment.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/astutil/util.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/event/keys/keys.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/event/label/label.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/fmtstr/parse.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gcimporter/bimport.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gcimporter/exportdata.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gcimporter/gcimporter.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gcimporter/iexport.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gcimporter/iimport.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gcimporter/support.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gcimporter/ureader_yes.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gocommand/invoke.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gocommand/invoke_notunix.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gocommand/invoke_unix.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/gopathwalk/walk.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/imports/fix.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/imports/imports.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/imports/mod.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/imports/mod_cache.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/imports/sortimports.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/imports/source_env.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/imports/source_modindex.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/modindex/directories.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/modindex/index.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/modindex/lookup.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/modindex/modindex.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/modindex/symbols.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/modindex/types.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/packagesinternal/packages.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/pkgbits/decoder.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/stdlib/deps.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/stdlib/import.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/stdlib/manifest.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/stdlib/stdlib.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typeparams/common.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typeparams/coretype.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typeparams/free.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typeparams/normalize.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typeparams/termlist.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typeparams/typeterm.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typesinternal/classify_call.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typesinternal/errorcode.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typesinternal/qualifier.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typesinternal/recv.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typesinternal/types.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typesinternal/varkind.gois excluded by!vendor/**,!**/vendor/**vendor/golang.org/x/tools/internal/typesinternal/zerovalue.gois excluded by!vendor/**,!**/vendor/**vendor/modules.txtis excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (62)
Makefile(1 hunks)bindata/cert-manager-deployment/cainjector/cert-manager-cainjector-cr.yaml(1 hunks)bindata/cert-manager-deployment/cainjector/cert-manager-cainjector-crb.yaml(1 hunks)bindata/cert-manager-deployment/cainjector/cert-manager-cainjector-deployment.yaml(3 hunks)bindata/cert-manager-deployment/cainjector/cert-manager-cainjector-leaderelection-rb.yaml(1 hunks)bindata/cert-manager-deployment/cainjector/cert-manager-cainjector-leaderelection-role.yaml(1 hunks)bindata/cert-manager-deployment/cainjector/cert-manager-cainjector-sa.yaml(1 hunks)bindata/cert-manager-deployment/cainjector/cert-manager-cainjector-svc.yaml(1 hunks)bindata/cert-manager-deployment/cert-manager/cert-manager-controller-approve-cert-manager-io-cr.yaml(1 hunks)bindata/cert-manager-deployment/cert-manager/cert-manager-controller-approve-cert-manager-io-crb.yaml(1 hunks)bindata/cert-manager-deployment/cert-manager/cert-manager-controller-certificatesigningrequests-cr.yaml(1 hunks)bindata/cert-manager-deployment/cert-manager/cert-manager-controller-certificatesigningrequests-crb.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-cert-manager-tokenrequest-rb.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-cluster-view-cr.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-certificates-cr.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-certificates-crb.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-challenges-cr.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-challenges-crb.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-clusterissuers-cr.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-clusterissuers-crb.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-ingress-shim-cr.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-ingress-shim-crb.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-issuers-cr.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-issuers-crb.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-orders-cr.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-controller-orders-crb.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-deployment.yaml(3 hunks)bindata/cert-manager-deployment/controller/cert-manager-edit-cr.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-leaderelection-rb.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-leaderelection-role.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-sa.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-svc.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-tokenrequest-role.yaml(1 hunks)bindata/cert-manager-deployment/controller/cert-manager-view-cr.yaml(1 hunks)bindata/cert-manager-deployment/webhook/cert-manager-webhook-deployment.yaml(3 hunks)bindata/cert-manager-deployment/webhook/cert-manager-webhook-dynamic-serving-rb.yaml(1 hunks)bindata/cert-manager-deployment/webhook/cert-manager-webhook-dynamic-serving-role.yaml(1 hunks)bindata/cert-manager-deployment/webhook/cert-manager-webhook-mutatingwebhookconfiguration.yaml(1 hunks)bindata/cert-manager-deployment/webhook/cert-manager-webhook-sa.yaml(1 hunks)bindata/cert-manager-deployment/webhook/cert-manager-webhook-subjectaccessreviews-cr.yaml(1 hunks)bindata/cert-manager-deployment/webhook/cert-manager-webhook-subjectaccessreviews-crb.yaml(1 hunks)bindata/cert-manager-deployment/webhook/cert-manager-webhook-svc.yaml(1 hunks)bindata/cert-manager-deployment/webhook/cert-manager-webhook-validatingwebhookconfiguration.yaml(1 hunks)bundle/manifests/acme.cert-manager.io_challenges.yaml(1 hunks)bundle/manifests/acme.cert-manager.io_orders.yaml(1 hunks)bundle/manifests/cert-manager-operator.clusterserviceversion.yaml(3 hunks)bundle/manifests/cert-manager.io_certificaterequests.yaml(1 hunks)bundle/manifests/cert-manager.io_certificates.yaml(1 hunks)bundle/manifests/cert-manager.io_clusterissuers.yaml(1 hunks)bundle/manifests/cert-manager.io_issuers.yaml(1 hunks)config/crd/bases/certificaterequests.cert-manager.io-crd.yaml(1 hunks)config/crd/bases/certificates.cert-manager.io-crd.yaml(1 hunks)config/crd/bases/challenges.acme.cert-manager.io-crd.yaml(1 hunks)config/crd/bases/clusterissuers.cert-manager.io-crd.yaml(1 hunks)config/crd/bases/issuers.cert-manager.io-crd.yaml(1 hunks)config/crd/bases/orders.acme.cert-manager.io-crd.yaml(1 hunks)config/manager/manager.yaml(1 hunks)config/manifests/bases/cert-manager-operator.clusterserviceversion.yaml(1 hunks)go.mod(4 hunks)images/ci/operand.Dockerfile(1 hunks)pkg/controller/deployment/deployment_overrides_test.go(3 hunks)pkg/operator/assets/bindata.go(48 hunks)
✅ Files skipped from review due to trivial changes (8)
- bindata/cert-manager-deployment/controller/cert-manager-controller-challenges-crb.yaml
- config/crd/bases/clusterissuers.cert-manager.io-crd.yaml
- bindata/cert-manager-deployment/controller/cert-manager-cluster-view-cr.yaml
- bindata/cert-manager-deployment/controller/cert-manager-view-cr.yaml
- bindata/cert-manager-deployment/cainjector/cert-manager-cainjector-leaderelection-role.yaml
- bundle/manifests/cert-manager.io_certificaterequests.yaml
- bindata/cert-manager-deployment/controller/cert-manager-tokenrequest-role.yaml
- bindata/cert-manager-deployment/controller/cert-manager-controller-ingress-shim-crb.yaml
🚧 Files skipped from review as they are similar to previous changes (29)
- bindata/cert-manager-deployment/cert-manager/cert-manager-controller-approve-cert-manager-io-cr.yaml
- bindata/cert-manager-deployment/cainjector/cert-manager-cainjector-leaderelection-rb.yaml
- bindata/cert-manager-deployment/controller/cert-manager-leaderelection-rb.yaml
- bindata/cert-manager-deployment/controller/cert-manager-cert-manager-tokenrequest-rb.yaml
- bindata/cert-manager-deployment/cainjector/cert-manager-cainjector-svc.yaml
- config/crd/bases/challenges.acme.cert-manager.io-crd.yaml
- bindata/cert-manager-deployment/cainjector/cert-manager-cainjector-deployment.yaml
- bindata/cert-manager-deployment/controller/cert-manager-deployment.yaml
- bindata/cert-manager-deployment/controller/cert-manager-edit-cr.yaml
- bindata/cert-manager-deployment/webhook/cert-manager-webhook-subjectaccessreviews-crb.yaml
- bindata/cert-manager-deployment/webhook/cert-manager-webhook-subjectaccessreviews-cr.yaml
- bindata/cert-manager-deployment/cert-manager/cert-manager-controller-approve-cert-manager-io-crb.yaml
- bindata/cert-manager-deployment/cert-manager/cert-manager-controller-certificatesigningrequests-crb.yaml
- config/crd/bases/certificaterequests.cert-manager.io-crd.yaml
- bindata/cert-manager-deployment/webhook/cert-manager-webhook-sa.yaml
- bundle/manifests/cert-manager.io_certificates.yaml
- bindata/cert-manager-deployment/webhook/cert-manager-webhook-mutatingwebhookconfiguration.yaml
- config/crd/bases/orders.acme.cert-manager.io-crd.yaml
- bundle/manifests/cert-manager-operator.clusterserviceversion.yaml
- bundle/manifests/cert-manager.io_clusterissuers.yaml
- bindata/cert-manager-deployment/webhook/cert-manager-webhook-svc.yaml
- bindata/cert-manager-deployment/webhook/cert-manager-webhook-validatingwebhookconfiguration.yaml
- bindata/cert-manager-deployment/controller/cert-manager-controller-orders-crb.yaml
- bindata/cert-manager-deployment/cert-manager/cert-manager-controller-certificatesigningrequests-cr.yaml
- config/crd/bases/certificates.cert-manager.io-crd.yaml
- config/manager/manager.yaml
- bindata/cert-manager-deployment/controller/cert-manager-controller-certificates-crb.yaml
- bindata/cert-manager-deployment/webhook/cert-manager-webhook-deployment.yaml
- bundle/manifests/acme.cert-manager.io_orders.yaml
🔇 Additional comments (18)
bindata/cert-manager-deployment/controller/cert-manager-controller-certificates-cr.yaml (1)
9-9: Version annotation updated correctly.The version annotation is correctly bumped from v1.18.2 to v1.18.3, consistent with the PR objective to upgrade cert-manager to v1.18.3. The RBAC rules remain unchanged and appropriate for the cert-manager controller component.
bindata/cert-manager-deployment/controller/cert-manager-sa.yaml (1)
10-10: Version label update is consistent with PR objectives.The app.kubernetes.io/version label has been correctly updated to v1.18.3, aligning with the coordinated upstream version bump documented in the PR. The YAML structure and Kubernetes label conventions are properly maintained.
bindata/cert-manager-deployment/controller/cert-manager-controller-ingress-shim-cr.yaml (1)
9-9: Version annotation correctly bumped to v1.18.3.The
app.kubernetes.io/versionannotation has been properly updated as part of the upstream cert-manager v1.18.3 release. The RBAC rules remain intact and the resource structure is unchanged.bindata/cert-manager-deployment/webhook/cert-manager-webhook-dynamic-serving-role.yaml (1)
9-9: Version label updated correctly and verified consistent across all cert-manager manifests.The
app.kubernetes.io/versionlabel is properly updated from v1.18.2 to v1.18.3 on line 9. Verification confirms all cert-manager deployment manifests (webhook and controller components) have been consistently updated to v1.18.3. No mixed or incomplete version updates detected. The istio-csr component remains at v0.14.2, which is expected as a separate project.bindata/cert-manager-deployment/controller/cert-manager-svc.yaml (1)
9-9: Version label correctly updated to v1.18.3.The
app.kubernetes.io/versionlabel update is accurate and consistent with the PR objective.config/manifests/bases/cert-manager-operator.clusterserviceversion.yaml (1)
70-72: Description link and version reference updated correctly.The description now accurately points to cert-manager v1.18.3. Note that the operator version itself (line 108) correctly remains at 1.18.0, which is distinct from the managed component version—this is the intended separation for operator versioning.
bindata/cert-manager-deployment/controller/cert-manager-controller-orders-cr.yaml (1)
9-9: Version label correctly bumped to v1.18.3.The
app.kubernetes.io/versionlabel in this ClusterRole manifest is properly updated. RBAC rules remain unchanged, as expected.bundle/manifests/cert-manager.io_issuers.yaml (1)
13-13: Version label bump looks good. The label now matches the v1.18.3 release target.bindata/cert-manager-deployment/webhook/cert-manager-webhook-dynamic-serving-rb.yaml (1)
9-9: Webhook RBAC version updated correctly. The metadata now references v1.18.3 as expected.images/ci/operand.Dockerfile (1)
3-3: Builder ARG aligns with v1.18.3 tag. This keeps the CI operand build sourcing the correct branch.bindata/cert-manager-deployment/cainjector/cert-manager-cainjector-crb.yaml (1)
9-9: Cainjector CRB label updated appropriately. The metadata now reflects the v1.18.3 deployment bundle.bindata/cert-manager-deployment/controller/cert-manager-controller-clusterissuers-crb.yaml (1)
9-9: Controller ClusterIssuer RBAC version matches upgrade. Label now points to v1.18.3.bindata/cert-manager-deployment/cainjector/cert-manager-cainjector-sa.yaml (1)
10-10: ServiceAccount metadata updated consistently. The cainjector SA version label now aligns with v1.18.3.go.mod (4)
6-6: LGTM! cert-manager version bump is correct.The cert-manager dependency update from v1.18.2 to v1.18.3 aligns with the PR objectives and is consistent with the replace directive at line 301.
24-24: Verify compatibility of golang.org/x/ dependency updates.*Several golang.org/x/* packages have significant version jumps (e.g., x/tools from v0.28.0 to v0.36.0). While these are indirect dependencies likely pulled in by the cert-manager upgrade or Go version bump, please ensure the build and tests pass with these updated versions.
Also applies to: 254-266
301-301: LGTM! Replace directive correctly updated.The replace directive for cert-manager is correctly updated to point to github.com/openshift/jetstack-cert-manager v1.18.3, consistent with the dependency declaration at line 6.
305-305: LGTM! asciicheck replace directive added per previous feedback.This replace directive addresses the previous review feedback and aligns with the golangci-lint dependency requirements.
Based on learnings
pkg/operator/assets/bindata.go (1)
1-2971: LGTM! Generated file with consistent version updates.This is a generated file (
go-bindata) containing embedded Kubernetes manifests. All version references have been consistently updated from v1.18.2 to v1.18.3 across:
app.kubernetes.io/versionlabels- Container image tags (quay.io/jetstack/cert-manager-*)
- ACME solver image references
The changes are mechanical and align with the PR objective of bumping cert-manager to v1.18.3.
go.mod
Outdated
| module github.com/openshift/cert-manager-operator | ||
|
|
||
| go 1.23.10 | ||
| go 1.24.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
🧩 Analysis chain
Verify Go 1.24.6 is a valid release version.
Please confirm that Go 1.24.6 is an officially released version and is the intended version for this project. As of October 2025, this version number should be validated.
🏁 Script executed:
#!/bin/bash
# Check if Go 1.24.6 exists
curl -s https://go.dev/dl/?mode=json | jq -r '.[].version' | grep -E '^go1\.24\.'Length of output: 8
Update Go version to latest available 1.24 patch release.
Go 1.24.6 was released on August 6, 2025 with security fixes to database/sql and os/exec packages, so it is a valid version. However, Go 1.24.8 was released on October 7, 2025 with additional security fixes to multiple packages including archive/tar, crypto/tls, and crypto/x509. Consider upgrading to the latest 1.24 patch to ensure all available security updates are included.
🤖 Prompt for AI Agents
In go.mod around line 3, the module is pinned to "go 1.24.6" which is outdated;
update the go directive to the latest 1.24 patch (e.g. "go 1.24.8") to pick up
recent security fixes, then run go mod tidy (and optionally go mod download) and
rebuild/run tests to ensure dependencies and generated files are consistent with
the new toolchain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PillaiManish Understood! I'll note that Go 1.24.6 will remain as the version for this PR. Let me know if you need anything else! 🐰
08938bb to
c3ffce3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
go.mod (1)
3-3: Go version 1.24.4 is outdated; consider upgrading for security patches.Previous review flagged that Go 1.24.8 was released on October 7, 2025 with security fixes to archive/tar, crypto/tls, and crypto/x509, among others. The current pinned version (1.24.4) predates these patches. Consider upgrading to the latest available 1.24 patch to ensure all critical security updates are included.
What is the rationale for using 1.24.4 instead of a more recent 1.24.x patch? If there are no compatibility concerns with cert-manager v1.18.3 or other dependencies, consider updating to the latest available patch.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (1)
go.mod(4 hunks)
🔇 Additional comments (3)
go.mod (3)
6-6: cert-manager dependency correctly bumped to v1.18.3.The upgrade from v1.18.2 to v1.18.3 aligns with the PR objectives to rebase to upstream cert-manager v1.18.3.
301-301: Replace directive correctly routes cert-manager to openshift/jetstack-cert-manager.The replace directive ensures the correct downstream fork (openshift/jetstack-cert-manager v1.18.3) is used instead of the upstream cert-manager package, as intended per the PR objectives.
305-305: asciicheck replace directive resolves previous version mismatch concern.This replaces asciicheck with the correct version (v0.1.1) that is compatible with golangci/golangci-lint v1.50.1, addressing the concern raised in the earlier review by @bharath-b-rh.
|
@PillaiManish: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
bharath-b-rh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
/cherrypick cert-manager-1.18 |
|
@bharath-b-rh: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bharath-b-rh, PillaiManish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
||
| replace sigs.k8s.io/controller-tools => github.com/openshift/kubernetes-sigs-controller-tools v0.12.1-0.20250220141355-6d2c85031fbc | ||
|
|
||
| replace github.com/tdakkota/asciicheck => github.com/golangci/asciicheck v0.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change is required? 0c3858d
I just tried it in an isolated GH codespace env, the rebase would also succeed without this commit 🧐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github.com/tdakkota/asciicheck doesn't exist anymore. isolated GH codespace env did it have any packages in go mod cache, if so that would be the reason it worked. Building from scratch is causing failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this context! (It would be great if it was mentioned in the git commit or the PR description :P) Then we could eliminate a round of Q-and-A
isolated GH codespace env did it have any packages in go mod cache, if so that would be the reason it worked
It could also be the predefined Go proxy in the GH codespace I presume golangci/golangci-lint#6017
| module github.com/openshift/cert-manager-operator | ||
|
|
||
| go 1.23.10 | ||
| go 1.24.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I might missed some context, but why we're changing back from 1.24.6 to 1.24.4? #326 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI golang image doesn't have 1.24.6 yet, hence had to use 1.24.4. We will do this follow up PR, when the tag becomes available.
|
/label qe-approved /retitle CM-747: release chore: Upstream bump for v1.18.3 and rebase for v1.18.0 release |
|
@PillaiManish: This pull request references CM-747 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ee06461
into
openshift:master
|
@bharath-b-rh: new pull request created: #329 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Rebase downstream cert-manager-operator for v1.18.0 with upstream cert-manager v1.18.3.