Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| ctx := framework.GetContext() | ||
| client, err := framework.LoadClient() | ||
| Expect(err).NotTo(HaveOccurred(), "Failed to load client") | ||
|
|
There was a problem hiding this comment.
can we move this in BeforeEach or BeforeAll?
| }) | ||
| }) | ||
|
|
||
| var _ = Describe("Cluster Machine Approver CAPI Integration", framework.LabelMachineApprover, framework.LabelLEVEL0, func() { |
There was a problem hiding this comment.
removed it , not a level0
| err = client.List(ctx, endpointSlices, runtimeclient.InNamespace(cmaNamespace)) | ||
| Expect(err).NotTo(HaveOccurred(), "Failed to list endpoint slices") |
There was a problem hiding this comment.
use Eventually(komega.List( ?
miyadav
force-pushed
the
OCP-85688
branch
2 times, most recently
from
b268ddc to
1e16023
Compare
| featureSet, err := oc.WithoutNamespace().Run("get").Args("featuregate", "cluster", "-o=jsonpath={.spec.featureSet}").Output() | ||
| Expect(err).NotTo(HaveOccurred(), "Failed to get featureSet") | ||
|
|
||
| // Check against the same constants used by SkipIfNotTechPreviewNoUpgrade and SkipIfNotCustomNoUpgrade | ||
| if featureSet != string(configv1.TechPreviewNoUpgrade) && featureSet != string(configv1.CustomNoUpgrade) { | ||
| Skip("Cluster does not have TechPreviewNoUpgrade or CustomNoUpgrade featuregate enabled. Not a valid cluster for this test.") | ||
| } | ||
| }) |
There was a problem hiding this comment.
@miyadav here seems better to create a new fun SkipIfNotTechPreviewNoUpgradeOrCustomNoUpgrade
|
@miyadav: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
@chrischdi PTAL when you have time , if we can merge this or any comments. |
|
@damdo PTAL when time permits , it is for - https://issues.redhat.com/browse/OCPBUGS-63519 |
2 participants
Automated e2e test for bug.
cc - @huali9 , @sunzhaohua2