No-Jira: shared helper that builds the params and providerSpec#450
No-Jira: shared helper that builds the params and providerSpec#450miyadav wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
@miyadav: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/lgtm |
|
/test e2e-azure-operator |
|
@miyadav: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@RadekManak PTAL when time permits. |
@RadekManak as you suggested in earlier review, created shared helper. PTAL when time permits.
cc @sunzhaohua2 @huali9