Skip to content

No-Jira: shared helper that builds the params and providerSpec#450

Open
miyadav wants to merge 1 commit intoopenshift:masterfrom
miyadav:refractorcode
Open

No-Jira: shared helper that builds the params and providerSpec#450
miyadav wants to merge 1 commit intoopenshift:masterfrom
miyadav:refractorcode

Conversation

@miyadav
Copy link
Copy Markdown
Member

@miyadav miyadav commented Nov 27, 2025

@RadekManak as you suggested in earlier review, created shared helper. PTAL when time permits.
cc @sunzhaohua2 @huali9

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 27, 2025
@openshift-ci-robot
Copy link
Copy Markdown

@miyadav: This pull request explicitly references no jira issue.

Details

In response to this:

@RadekManak as you suggested in earlier review, created shared helper. PTAL when time permits.
cc @sunzhaohua2 @huali9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Nov 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign racheljpg for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sunzhaohua2
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2025
@miyadav
Copy link
Copy Markdown
Member Author

miyadav commented Dec 17, 2025

/test e2e-azure-operator

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Dec 17, 2025

@miyadav: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@miyadav
Copy link
Copy Markdown
Member Author

miyadav commented Jan 26, 2026

@RadekManak PTAL when time permits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants