-
Notifications
You must be signed in to change notification settings - Fork 87
DNM/SPLAT/OCPBUGS-86789: e2e-ccm-aws: investigate #tmp-ocpbugs-86789-early-requests #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mtulio
wants to merge
22
commits into
openshift:main
Choose a base branch
from
mtulio:ccm-aws-ote-mvp-nlb-hc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
dce0c27
init test running successfully for 5.5
mtulio 14069d6
health: add per-poll TG snapshots and TG attribute introspection
mtulio 9f6750a
e2e: add graceful shutdown, Scenario 5.2, consistent timing model
mtulio 44f55af
e2e: master-node targeting, cross-zone, CAPA variant, t0-t4 timers
mtulio 2e06ea6
e2e: 90s post-healthy observation, environment summary in report
mtulio c3068f1
e2e: fix TG healthy wait stuck, add PollOnce, use control-plane label
mtulio de7f1b1
e2e: log client and observer start times
mtulio 013f9c2
health: add README documenting the NLB health transition test framework
mtulio e107f3e
e2e: add request statistics and per-phase breakdown to report
mtulio d5fa8dc
e2e: add duration column to per-phase request breakdown
mtulio bf37dd9
e2e: restore removed comments in phase classification
mtulio 0b9194e
e2e: parallel client workers, fix unhealthy.draining state matching
mtulio 21bee92
health: update README with parallel workers, request stats, CAPA finding
mtulio 0e80b33
e2e: add per-server request distribution and server-side verdict
mtulio 16bde17
health: update README with per-server distribution and verdict sections
mtulio 990a4cb
e2e: tune workers to 8×100ms, add pod→node mapping, req/s metrics
mtulio 199f306
e2e: hostNetwork mode, SIGTERM-based shutdown, privileged SCC
mtulio c962a18
e2e: unified binary with in-cluster client, aggregator, and metrics
mtulio db07955
e2e: add CLB baseline comparison, fix verdict phase boundaries, renam…
mtulio e914c77
e2e: add SDK-managed NLB tests with four-variant comparison matrix
mtulio def241a
e2e: add KAS-config SDK variants with real TG draining attributes
mtulio 866f49d
e2e: add KAS TLS SDK variant and LateConnections shutdown metric
mtulio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
10 changes: 10 additions & 0 deletions
10
openshift-tests/ccm-aws-tests/cmd/e2e-nlb-health-test/Dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| FROM golang:1.22-alpine AS builder | ||
| WORKDIR /build | ||
| COPY *.go . | ||
| RUN go mod init e2e-nlb-health-test && \ | ||
| go mod edit -go=1.22 && \ | ||
| CGO_ENABLED=0 go build -ldflags="-s -w" -o e2e-nlb-health-test . | ||
|
|
||
| FROM scratch | ||
| COPY --from=builder /build/e2e-nlb-health-test /e2e-nlb-health-test | ||
| ENTRYPOINT ["/e2e-nlb-health-test"] | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Harden and make the test image reproducible.
Pin the non-Red Hat builder image by digest, add a numeric non-root
USERto the final image, and define a compatible exec-formHEALTHCHECK. The current image uses a mutable builder tag, runs the binary as root, and provides no container health signal.📍 Affects 1 file
openshift-tests/ccm-aws-tests/cmd/e2e-nlb-health-test/Dockerfile#L8-L10(this comment)openshift-tests/ccm-aws-tests/cmd/e2e-nlb-health-test/Dockerfile#L8-L10openshift-tests/ccm-aws-tests/cmd/e2e-nlb-health-test/Dockerfile#L1-L1🤖 Prompt for AI Agents
Sources: Path instructions, Linters/SAST tools