Skip to content

Update boilerplate to latest version - #345

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
anispate:boilerplate-update-20260709
Jul 9, 2026
Merged

Update boilerplate to latest version#345
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
anispate:boilerplate-update-20260709

Conversation

@anispate

@anispate anispate commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Added onError: continue to Tekton pipeline tasks so non-fatal agentic SDLC check failures no longer block the pipeline
  • Improved CLAUDE.md content validation to resolve one level of @ include references before scanning for required sections
  • Fixed OPERATOR_NAME extraction regex in the boilerplate update script to handle assignment operators (= or :=) between the constant name and value

Changes

  • .tekton/deadmanssnitch-operator-agentic-sdlc-check-pull-request.yaml: Added onError: continue to check-file-existence and check-content-validation tasks
  • boilerplate/openshift/golang-osd-operator/agentic-sdlc-check-pull-request.yaml.tmpl: Same template-level change
  • boilerplate/openshift/golang-osd-operator/update: Fixed OPERATOR_NAME sed regex to match OperatorName = "..." and OperatorName := "..." patterns
  • boilerplate/_data/last-boilerplate-commit: Updated to 263afb10321f05af42d3fc928b7ccffd601d5996

Validation

  • Boilerplate update applied cleanly via make boilerplate-update

References


Created with assistance from Claude claude@anthropic.com

Created using the rosa-sre-operator-maintenance plugin from rosa-claude-plugins

Summary by CodeRabbit

  • Bug Fixes
    • Validation now checks referenced documentation content more reliably, reducing false failures when required sections are included via linked files.
    • Some non-critical check failures no longer stop the full validation run, allowing later checks to complete.

Update boilerplate framework with agentic SDLC check improvements and
operator name extraction fix.

Changes include:
- Added `onError: continue` to check-file-existence and
  check-content-validation Tekton pipeline tasks so non-fatal check
  failures no longer block the pipeline
- Improved CLAUDE.md content validation to resolve one level of @
  include references before scanning for required sections
- Fixed OPERATOR_NAME extraction regex in the update script to handle
  assignment operators (= or :=) between the constant name and value
- Updated boilerplate commit hash to 263afb10321f05af42d3fc928b7ccffd601d5996

Changes applied via `make boilerplate-update`.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: fe3a831d-bd17-4dee-986d-a3f302ae144a

📥 Commits

Reviewing files that changed from the base of the PR and between 7f8a2d6 and b630c02.

⛔ Files ignored due to path filters (3)
  • boilerplate/_data/last-boilerplate-commit is excluded by !boilerplate/**
  • boilerplate/openshift/golang-osd-operator/agentic-sdlc-check-pull-request.yaml.tmpl is excluded by !boilerplate/**
  • boilerplate/openshift/golang-osd-operator/update is excluded by !boilerplate/**
📒 Files selected for processing (1)
  • .tekton/deadmanssnitch-operator-agentic-sdlc-check-pull-request.yaml

Walkthrough

This PR modifies a Tekton PipelineRun YAML for the deadmanssnitch-operator agentic SDLC pull request check. It adds onError: continue to the check-file-existence and check-content-validation tasks, and updates the content validation script to resolve one level of @... references in CLAUDE.md before validating required sections.

Changes

Pipeline Task Error Handling and Content Validation

Layer / File(s) Summary
Non-fatal task error handling
.tekton/deadmanssnitch-operator-agentic-sdlc-check-pull-request.yaml
Adds onError: continue to check-file-existence and check-content-validation tasks so their failures do not halt the pipeline.
CLAUDE.md reference resolution
.tekton/deadmanssnitch-operator-agentic-sdlc-check-pull-request.yaml
Updates the required-sections check to parse @... references in CLAUDE.md, include existing referenced files, deduplicate/sort them, and validate headings against the combined content instead of only CLAUDE.md.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested labels: approved, lgtm

Suggested reviewers: rafael-azevedo, robotmaxtron

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects that this PR updates the boilerplate to a newer version and matches the main change set.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo test titles were added or changed; the diff only updates Tekton YAML, a boilerplate marker, and a shell regex.
Test Structure And Quality ✅ Passed PR changes only Tekton/boilerplate YAML and a script; no Ginkgo test code was modified, so the test-quality checklist is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; only Tekton/boilerplate files changed, so MicroShift API compatibility isn’t implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only changes Tekton YAML and boilerplate scripts; no Ginkgo e2e tests or SNO-sensitive test logic were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only Tekton/boilerplate scripts changed; no nodeSelector, affinity, spread, tolerations, or replica scheduling logic was added.
Ote Binary Stdout Contract ✅ Passed PR only changes Tekton YAML, boilerplate shell script, and metadata; no Go/binary/test setup files or stdout-process code were touched.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo/e2e test files or test additions changed; diff only touches Tekton YAML and boilerplate scripts, so this compatibility check is not applicable.
No-Weak-Crypto ✅ Passed Changed hunks only touch Tekton config, a regex, and a commit hash; no md5/sha1/des/rc4/3des/blowfish/ECB or custom secret comparisons appeared.
Container-Privileges ✅ Passed No touched Tekton/K8s manifests set privileged, hostPID/Network/IPC, allowPrivilegeEscalation, SYS_ADMIN, or root securityContext.
No-Sensitive-Data-In-Logs ✅ Passed Changed scripts only emit generic status messages; no passwords, tokens, PII, hostnames, or customer data are logged.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2026
@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@anispate: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.28%. Comparing base (7f8a2d6) to head (b630c02).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #345   +/-   ##
=======================================
  Coverage   43.28%   43.28%           
=======================================
  Files          11       11           
  Lines         834      834           
=======================================
  Hits          361      361           
  Misses        424      424           
  Partials       49       49           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aliceh

aliceh commented Jul 9, 2026

Copy link
Copy Markdown

/lgtm

1 similar comment
@nephomaniac

Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2026
@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliceh, anispate, nephomaniac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [aliceh,anispate,nephomaniac]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 114c9a9 into openshift:master Jul 9, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants