OCPBUGS-43501: fix kargs handling in ABI Minimal ISO#10578
Open
zaneb wants to merge 2 commits into
Open
Conversation
openshift-ci-robot
added
jira/severity-moderate
Contributor
|
@zaneb: This pull request references Jira Issue OCPBUGS-43501, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note
|
| Layer / File(s) | Summary |
|---|---|
Direct dependency version updates go.mod |
Updated direct requires: github.com/diskfs/go-diskfs (to a newer commit-based prerelease), github.com/hashicorp/go-version → v1.8.0, github.com/onsi/gomega → v1.39.1, github.com/openshift/assisted-image-service → newer prerelease, and github.com/sirupsen/logrus → v1.9.4. |
Indirect dependency consolidation go.mod |
Added github.com/anchore/go-lzo // indirect and moved existing indirect entries github.com/djherbis/times // indirect and github.com/klauspost/compress // indirect into a consolidated indirect require block (versions unchanged). |
🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The PR title references OCPBUGS-43501 and mentions fixing kargs handling in ABI Minimal ISO, which directly corresponds to the PR's main objective of updating assisted-image-service to include a kargs fix for the minimal ISO. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Stable And Deterministic Test Names | ✅ Passed | PR contains only dependency updates in go.mod and related vendor changes. No Ginkgo test names were added or modified. Existing Ginkgo tests use static descriptive test titles without dynamic content. |
| Test Structure And Quality | ✅ Passed | PR updates go.mod dependencies without modifying test files; all test files are repo imports (added status), not new test code subject to the quality review. |
| Microshift Test Compatibility | ✅ Passed | PR contains only dependency updates (go.mod/go.sum changes); no new Ginkgo e2e tests were added, so MicroShift compatibility check is not applicable. |
| Single Node Openshift (Sno) Test Compatibility | ✅ Passed | No new Ginkgo e2e tests added. PR only updates Go module dependencies in go.mod and vendored packages; check not applicable. |
| Topology-Aware Scheduling Compatibility | ✅ Passed | PR updates Go dependencies only (go.mod). No deployment manifests, operator code, or controllers are added or modified, so the topology-aware scheduling check does not apply. |
| Ote Binary Stdout Contract | ✅ Passed | Dependency-only update with proper stdout redirection in both main() functions. klog and logrus configured to discard/stderr output, preventing OTE JSON contract corruption. |
| Ipv6 And Disconnected Network Test Compatibility | ✅ Passed | No new Ginkgo e2e tests (It, Describe, Context, When) are added in this PR. Changes are limited to go.mod/go.sum dependency updates for assisted-image-service and other libraries. |
| No-Weak-Crypto | ✅ Passed | PR only updates go.mod/go.sum dependencies. No new weak crypto (MD5, SHA1, DES, RC4, 3DES, Blowfish ECB, or custom crypto) introduced in source code; vendor-only weak patterns are pre-existing. |
| Container-Privileges | ✅ Passed | No container/K8s manifests with privileged settings detected. PR updates Go module dependencies only; no container security configs modified. |
| No-Sensitive-Data-In-Logs | ✅ Passed | PR contains only go.mod dependency updates with no source code changes and no new logging code introduced; no sensitive data logging patterns detected. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Warning
There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.
🔧 golangci-lint (2.12.2)
Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
Comment @coderabbitai help to get the list of available commands and usage tips.
Member
Author
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
Contributor
|
@zaneb: This pull request references Jira Issue OCPBUGS-43501, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
@zaneb: This pull request references Jira Issue OCPBUGS-43501, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Around line 164-173: Update the vulnerable indirect module
github.com/go-jose/go-jose/v4 from v4.1.3 to a patched release (e.g., v4.1.4) in
go.mod and re-resolve modules so go.sum is refreshed; specifically change the
version entry for github.com/go-jose/go-jose/v4 to v4.1.4 (or newer), then run
the module resolution commands (e.g., go get
github.com/go-jose/go-jose/v4@v4.1.4 and go mod tidy) to update go.sum and
ensure the vulnerability GHSA-78h2-9frx-2jm8 / GO-2026-4945 is patched.
- Line 45: Replace the pseudo-version pins with stable tagged releases by
updating the module entries for github.com/diskfs/go-diskfs and
github.com/openshift/assisted-image-service to their latest stable semver tags
(replace the v1.7.1-... and v0.0.0-... pseudo-versions), bump
github.com/go-jose/go-jose/v4 from v4.1.3 to v4.1.4 (or later) to address
GHSA-78h2-9frx-2jm8, and either remove or document the justification/license
evidence for the indirect github.com/anchore/go-lzo dependency if it was
introduced here; after editing go.mod run the standard go toolchain steps (go
get ./..., go mod tidy) to update go.sum and verify builds/tests.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 886780ad-0898-4ce1-a044-987f8691bb2a
⛔ Files ignored due to path filters (110)
go.sumis excluded by!**/*.sumvendor/github.com/anchore/go-lzo/.binny.yamlis excluded by!**/vendor/**,!vendor/**vendor/github.com/anchore/go-lzo/.bouncer.yamlis excluded by!**/vendor/**,!vendor/**vendor/github.com/anchore/go-lzo/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/anchore/go-lzo/.goreleaser.yamlis excluded by!**/vendor/**,!vendor/**vendor/github.com/anchore/go-lzo/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/anchore/go-lzo/CONTRIBUTING.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/anchore/go-lzo/DEVELOPING.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/anchore/go-lzo/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/anchore/go-lzo/Makefileis excluded by!**/vendor/**,!vendor/**vendor/github.com/anchore/go-lzo/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/anchore/go-lzo/Taskfile.yamlis excluded by!**/vendor/**,!vendor/**vendor/github.com/anchore/go-lzo/decompress.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/anchore/go-lzo/reader.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/.gitignoreis excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/.golangci.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/Makefileis excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/backend/file/file.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/backend/interface.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/backend/substorage.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/disk/disk.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/disk/disk_unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/diskfs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/ext4/blockgroup.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/ext4/checksum.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/ext4/ext4.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/ext4/extent.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/ext4/file.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/ext4/groupdescriptors.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/ext4/superblock.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/fat32/directory.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/fat32/directoryentry.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/fat32/fat32.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/fat32/file.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/fat32/fileinfo.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/fat32/fsinfosector.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/fat32/table.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/filesystem.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/iso9660/directoryentry.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/iso9660/eltorito.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/iso9660/file.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/iso9660/finalize.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/iso9660/iso9660.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/iso9660/rockridge.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/iso9660/statt_others.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/iso9660/volume_descriptor.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/squashfs/compressor.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/squashfs/directoryentry.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/squashfs/file.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/squashfs/finalize.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/squashfs/finalize_unix.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/squashfs/finalizefileinfo.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/squashfs/fragment.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/squashfs/inode.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/squashfs/squashfs.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/squashfs/superblock.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/filesystem/squashfs/xattr.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/partition/gpt/partition.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/partition/gpt/table.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/partition/mbr/partition.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/partition/mbr/table.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/partition/part/partition.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/partition/partition.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/partition/table.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/util/bitmap/bitmap.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/util/file.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/util/slices/uniqify.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/util/version.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/diskfs/go-diskfs/version/version.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/golang/mock/AUTHORSis excluded by!**/vendor/**,!vendor/**vendor/github.com/golang/mock/CONTRIBUTORSis excluded by!**/vendor/**,!vendor/**vendor/github.com/golang/mock/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/golang/mock/gomock/call.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/golang/mock/gomock/callset.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/golang/mock/gomock/controller.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/golang/mock/gomock/doc.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/golang/mock/gomock/matchers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/hashicorp/go-version/LICENSEis excluded by!**/vendor/**,!vendor/**vendor/github.com/hashicorp/go-version/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/hashicorp/go-version/constraint.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/hashicorp/go-version/version.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/hashicorp/go-version/version_collection.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/onsi/gomega/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/onsi/gomega/format/format.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/onsi/gomega/gomega_dsl.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/onsi/gomega/matchers.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/onsi/gomega/matchers/have_key_matcher.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/onsi/gomega/matchers/have_key_with_value_matcher.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/onsi/gomega/matchers/match_error_strictly_matcher.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/onsi/gomega/matchers/support/goraph/edge/edge.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/assisted-image-service/pkg/isoeditor/isoutil.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/assisted-image-service/pkg/isoeditor/mock_editor.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/assisted-image-service/pkg/isoeditor/mock_executer.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/assisted-image-service/pkg/isoeditor/mock_nmstate_handler.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/assisted-image-service/pkg/isoeditor/mock_nmstatectl_extractor.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/assisted-image-service/pkg/isoeditor/mock_nmstatectl_extractor_factory.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/assisted-image-service/pkg/isoeditor/nmstate_handler.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/openshift/assisted-image-service/pkg/isoeditor/rhcos.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/sirupsen/logrus/.golangci.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/sirupsen/logrus/CHANGELOG.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/sirupsen/logrus/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/sirupsen/logrus/appveyor.ymlis excluded by!**/vendor/**,!vendor/**vendor/github.com/sirupsen/logrus/entry.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/sirupsen/logrus/hooks.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/sirupsen/logrus/hooks/test/test.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/sirupsen/logrus/logger.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/sirupsen/logrus/logrus.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/sirupsen/logrus/text_formatter.gois excluded by!**/vendor/**,!vendor/**vendor/modules.txtis excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (1)
go.mod
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
needs-rebase
This pulls in the latest version of go-diskfs, which has the effect of naming files added to an ISO with the ISO 9660 Level 1 short filenames (8.3) generated by default in xorriso, and expected by coreos-installer.
Update to the latest assisted-image-service library with the fix for kargs in the minimal ISO, allowing them to be manipulated with coreos-installer.
openshift-ci
Bot
removed
the
needs-rebase
Contributor
|
@zaneb: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to the latest assisted-image-service library with the fix for
kargs in the minimal ISO, allowing them to be manipulated with
coreos-installer.
Note that this PR also includes a commit from #10315, which first updates assisted-image-service to a slightly earlier version, so that we can keep track of when the various changes are introduced.
Summary by CodeRabbit