SREP-2508 - Revert openshift.io/cluster-monitoring label enforcement

[tnierman]

Reverts logic preventing non-admins from adding the openshift.io/cluster-monitoring label to non-platform namespaces, as this change ultimately proved too disruptive for customers and RH alike.

[diakovnec]

Hi @tnierman
I've been looking into this and trying to get my head around of what we are trying to achive here and got a bit lost, reading the Slack thread and the previous PRs e.g. 387, 420, 393

Correct me if I am wrong, the goal is to allow non-admins to be able to add/remove/modify the openshift.io/cluster-monitoring label to non-platform namespaces?

[diakovnec]

reached out for clarification in https://redhat-internal.slack.com/archives/C035W96HKN3/p1763355409770629?thread_ts=1761320979.484619&cid=C035W96HKN3

[feichashao]

I am trying to understand why we add !amIAdmin(request) in this condition. It seems line 186 should already checked amIAdmin(request)? or is there anything specific here?

[coleenquadros]

Hi is there any update on this? We have regression suites failing due to this change. I had created a PR #436 to add the exception but was told that this restriction would be reverted

[diakovnec]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: diakovnec, tnierman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [diakovnec,tnierman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@tnierman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.