Skip to content

Conversation

@wgabor0427
Copy link
Contributor

@wgabor0427 wgabor0427 commented Dec 9, 2025

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 9, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Dec 9, 2025

* Integration is supported with the OpenShift monitoring stack.

[id="zero-trust-manager-1-0-0-bug-fixes_{context}"]
=== Bug fixes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few bugs which were resolved
SPIRE-68: Updating the operands CR spec sometimes does not trigger reconciliation
SPIRE-60: Agent runs as non-root user
SPIRE-190: Remove the SCC for the OIDC Discovery Provider

@lunarwhite please check if I had missed any??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This list is complete.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

toc::[]

The {zero-trust-full} leverages Secure Production Identity Framework for Everyone (SPIFFE) and the SPIFFE Runtime Environment (SPIRE) to provide a comprehensive identity management solution for distributed systems. {zero-trust-full} supports SPIRE version 1.12.4 running as an operand.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could remove this sentence: https://github.com/openshift/openshift-docs/blob/9eaec7a7c25eb2558d4ca9ddaf2070ae9dc43d63/security/zero_trust_workload_identity_manager/zero-trust-manager-release-notes.adoc?plain=1#L10C216-L10C286, as the versions are explicitly mentioned in the chart:

{zero-trust-full} supports the following components and versions:
. There is no need to maintain it in two places, which would only increase the maintainance burden for each release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


* Customer Action Required:

** Review the `federation` configuration within the `SpireServer Custom Resource (CR).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
** Review the `federation` configuration within the `SpireServer Custom Resource (CR).
** Review the `federation` configuration within the `SpireServer` Custom Resource (CR).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


** `SpireAgent.spec.socketPath`
** `SpiffeCSIDriver.spec.agentSocketPath`
** `ApiffeCSIDriver.spec.pluginName`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
** `ApiffeCSIDriver.spec.pluginName`
** `SpiffeCSIDriver.spec.pluginName`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

* Verification types:

** `auto` (default): Verification utilizes OpenShift defaults (`/etc/kubernetes/kubelet-ca.crt`).
** `hostCert': Uses a custom CA certificate path.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
** `hostCert': Uses a custom CA certificate path.
** `hostCert`: Uses a custom CA certificate path.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


** `auto` (default): Verification utilizes OpenShift defaults (`/etc/kubernetes/kubelet-ca.crt`).
** `hostCert': Uses a custom CA certificate path.
** `skip``: Skips TLS verification (not recommended for production use).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
** `skip``: Skips TLS verification (not recommended for production use).
** `skip`: Skips TLS verification (not recommended for production use).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


* The Operator and all associated operands can now be deployed within a custom namespace, providing flexibility for organizations with specific namespace governance requirements.

[id="zero-trust-manager-1-0-0-postgres-database-support_{context}"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to move this item (PostgreSQL database support) to the position right after SPIRE federation support.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


* SPIRE Agent and SPIFFE CSI Driver now operate under the restricted Security Context Constraints (SCC).

* All operand containers are configured with the `ReadOnlyRootFilesystem` set to `true`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* All operand containers are configured with the `ReadOnlyRootFilesystem` set to `true`.
* Operator and all operand containers are configured with the `ReadOnlyRootFilesystem` set to `true`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines 149 to 172
[id="zero-trust-manager-1-0-0-immutable-fields_{context}"]
==== Immutable fields

The following fields are now strictly enforced as *immutable* after initial creation:

[cols="1,1,1",options="header"]
|===
| Custom resource
| Field
| Notes

| ZeroTrustWorkloadIdentityManager
| `trustDomain`, `clusterName`, `bundleConfigMap`
| Cannot be modified post-creation.

| SpireServer
| `persistence.size`, `persistence.accessMode`, `persistence.storageClass`
| Cannot be modified post-creation.

| SpireServer
| `federation.bundleEndpoint`
| Cannot be removed once configured.
|===

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@openshift-ci
Copy link

openshift-ci bot commented Dec 10, 2025

@wgabor0427: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@lunarwhite lunarwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
expect for minor nitpicks

| Updating the operands CR spec sometimes does not trigger reconciliation.

| SPIRE-190
| Updating the operands CR spec sometimes does not trigger reconciliation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Updating the operands CR spec sometimes does not trigger reconciliation.
| Remove redundant SCC for the OIDC Discovery Provider.


SPIRE Server now supports PostgreSQL as an external database backend, accommodating production deployments that necessitate enterprise-grade data persistence and high availability.

* Supported Types: sqlite3 (default), postgres, mysql.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Supported Types: sqlite3 (default), postgres, mysql.
* Supported Types: `sqlite3` (default), `postgres`, `mysql`.


This release introduces flexible logging controls to improve observability and debugging across the platform:

* SPIRE Components: Users can now configure the `logLevel` (debug, info, warn, error) and `logFormat` (text, JSON) independently for `SpireServer`, `SpireAgent`, and `SpireOIDCDiscoveryProvider` directly within their CR specifications. The defaults are set to "info" for the `logLevel` and "text" for the `logFormat.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* SPIRE Components: Users can now configure the `logLevel` (debug, info, warn, error) and `logFormat` (text, JSON) independently for `SpireServer`, `SpireAgent`, and `SpireOIDCDiscoveryProvider` directly within their CR specifications. The defaults are set to "info" for the `logLevel` and "text" for the `logFormat.
* SPIRE Components: Users can now configure the `logLevel` (debug, info, warn, error) and `logFormat` (text, JSON) independently for `SpireServer`, `SpireAgent`, and `SpireOIDCDiscoveryProvider` directly within their CR specifications. The defaults are set to "info" for the `logLevel` and "text" for the `logFormat`.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants