Skip to content

ROX-33686: Update supported OpenShift version list for dynamic plugin#108995

Open
dvail wants to merge 1 commit intoopenshift:rhacs-docs-mainfrom
dvail:dv/ROX-33686-docs-version-update
Open

ROX-33686: Update supported OpenShift version list for dynamic plugin#108995
dvail wants to merge 1 commit intoopenshift:rhacs-docs-mainfrom
dvail:dv/ROX-33686-docs-version-update

Conversation

@dvail
Copy link

@dvail dvail commented Mar 25, 2026

Version(s):
4.10

Issue:
https://redhat.atlassian.net/browse/ROX-33686

Note to reviewers:
Draft docs content change for the above issue. Feel free to edit this PR, change the base branch, or cherry-pick the change into your own branch as needed!

Link to docs preview:

https://108995--ocpdocs-pr.netlify.app/openshift-acs/latest/configuration/accessing-vulnerability-information-in-web-console.html

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 25, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2026

@dvail: This pull request references ROX-33686 which is a valid jira issue.

Details

In response to this:

Version(s):
4.10

Issue:
https://redhat.atlassian.net/browse/ROX-33686

Note to reviewers:
Draft docs content change for the above issue

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2026
@openshift-ci
Copy link

openshift-ci bot commented Mar 25, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 25, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2026

@dvail: This pull request references ROX-33686 which is a valid jira issue.

Details

In response to this:

Version(s):
4.10

Issue:
https://redhat.atlassian.net/browse/ROX-33686

Note to reviewers:
Draft docs content change for the above issue. Feel free to edit this PR, change the base branch, or cherry-pick the change into your own branch as needed!

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kcarmichael08
Copy link
Contributor

This LGTM. Can you please change the parent branch to rhacs-docs-main and then I will merge and cherry pick to rhacs-docs-4.10? Also I think the draft label needs to be removed so that the CI jobs can run. (No worries that it will be accidentally merged - only a few of us have merge rights.) Thank you!

@kcarmichael08 kcarmichael08 added RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.10 labels Mar 25, 2026
@dvail
Copy link
Author

dvail commented Mar 25, 2026

@kcarmichael08

change the parent branch to rhacs-docs-main and then I will merge and cherry pick to rhacs-docs-4.10

This change is specific to the 4.10 tech preview release, I believe the current text of "4.19 or later" is what will be true for 4.11 and beyond, at least for the next few releases.

Also, this hasn't been merged into 4.10 yet stackrox/stackrox#19527 so FYI on timing for when to merge the docs change.

@dvail dvail marked this pull request as ready for review March 25, 2026 13:34
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2026
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 25, 2026

@kcarmichael08
Copy link
Contributor

@kcarmichael08

change the parent branch to rhacs-docs-main and then I will merge and cherry pick to rhacs-docs-4.10

This change is specific to the 4.10 tech preview release, I believe the current text of "4.19 or later" is what will be true for 4.11 and beyond, at least for the next few releases.

Also, this hasn't been merged into 4.10 yet stackrox/stackrox#19527 so FYI on timing for when to merge the docs change.

OK, I guess it's a judgment call on this then. The main branch is never published - the numbered branches are what gets published. So typically the current behavior (only 4.19-4.21 OCP support) would get merged to main and then cherry picked to 4.10. I understand that it would require a subsequent change when releases 4.22+ are supported (that would be CP'd to 4.11 and later ACS versions). But I would prefer to follow the established workflow of "current behavior -> rhacs-docs-main and then CP to branches" to avoid any confusion with later updates.

(I assume there will be a ticket or communication later for the 4.22+ support. If not, then maybe this is a good reason to deviate from the normal workflow.)

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2026

@dvail: This pull request references ROX-33686 which is a valid jira issue.

Details

In response to this:

Version(s):
4.10

Issue:
https://redhat.atlassian.net/browse/ROX-33686

Note to reviewers:
Draft docs content change for the above issue. Feel free to edit this PR, change the base branch, or cherry-pick the change into your own branch as needed!

Link to docs preview:

https://108995--ocpdocs-pr.netlify.app/openshift-acs/latest/configuration/accessing-vulnerability-information-in-web-console.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dvail
Copy link
Author

dvail commented Mar 25, 2026

@kcarmichael08 Totally makes sense, I'll change the base branch.

I assume there will be a ticket or communication later for the 4.22+ support.

Yes definitely, I'll make a note in our epic so that this doesn't get overlooked when 4.11 is released.

@dvail dvail changed the base branch from rhacs-docs-4.10 to rhacs-docs-main March 25, 2026 14:30
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2026

@dvail: This pull request references ROX-33686 which is a valid jira issue.

Details

In response to this:

Version(s):
4.10

Issue:
https://redhat.atlassian.net/browse/ROX-33686

Note to reviewers:
Draft docs content change for the above issue. Feel free to edit this PR, change the base branch, or cherry-pick the change into your own branch as needed!

Link to docs preview:

https://108995--ocpdocs-pr.netlify.app/openshift-acs/latest/configuration/accessing-vulnerability-information-in-web-console.html

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2026
@dvail dvail force-pushed the dv/ROX-33686-docs-version-update branch from 65e26d5 to 93f7d97 Compare March 25, 2026 14:32
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 25, 2026
@dvail dvail force-pushed the dv/ROX-33686-docs-version-update branch from 93f7d97 to 7d0c45a Compare March 25, 2026 14:35
@openshift-ci
Copy link

openshift-ci bot commented Mar 25, 2026

@dvail: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.10 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants