-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS-14356-New: Added bond best practices info to networking docs #93160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
🤖 Thu Dec 18 14:40:46 - Prow CI generated the docs preview: |
3296fa2 to
318fd00
Compare
|
/retest |
318fd00 to
1b5443b
Compare
1b5443b to
5b7d324
Compare
02430e1 to
58716d3
Compare
a29819f to
3ce4e93
Compare
| `node-role.kubernetes.io/worker`:: A node selector that specifies the nodes to apply the node network configuration policy to. | ||
| + | ||
| `metadata.name`:: The name for the configuration object. | ||
| `node-role.kubernetes.io/worker::` A node selector that specifies the nodes to apply the node network configuration policy to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a typo?
r::`
is this a typo? :: after the back-quote?
3ce4e93 to
40da5f1
Compare
| @@ -0,0 +1,15 @@ | |||
| // Module included in the following assemblies: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.ShortDescription: Assign [role="_abstract"] to a paragraph to use it as in DITA.
| @@ -0,0 +1,15 @@ | |||
| // Module included in the following assemblies: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.TaskContents: The '.Procedure' block title is missing.
| Optional: You can bond multiple network interfaces to a single interface by using the `bond=` option. Refer to the following examples: | ||
| As an optional configuration, you can bond multiple network interfaces to a single interface by using the `bond=` option. To apply this configuration to your cluster, complete the procedure steps for each node that runs on your cluster. | ||
|
|
||
| .Procedure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.BlockTitle: Block titles can only be assigned to examples, figures, and tables in DITA.
| As an optional configuration, you can bond multiple SR-IOV network interfaces to a dual port NIC interface by using the `bond=` option. | ||
|
|
||
| On each node, you must perform the following tasks: | ||
| .Procedure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.BlockTitle: Block titles can only be assigned to examples, figures, and tables in DITA.
| @@ -0,0 +1,24 @@ | |||
| // Module included in the following assemblies: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.ShortDescription: Assign [role="_abstract"] to a paragraph to use it as in DITA.
| @@ -0,0 +1,20 @@ | |||
| // Module included in the following assemblies: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.ShortDescription: Assign [role="_abstract"] to a paragraph to use it as in DITA.
40da5f1 to
a103331
Compare
| @@ -0,0 +1,16 @@ | |||
| // Module included in the following assemblies: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.TaskContents: The '.Procedure' block title is missing.
| As an optional configuration, you can bond multiple SR-IOV network interfaces to a dual port NIC interface by using the `bond=` option. | ||
|
|
||
| On each node, you must perform the following tasks: | ||
| .Procedure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.BlockTitle: Block titles can only be assigned to examples, figures, and tables in DITA.
a103331 to
1e179f5
Compare
| @@ -0,0 +1,16 @@ | |||
| // Module included in the following assemblies: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.TaskContents: The '.Procedure' block title is missing.
| Optional: You can bond multiple network interfaces to a single interface by using the `bond=` option. Refer to the following examples: | ||
| As an optional configuration, you can bond multiple network interfaces to a single interface by using the `bond=` option. To apply this configuration to your cluster, complete the procedure steps for each node that runs on your cluster. | ||
|
|
||
| .Procedure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.BlockTitle: Block titles can only be assigned to examples, figures, and tables in DITA.
| As an optional configuration, you can bond multiple SR-IOV network interfaces to a dual port NIC interface by using the `bond=` option. | ||
|
|
||
| On each node, you must perform the following tasks: | ||
| .Procedure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] AsciiDocDITA.BlockTitle: Block titles can only be assigned to examples, figures, and tables in DITA.
|
@dfitzmau: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
cybertron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing inline, but otherwise lgtm.
|
|
||
| [NOTE] | ||
| ==== | ||
| As a postinstallation task, do not make configuration changes to the `br-ex` bridge or its underlying interfaces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want this note here. This is the section of the docs where we discuss the changes you can make when you deploy with a custom NMState br-ex.
Checklist of items:
Version(s):
4.12+
Issue:
OSDOCS-14356
Link to docs preview: