Skip to content

Conversation

@bergerhoffer
Copy link
Contributor

@bergerhoffer bergerhoffer commented Sep 15, 2025

…oviders

Version(s):
4.20

Issue:
https://issues.redhat.com/browse/OSDOCS-14939

Link to docs preview:
https://99028--ocpdocs-pr.netlify.app/openshift-enterprise/latest/authentication/external-auth.html#external-auth-providers_external-auth

QE review:

  • QE has approved this change.

Additional information:

This will be released in a 4.20 z-stream with GA support for direct auth.

@bergerhoffer bergerhoffer added this to the Planned for 4.20 GA milestone Sep 15, 2025
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 15, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 15, 2025

🤖 Tue Sep 30 15:35:55 - Prow CI generated the docs preview:

https://99028--ocpdocs-pr.netlify.app/openshift-enterprise/latest/authentication/external-auth.html

@bergerhoffer
Copy link
Contributor Author

@wewang58 @xingxingxia Can you please review and make sure this is correct to list GitLab as a supported OIDC provider for direct auth for 4.20?

https://99028--ocpdocs-pr.netlify.app/openshift-enterprise/latest/authentication/external-auth.html#external-auth-providers_external-auth

@wewang58
Copy link

LGTM need @xingxingxia confirm again.

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Sep 16, 2025

@wewang58 @xingxingxia PTAL again now that Ping Identity is added.

I've added the known issue to the release notes in #99127

@wewang58
Copy link

LGTM

@bergerhoffer
Copy link
Contributor Author

/label merge-review-needed

I can take care of merging if someone can perform the merge review

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 17, 2025
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ShaunaDiaz ShaunaDiaz added ok-to-merge and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Sep 17, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2025
@xingxingxia
Copy link
Contributor

@bergerhoffer , all the 6 additional providers for parity with OAuth server get tested now as https://issues.redhat.com/browse/CNTRLPLANE-933 . Would you mind add them?

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2025
@openshift-ci
Copy link

openshift-ci bot commented Sep 30, 2025

New changes are detected. LGTM label has been removed.

@bergerhoffer
Copy link
Contributor Author

@xingxingxia @wewang58 Updated to add the rest of the supported providers, can you please take another look?

I will wait to merge this until the feature goes GA in the future z-stream (assuming that's still the plan).

@openshift-ci
Copy link

openshift-ci bot commented Sep 30, 2025

@bergerhoffer: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bergerhoffer
Copy link
Contributor Author

The branch/enterprise-4.21 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.20. And any PR going into main must also target the latest version branch (enterprise-4.21).

If the update in your PR does NOT apply to version 4.21 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.20 branch/enterprise-4.21 ok-to-merge size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants