-
Notifications
You must be signed in to change notification settings - Fork 1.8k
OSDOCS#14939: Adding GitLab to the list of tested direct auth OIDC pr… #99028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
🤖 Tue Sep 30 15:35:55 - Prow CI generated the docs preview: https://99028--ocpdocs-pr.netlify.app/openshift-enterprise/latest/authentication/external-auth.html |
|
@wewang58 @xingxingxia Can you please review and make sure this is correct to list GitLab as a supported OIDC provider for direct auth for 4.20? |
|
LGTM need @xingxingxia confirm again. |
87bd13a to
bfd70e1
Compare
|
@wewang58 @xingxingxia PTAL again now that Ping Identity is added. I've added the known issue to the release notes in #99127 |
|
LGTM |
|
/label merge-review-needed I can take care of merging if someone can perform the merge review |
ShaunaDiaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
@bergerhoffer , all the 6 additional providers for parity with OAuth server get tested now as |
bfd70e1 to
53aae15
Compare
…irect auth OIDC providers
|
New changes are detected. LGTM label has been removed. |
53aae15 to
59ab020
Compare
|
@xingxingxia @wewang58 Updated to add the rest of the supported providers, can you please take another look? I will wait to merge this until the feature goes GA in the future z-stream (assuming that's still the plan). |
|
@bergerhoffer: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The This is because your PR targets the If the update in your PR does NOT apply to version 4.21 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main. |
…oviders
Version(s):
4.20
Issue:
https://issues.redhat.com/browse/OSDOCS-14939
Link to docs preview:
https://99028--ocpdocs-pr.netlify.app/openshift-enterprise/latest/authentication/external-auth.html#external-auth-providers_external-auth
QE review:
Additional information:
This will be released in a 4.20 z-stream with GA support for direct auth.