-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Rewrite MTV section in CNV docs #99589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
🤖 Tue Sep 30 22:36:21 - Prow CI generated the docs preview: |
ousleyp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Andy, thanks for doing this. It looks great overall but there are a few issues with the links and some nits/suggestions. Please also update the PR description to include which versions this applies to. IMO, it's ready for merge if you fix those issues and squash your commits.
modules/migrating-to-virt.adoc
Outdated
| * link:https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/{mtv-version}/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index%23creating-a-network-map[Mapping networks] and link:https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/{mtv-version}/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index%23creating-a-storage-map[mapping storage]: {mtv-short} helps you to map networks and storage from your source environment (for example, vSphere or RHV) to the {product-title} environment. This ensures that the migrated VMs have the correct network and storage configurations. | ||
| * Performing the migration: Once the migration plan is created and the networks and storage are mapped, you can perform the migration. {mtv-short} handles the transfer of VM data and configuration to the OpenShift cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IBM Style nit:
s/Once/After or s/Once/When
Use with caution once adverb
Use only to mean one time. Do not use as a conjunction to mean after or when.
96d0e62 to
c17899c
Compare
@ousleyp - your changes are all implemented |
|
@anarnold97: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
modules/migrating-to-virt.adoc
Outdated
| * link:https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/{mtv-version}/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index%23creating-a-migration-plan[Creating a migration plan]: A migration plan defines the VMs to be migrated, the source and destination environments, and other migration settings. This plan helps to organize and automate the migration process. | ||
| * link:https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/{mtv-version}/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index%23creating-a-network-map#about-network-maps_vmware[Mapping networks] and link:https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/{mtv-version}/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index%23creating-a-network-map#about-storage-maps_vmware[mapping storage]: {mtv-short} helps you to map networks and storage from your source environment (for example, vSphere or RHV) to the {product-title} environment. This ensures that the migrated VMs have the correct network and storage configurations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These three links (Creating a migration plan, Mapping networks, and mapping storage) don't work for me; they all point to the top of the page as if the links were all to https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/2.8/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index
@anarnold97 Do the links work on your end?
Signed-off-by: A.Arnold <anarnold@redhat.com>
14619ed to
9593c6f
Compare
|
@anarnold97: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Sorry @ousleyp - i can see the problem. it is the attribute version of MTV, which is set to 2.8 if i update that to 2.9 the links will work |
Ah ok! Thanks for checking, @anarnold97. So is this change only for enterprise-4.20+? |
|
@ousleyp - thanks for checking What do you mean that was too much |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing with the links - thanks! Since you're changing the attribute to 2.9 and you said that 2.9 was released to coincide with 4.19, it seems like this PR should be cherrypicked to 4.19 and 4.20[*]. Shall I assign those labels? Let me know when you're ready for merge.
[*] and a separate PR should later be opened to update the variable to 2.10 when that goes out - that would be against main and 4.20, I think?
| * link:https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/{mtv-version}/html/installing_and_using_the_migration_toolkit_for_virtualization/migrating-ova_ova#adding-source-provider_ova[Migrate virtual machines from OVA files created by {vmw-full}]. | ||
| * link:https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/{mtv-version}/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index#creating-plan-wizard-290-vmware_vmware[Creating a migration plan]: A migration plan defines the VMs to be migrated, the source and destination environments, and other migration settings. This plan helps to organize and automate the migration process. | ||
| * link:https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/{mtv-version}/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index#about-network-maps_vmware[Mapping networks] and link:https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/{mtv-version}/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index#about-network-maps_vmware[mapping storage]: {mtv-short} helps you to map networks and storage from your source environment (for example, vSphere or RHV) to the {product-title} environment. This ensures that the migrated VMs have the correct network and storage configurations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These links work better now if I copy and paste them and substitute 2.9 for {mtv-version} (though for some reason the preview build hasn't caught on yet). However, the "Mapping networks" and "mapping storage" URLs now both point to 7.8. About network maps in migration plans :)
|
@ousleyp - that would be awesome, thanks |
|
The This is because your PR targets the If the update in your PR does NOT apply to version 4.21 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main. |
Task
Quick rearrangement of the MTV section in CNV to make MTV a bit more included in CNV.
Version(s):
Issue:
Link to docs preview:
QE review:
Additional information: