Skip to content

Conversation

@anarnold97
Copy link
Contributor

@anarnold97 anarnold97 commented Sep 23, 2025

Task

Quick rearrangement of the MTV section in CNV to make MTV a bit more included in CNV.

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 23, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Sep 23, 2025

🤖 Tue Sep 30 22:36:21 - Prow CI generated the docs preview:
https://99589--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 23, 2025
Copy link
Member

@ousleyp ousleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Andy, thanks for doing this. It looks great overall but there are a few issues with the links and some nits/suggestions. Please also update the PR description to include which versions this applies to. IMO, it's ready for merge if you fix those issues and squash your commits.

* link:https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/{mtv-version}/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index%23creating-a-network-map[Mapping networks] and link:https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/{mtv-version}/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index%23creating-a-storage-map[mapping storage]: {mtv-short} helps you to map networks and storage from your source environment (for example, vSphere or RHV) to the {product-title} environment. This ensures that the migrated VMs have the correct network and storage configurations.
* Performing the migration: Once the migration plan is created and the networks and storage are mapped, you can perform the migration. {mtv-short} handles the transfer of VM data and configuration to the OpenShift cluster.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IBM Style nit:

s/Once/After or s/Once/When

Use with caution once adverb
Use only to mean one time. Do not use as a conjunction to mean after or when.

@anarnold97 anarnold97 force-pushed the rework-MTV-section-in-CNV branch from 96d0e62 to c17899c Compare September 24, 2025 16:59
@anarnold97
Copy link
Contributor Author

Hey Andy, thanks for doing this. It looks great overall but there are a few issues with the links and some nits/suggestions. Please also update the PR description to include which versions this applies to. IMO, it's ready for merge if you fix those issues and squash your commits.

@ousleyp - your changes are all implemented

@anarnold97 anarnold97 closed this Sep 24, 2025
@anarnold97 anarnold97 reopened this Sep 24, 2025
@openshift-ci
Copy link

openshift-ci bot commented Sep 24, 2025

@anarnold97: The label(s) /label MTV cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, run-integration-tests, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, ok-to-test, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, stability-fix-approved, staff-eng-approved, telco. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label MTV

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Comment on lines 17 to 19
* link:https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/{mtv-version}/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index%23creating-a-migration-plan[Creating a migration plan]: A migration plan defines the VMs to be migrated, the source and destination environments, and other migration settings. This plan helps to organize and automate the migration process.
* link:https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/{mtv-version}/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index%23creating-a-network-map#about-network-maps_vmware[Mapping networks] and link:https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/{mtv-version}/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index%23creating-a-network-map#about-storage-maps_vmware[mapping storage]: {mtv-short} helps you to map networks and storage from your source environment (for example, vSphere or RHV) to the {product-title} environment. This ensures that the migrated VMs have the correct network and storage configurations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These three links (Creating a migration plan, Mapping networks, and mapping storage) don't work for me; they all point to the top of the page as if the links were all to https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/2.8/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index

@anarnold97 Do the links work on your end?

Signed-off-by: A.Arnold <anarnold@redhat.com>
@anarnold97 anarnold97 force-pushed the rework-MTV-section-in-CNV branch from 14619ed to 9593c6f Compare September 30, 2025 22:24
@openshift-ci
Copy link

openshift-ci bot commented Sep 30, 2025

@anarnold97: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@anarnold97
Copy link
Contributor Author

Sorry @ousleyp - i can see the problem.

it is the attribute version of MTV, which is set to 2.8

if i update that to 2.9 the links will work

@ousleyp
Copy link
Member

ousleyp commented Oct 1, 2025

Sorry @ousleyp - i can see the problem.

it is the attribute version of MTV, which is set to 2.8

if i update that to 2.9 the links will work

Ah ok! Thanks for checking, @anarnold97. So is this change only for enterprise-4.20+?

@anarnold97
Copy link
Contributor Author

@ousleyp - thanks for checking
MTV sort of independent of OCP... but MTV 2.9.0 came out to coincide with OCP 4.19
And will change to MTV 2.10.0 for OCP 4.20

What do you mean that was too much boring information? 🤣

Copy link
Member

@ousleyp ousleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing with the links - thanks! Since you're changing the attribute to 2.9 and you said that 2.9 was released to coincide with 4.19, it seems like this PR should be cherrypicked to 4.19 and 4.20[*]. Shall I assign those labels? Let me know when you're ready for merge.

[*] and a separate PR should later be opened to update the variable to 2.10 when that goes out - that would be against main and 4.20, I think?

* link:https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/{mtv-version}/html/installing_and_using_the_migration_toolkit_for_virtualization/migrating-ova_ova#adding-source-provider_ova[Migrate virtual machines from OVA files created by {vmw-full}].
* link:https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/{mtv-version}/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index#creating-plan-wizard-290-vmware_vmware[Creating a migration plan]: A migration plan defines the VMs to be migrated, the source and destination environments, and other migration settings. This plan helps to organize and automate the migration process.
* link:https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/{mtv-version}/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index#about-network-maps_vmware[Mapping networks] and link:https://docs.redhat.com/en/documentation/migration_toolkit_for_virtualization/{mtv-version}/html-single/installing_and_using_the_migration_toolkit_for_virtualization/index#about-network-maps_vmware[mapping storage]: {mtv-short} helps you to map networks and storage from your source environment (for example, vSphere or RHV) to the {product-title} environment. This ensures that the migrated VMs have the correct network and storage configurations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links work better now if I copy and paste them and substitute 2.9 for {mtv-version} (though for some reason the preview build hasn't caught on yet). However, the "Mapping networks" and "mapping storage" URLs now both point to 7.8. About network maps in migration plans :)

@anarnold97
Copy link
Contributor Author

@ousleyp - that would be awesome, thanks

@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.21 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.20. And any PR going into main must also target the latest version branch (enterprise-4.21).

If the update in your PR does NOT apply to version 4.21 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.19 branch/enterprise-4.20 branch/enterprise-4.21 CNV Label for all CNV PRs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants