SREP-3941: Add --hive-ocm-url flag to cluster ssh key for multi-env OCM support

[nephomaniac]

Summary

Adds --hive-ocm-url flag to osdctl cluster ssh key command to enable multi-environment OCM support for staging/integration testing.

Changes

• Added --hive-ocm-url optional flag to ssh key command
• Implements conditional logic to use separate OCM connections for target cluster and hive when flag is provided
• Added early validation in RunE function to fail fast on invalid OCM URLs
• Preserves backward compatibility - original code path unchanged when flag not provided
• Supports OCM URL aliases: 'production', 'staging', 'integration'
• Updated unit tests in key_test.go to verify early validation behavior

Implementation Details

When --hive-ocm-url is specified:

1. Creates separate OCM connection for hive using utils.CreateConnectionWithUrl()
2. Uses utils.GetHiveClusterWithConn() to query hive from different OCM environment
3. Creates hive k8s client with k8s.NewAsBackplaneClusterAdminWithConn()
4. Validates OCM URL early using utils.ValidateAndResolveOcmUrl()

Testing

• ✅ Tested in staging environment with valid --hive-ocm-url values

• ✅ Tested in production environment with valid --hive-ocm-url values

• ✅ Validated early failure with invalid --hive-ocm-url values

• ✅ Backward compatibility verified (command works without --hive-ocm-url flag)

• ✅ Unit tests passing (including new tests for validation logic)

• Parent Epic: SREP-3936

• Jira: SREP-3941

Note

This PR is part of a series adding multi-environment OCM support to osdctl commands. Will place on hold until the common implementation pattern can be reviewed across all related PRs.

Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com

[coderabbitai]

Warning

Rate limit exceeded

@nephomaniac has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 0 minutes and 59 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 62eab7a6-76a6-4980-8216-09d4098ff418

📥 Commits

Reviewing files that changed from the base of the PR and between 71e44ff and 5239ecc.

📒 Files selected for processing (4)

• cmd/cluster/ssh/key.go
• cmd/cluster/ssh/key_test.go
• docs/README.md
• docs/osdctl_cluster_ssh_key.md

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[nephomaniac]

Placing on hold until all the similar commands/PRs adding multiple OCM env support can have the common implementation pattern reviewed. Will unhold after the other PRs and general pattern get a chance for review.

/hold

[openshift-ci-robot]

@nephomaniac: An error was encountered searching for bug SREP-3941 on the Jira server at https://issues.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.

No response returned: Get "https://issues.redhat.com/rest/api/2/issue/SREP-3941": GET https://issues.redhat.com/rest/api/2/issue/SREP-3941 giving up after 5 attempt(s)

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

Summary

Adds --hive-ocm-url flag to osdctl cluster ssh key command to enable multi-environment OCM support for staging/integration testing.

Changes

• Added --hive-ocm-url optional flag to ssh key command
• Implements conditional logic to use separate OCM connections for target cluster and hive when flag is provided
• Added early validation in RunE function to fail fast on invalid OCM URLs
• Preserves backward compatibility - original code path unchanged when flag not provided
• Supports OCM URL aliases: 'production', 'staging', 'integration'

Implementation Details

When --hive-ocm-url is specified:

1. Creates separate OCM connection for hive using utils.CreateConnectionWithUrl()
2. Uses utils.GetHiveClusterWithConn() to query hive from different OCM environment
3. Creates hive k8s client with k8s.NewAsBackplaneClusterAdminWithConn()
4. Validates OCM URL early using utils.ValidateAndResolveOcmUrl()

Testing

• ✅ Tested in staging environment with valid --hive-ocm-url values
• ✅ Tested in production environment with valid --hive-ocm-url values
• ✅ Validated early failure with invalid --hive-ocm-url values
• ✅ Backward compatibility verified (command works without --hive-ocm-url flag)

Related

• Parent Epic: SREP-3936
• Jira: SREP-3941

Note

This PR is part of a series adding multi-environment OCM support to osdctl commands. Will place on hold until the common implementation pattern can be reviewed across all related PRs.

Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nephomaniac
Once this PR has been reviewed and has the lgtm label, please assign joshbranham for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@nephomaniac: An error was encountered searching for bug SREP-3941 on the Jira server at https://issues.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.

No response returned: Get "https://issues.redhat.com/rest/api/2/issue/SREP-3941": GET https://issues.redhat.com/rest/api/2/issue/SREP-3941 giving up after 5 attempt(s)

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

Details

In response to this:

Summary

Adds --hive-ocm-url flag to osdctl cluster ssh key command to enable multi-environment OCM support for staging/integration testing.

Changes

• Added --hive-ocm-url optional flag to ssh key command
• Implements conditional logic to use separate OCM connections for target cluster and hive when flag is provided
• Added early validation in RunE function to fail fast on invalid OCM URLs
• Preserves backward compatibility - original code path unchanged when flag not provided
• Supports OCM URL aliases: 'production', 'staging', 'integration'
• Updated unit tests in key_test.go to verify early validation behavior

Implementation Details

When --hive-ocm-url is specified:

1. Creates separate OCM connection for hive using utils.CreateConnectionWithUrl()
2. Uses utils.GetHiveClusterWithConn() to query hive from different OCM environment
3. Creates hive k8s client with k8s.NewAsBackplaneClusterAdminWithConn()
4. Validates OCM URL early using utils.ValidateAndResolveOcmUrl()

Testing

• ✅ Tested in staging environment with valid --hive-ocm-url values

• ✅ Tested in production environment with valid --hive-ocm-url values

• ✅ Validated early failure with invalid --hive-ocm-url values

• ✅ Backward compatibility verified (command works without --hive-ocm-url flag)

• ✅ Unit tests passing (including new tests for validation logic)

• Parent Epic: SREP-3936

• Jira: SREP-3941

Note

This PR is part of a series adding multi-environment OCM support to osdctl commands. Will place on hold until the common implementation pattern can be reviewed across all related PRs.

Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[nephomaniac]

/retest

[openshift-ci]

@nephomaniac: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.