OCPBUGS-86429: Unpin libreswan version for IPsec scaling fix

[anuragthehatter]

Summary

• Unpin libreswan from 4.6-3.el9_0.3 to latest available version in Dockerfile
• This allows RHCOS to pick up libreswan 5.x which fixes a pluto segfault in set_larval_v2_transition() that causes IPsec mesh tunnel failures at 75+ node scale

Background

Large clusters (75+ nodes) with IPsec enabled hit a race condition in libreswan's pluto daemon during concurrent Child SA negotiation. The fix is in libreswan 5.x but OCP 4.18 pins to an older version. This PR removes the pin so the latest packaged version is installed.

Related PRs

• CORENET-5382: unpin libreswan version #2498 (master - already merged)
• OCPBUGS-86429: Unpin libreswan and add 5.x compat for IPsec scaling fix machine-config-operator#6310 (release-4.18 - companion PR)
• OCPBUGS-86429: Skip _stackmanager for libreswan 5.x compat cluster-network-operator#3056 (release-4.18 - companion PR)

Test plan

• Bring up a 75+ node cluster with IPsec enabled
• Verify ipsec --version shows libreswan 5.x on nodes
• Verify all IPsec tunnels establish successfully
• Check no pluto segfaults in journal logs

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Enterprise

Run ID: 491c9445-aad7-4998-9f39-79d57f7fb22d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Note

.coderabbit.yml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key: "paths_ignore"

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anuragthehatter
Once this PR has been reviewed and has the lgtm label, please assign kyrtapz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@anuragthehatter: This pull request references Jira Issue OCPBUGS-86429, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-86429 to depend on a bug targeting a version in 4.19.0, 4.19.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

• Unpin libreswan from 4.6-3.el9_0.3 to latest available version in Dockerfile
• This allows RHCOS to pick up libreswan 5.x which fixes a pluto segfault in set_larval_v2_transition() that causes IPsec mesh tunnel failures at 75+ node scale

Background

Large clusters (75+ nodes) with IPsec enabled hit a race condition in libreswan's pluto daemon during concurrent Child SA negotiation. The fix is in libreswan 5.x but OCP 4.18 pins to an older version. This PR removes the pin so the latest packaged version is installed.

Related PRs

• CORENET-5382: unpin libreswan version #2498 (master - already merged)
• OCPBUGS-86429: Unpin libreswan and add 5.x compat for IPsec scaling fix machine-config-operator#6310 (release-4.18 - companion PR)
• OCPBUGS-86429: Skip _stackmanager for libreswan 5.x compat cluster-network-operator#3056 (release-4.18 - companion PR)

Test plan

• Bring up a 75+ node cluster with IPsec enabled
• Verify ipsec --version shows libreswan 5.x on nodes
• Verify all IPsec tunnels establish successfully
• Check no pluto segfaults in journal logs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[igsilya]

This allows RHCOS to pick up libreswan 5.x which fixes a pluto segfault in set_larval_v2_transition() that causes IPsec mesh tunnel failures at 75+ node scale

AFAIR, this segfault is specific to 5.x and IIRC not present in 4.6. And there is no fix for it yet in 5.x (RHEL-193479).

[anuragthehatter]

/assign @pperiyasamy for review

[openshift-ci]

@anuragthehatter: GitHub didn't allow me to assign the following users: for, review.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

/assign @pperiyasamy for review

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-merge-bot]

Scheduling required tests:
/test 4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade
/test 4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade
/test e2e-aws-ovn
/test e2e-aws-ovn-edge-zones
/test e2e-aws-ovn-fdp-qe
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-local-gateway
/test e2e-aws-ovn-local-to-shared-gateway-mode-migration
/test e2e-aws-ovn-serial
/test e2e-aws-ovn-shared-to-local-gateway-mode-migration
/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-upgrade-local-gateway
/test e2e-aws-ovn-windows
/test e2e-azure-ovn-upgrade
/test e2e-gcp-ovn
/test e2e-gcp-ovn-techpreview
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6
/test qe-perfscale-payload-control-plane-6nodes

[openshift-ci]

@anuragthehatter: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	7bb4067	link	false	/test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.