OCPBUGS-80930 | Add VolumeAttributesClass e2e test for Azure Disk CSI driver with UltraSSD support#77008
OCPBUGS-80930 | Add VolumeAttributesClass e2e test for Azure Disk CSI driver with UltraSSD support#77008radeore wants to merge 1 commit intoopenshift:mainfrom
Conversation
… driver with UltraSSD support
|
[REHEARSALNOTIFIER]
A total of 141 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@radeore: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Are we creating new pre-submit rather than updating existing pre-submit because existing pre-submit doesn't support this type SSD? |
@gnufied Yes, created a new job because VAC feature is currently supported only on UltraSSD or Premium_v2 type of disks for azure-disk-csi-driver. |
|
But if this is a blocking pre-submit then, it will run anyways for all azure jobs and hence both jobs will run anyways? oh, sorry I see this is a optional, but still this runs all the time right? I am just thinking if this should be a periodic or optiona pre-submit. |
Yes it is currently 'optional', and it will only execute when '/test e2e-azure-csi-volumeattributesclasbut' is manually triggered. But may be a 'periodic' run would be a better option. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnufied, radeore The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
3 participants
Summary
e2e-azure-csi-volumeattributesclassoptional presubmit test for Azure Disk CSI driver (csi-operator main and release-4.22)openshift-e2e-azure-csi-ultrassdworkflow that provisions Azure clusters withultraSSDCapability: Enabledand anUltraSSD_LRSdefault StorageClass, required for VolumeAttributesClass supportstorage-conf-storageclass-pre-set-default-azure-disk-ultrassdstep to configure the UltraSSD StorageClass manifest before cluster installstorage-conf-csi-azure-diskstep to support copyingvolumeattributesclass.yamlmanifest (viaTEST_VOLUME_ATTRIBUTES_CLASS_MANIFESTenv var), matching existing GCP PD and AWS EBS patternsVolumeAttributesClass on Azure Disk is only supported with
UltraSSD_LRSorPremiumV2_LRSdisk types.Note: This change also requires a corresponding
test/e2e/azure-disk/volumeattributesclass.yamlmanifest in theopenshift/csi-operatorrepo for the tests to run, opened PR openshift/csi-operator#538 for the same.