SPLAT-2668: remove CCM test skips from Hypershift TP jobs#79439
Conversation
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
@mtulio: This pull request references SPLAT-2668 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
/test all |
WalkthroughAdds two AWS OVN conformance CCM e2e jobs (regular and techpreview) to hypershift CI and periodics, clears/condenses TEST_SKIPS for those jobs across 4.23 and 5.0 configs, and schedules the techpreview periodic as daily for 5.0. ChangesHypershift CI jobs and periodics
Sequence Diagram(s)sequenceDiagram
participant Developer
participant CI-Operator
participant ci_config_main as "openshift-hypershift-main.yaml"
participant periodics_5_0 as "openshift-hypershift-release-5.0__periodics.yaml"
participant periodics_4_23 as "openshift-hypershift-release-4.23__periodics.yaml"
Developer->>CI-Operator: add/modify job definitions and periodics
CI-Operator->>ci_config_main: insert new e2e-aws-ovn-conformance-ccm jobs (PUBLIC_ONLY, TEST_SKIPS, GUEST_FEATURE_SET)
CI-Operator->>periodics_5_0: register `@monthly` and `@daily` periodics for new jobs
CI-Operator->>periodics_4_23: update schedules and clear TEST_SKIPS
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/ph-rehearse periodic-ci-openshift-hypershift-release-5.0-e2e-aws-ovn-conformance-ccm-techpreview |
1 similar comment
|
/ph-rehearse periodic-ci-openshift-hypershift-release-5.0-e2e-aws-ovn-conformance-ccm-techpreview |
|
Another manual since yesterday failed due outdated image: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-hypershift-release-5.0-e2e-aws-ovn-conformance-ccm-techpreview/2056746936064544768 |
mtulio
force-pushed
the
SPLAT-2668-validate-OCPBUGS-85414
branch
from
b879e72 to
501cf43
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics.yaml`:
- Around line 159-177: The periodic job entries for "as:
e2e-aws-ovn-conformance-ccm" and "as: e2e-aws-ovn-conformance-ccm-techpreview"
are missing the required mirrored sections from the main config; copy the full
set of variant sections (base_images, build_root, images, promotion, and
releases) from the main config into each of these periodic job blocks so their
structure matches the main config exactly, ensuring you place the copied
build_root, images, promotion, base_images and releases under the same
steps/job-level scope as the other fields for those two jobs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 4c60cda5-c9dd-46a2-a881-d997f083c3b3
⛔ Files ignored due to path filters (2)
ci-operator/jobs/openshift/hypershift/openshift-hypershift-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-5.0-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (3)
ci-operator/config/openshift/hypershift/openshift-hypershift-main.yamlci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0.yamlci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics.yaml
💤 Files with no reviewable changes (1)
- ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0.yaml
mtulio
force-pushed
the
SPLAT-2668-validate-OCPBUGS-85414
branch
from
501cf43 to
1ad913a
Compare
openshift-ci
Bot
added
the
needs-rebase
|
@mtulio, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
mtulio
force-pushed
the
SPLAT-2668-validate-OCPBUGS-85414
branch
from
1ad913a to
64535e9
Compare
|
/test all |
openshift-ci
Bot
removed
the
needs-rebase
There was a problem hiding this comment.
♻️ Duplicate comments (1)
ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics.yaml (1)
159-175: 🛠️ Refactor suggestion | 🟠 MajorPeriodic variant is missing required mirrored sections from main config.
This
__periodics.yamlfile still lacksbuild_root,images, andpromotionsections at the file level. While this is a pre-existing structural issue (not introduced by the current PR), it should be addressed to comply with variant file structure requirements.As per coding guidelines: "Variant periodic configuration files should include
base_images,build_root,images,promotion, andreleasessections copied from main config, then add onlytests:entries withinterval:orcron:scheduling"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics.yaml` around lines 159 - 175, This periodic variant is missing required top-level sections copied from the main config; add the base_images, build_root, images, promotion, and releases sections from the main config into this variant file and keep only tests entries (like the existing e2e-aws-ovn-conformance-ccm and e2e-aws-ovn-conformance-ccm-techpreview blocks) with their cron/interval scheduling; ensure the inserted sections match the main config exactly (including any base_images keys and build_root settings) so the variant structure follows the guideline that only tests are varied while build/images/promotion/releases remain identical.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In
`@ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics.yaml`:
- Around line 159-175: This periodic variant is missing required top-level
sections copied from the main config; add the base_images, build_root, images,
promotion, and releases sections from the main config into this variant file and
keep only tests entries (like the existing e2e-aws-ovn-conformance-ccm and
e2e-aws-ovn-conformance-ccm-techpreview blocks) with their cron/interval
scheduling; ensure the inserted sections match the main config exactly
(including any base_images keys and build_root settings) so the variant
structure follows the guideline that only tests are varied while
build/images/promotion/releases remain identical.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 3c47be1d-c435-4d22-a084-1aa181d0879d
⛔ Files ignored due to path filters (3)
ci-operator/jobs/openshift/hypershift/openshift-hypershift-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.23-periodics.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-5.0-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (4)
ci-operator/config/openshift/hypershift/openshift-hypershift-main.yamlci-operator/config/openshift/hypershift/openshift-hypershift-release-4.23__periodics.yamlci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0.yamlci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics.yaml
💤 Files with no reviewable changes (1)
- ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0.yaml
mtulio
changed the title
mtulio
force-pushed
the
SPLAT-2668-validate-OCPBUGS-85414
branch
from
64535e9 to
39202cd
Compare
|
Just rebase it, since openshift/cluster-cloud-controller-manager-operator#464 is merged, we are green to go rehearsing jobs whe the merge is available in the pipeline: /pj-rehearse periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-aws-ovn-conformance-ccm-techpreview |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
rehearsal job may not include the CCCMO pr yet, I will try again later tomorrow. for now testing job config readiness /test all |
|
interim update, 4.23.0-0.ci-2026-06-04-111742 is cooking with expected changes: cluster-cloud-controller-manager-operator Observing it to finish before triggering a new job
|
|
Release is in Ready phase, let's see if rehearsal can pick this one: /pj-rehearse periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-aws-ovn-conformance-ccm-techpreview |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
The job caught the last Accepted, which does not include the fix yet :( |
trying again: /pj-rehearse periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-aws-ovn-conformance-ccm-techpreview |
|
It looks the group of storage tests failing, re-testing: /pj-rehearse periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn-conformance-techpreview |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Now I am getting issues in the test |
Review periodic jobs added on Hypershift to validate the feature AWSServiceLBNetworkSecurityGroup which impacts CCM. The main goal is to provider readiness to promote the feature on Hypershift, as it is already on GA on self-managed since 4.22. This change also remove the skips related to that feature which was previously failing on Hypershift jobs. Summary of jobs: - e2e-aws-ovn-conformance-ccm: is used to cross-test (payload-job) on CCCMO project to remove remaining test skips (overriding workflow) - e2e-aws-ovn-conformance-techpreview: enforces the TPNU env var to get environment installed in this feature set (does not exists currently) Adding 5.0 jobs, previously added only 4.23. As well removed 4.23 as we don't need to keep monitoring that as GA is planned to 5.0.
mtulio
force-pushed
the
SPLAT-2668-validate-OCPBUGS-85414
branch
from
e1d8cc2 to
7aa45eb
Compare
Added this job as well to the skip list to the job we want to run daily, also left a comment in the https://redhat.atlassian.net/browse/OCPBUGS-87252: /pj-rehearse periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn-conformance-techpreview |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/test all |
|
[REHEARSALNOTIFIER]
A total of 222 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
mtulio
changed the title
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
Good results skipping remaining perm failure CSI on TechPreviewNoUpgrade job. I will propose this as a final while I am tracking the https://redhat.atlassian.net/browse/OCPBUGS-87252 Note: it is expected that CCM job will fail as it have two remaining test failures (TEST_SKIPS="") that must be used when fixing upstream issues. /pj-rehearse auto-ack |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
We don't expect those jobs to fail: |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@mtulio: job(s): pull-ci-openshift-hypershift-main-e2e-aws-ovn-conformance either don't exist or were not found to be affected, and cannot be rehearsed |
|
Done check list updated (PR description):
/pj-rehearse ack |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre, mtulio The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@mtulio: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
Bot
merged commit 66e6e78
into
openshift:main
3 participants
Summary
Update Hypershift CI conformance jobs for the
AWSServiceLBNetworkSecurityGroupCCM feature (refs SPLAT-2668 / OCPBUGS-85414).
This feature is GA on self-managed since 4.22 and is being promoted to Hypershift
for 5.0. With CCCMO PR openshift/cluster-cloud-controller-manager-operator#464
now merged, we can remove the related test skips and add proper CI coverage.
Changes
Workflow defaults (
hypershift-aws-conformance-workflow.yaml): Removetest skips for
AWSServiceLBNetworkSecurityGroupandcloud-provider-aws-e2e-openshifttests. Remaining skips are anchored to tracked issues (OCPBUGS-74537, OCPBUGS-87252).
5.0 periodics (new): Add
e2e-aws-ovn-conformance-ccm(@monthly)and
e2e-aws-ovn-conformance-techpreview(@daily) to validate CCMconformance on the 5.0 release branch.
4.23 periodics (removed): Drop CCM periodic jobs from 4.23 since GA
is planned for 5.0 — no need to keep monitoring on that branch.
Main presubmits (new): Add optional
e2e-aws-ovn-conformance-ccmande2e-aws-ovn-conformance-techpreviewjobs for on-demand rehearsal.Job purposes
e2e-aws-ovn-conformance-ccme2e-aws-ovn-conformance-techpreviewGUEST_FEATURE_SET=TechPreviewNoUpgradeto exercise the feature in TP modeValidation
5.0(which includes CCCMO OCPBUGS-86303: e2e/ote-ccm-aws: enhance tests to run hybrid in hypershift HC cluster-cloud-controller-manager-operator#464) passing allAWSServiceLBNetworkSecurityGrouptestsDone check list:
e2e-aws-ovn-conformance-techpreviewjob are passing: periodic(ok) presubmit(ok, w/ CSI transient - unrelated)e2e-aws-ovn-conformance-ccmare failing only expected testscloud-provider-aws-e2e: periodic(ok), presubmit(ok)AWSServiceLBNetworkSecurityGroupare passing on all new jobs and default conformance (reminder: it's enabled only in TechPreviewNoUpgrade): e2e-aws-ovn-conformance-techpreview, e2e-aws-ovn-conformance-techpreviewcloud-provider-aws-e2etests passing on default conformance jobs: main-e2e-hypershift-conformance, main-e2e-aws-ovn-conformance-ccm(two failures as expected/TEST_SKIPS="")cloud-provider-aws-e2etests removed from runtime: 5.0-periodics-e2e-aws-ovn-conformance-techpreview #2064464291783774208 , main-e2e-hypershift-conformance #2064413102144753664, main-e2e-aws-ovn-conformance-techpreview #2064464291729248256Dependencies