Don't skip storage tests on hypershift

[jsafrane]

• VolumeGroupSnapshots have been fixed in OCPBUGS-87252: Fix group snapshots on HyperShift cluster-csi-snapshot-controller-operator#278
• NFS should "just work"

Summary by CodeRabbit

This PR removes previously necessary test skips from HyperShift's periodic conformance job configuration, enabling storage-related tests that were previously failing but have now been fixed.

What changed:
The e2e-aws-conformance-cilium periodic job in the HyperShift 5.0 release configuration had its TEST_SKIPS environment variable cleaned up. A large multi-line list of skipped tests—including tests for VolumeGroupSnapshots, NFS volumes, NetworkPolicy, and various networking features—was removed entirely.

Why:
According to the PR description, VolumeGroupSnapshot functionality has been fixed upstream in the cluster CSI snapshot controller operator. NFS tests should now pass without requiring explicit skips. This allows these storage and networking conformance tests to run again as part of the regular test suite on HyperShift clusters.

Impact:
HyperShift's AWS periodic conformance tests will now exercise storage features (volume snapshots, NFS) and additional networking scenarios that were previously being skipped. This increases test coverage and validates that the fixes to the snapshot controller have resolved the issues that necessitated the skips in the first place.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 008d6991-338a-470f-8006-d60ee86b459c

📥 Commits

Reviewing files that changed from the base of the PR and between 5497561 and 3ecd399.

📒 Files selected for processing (1)

• ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics.yaml

---

Walkthrough

The periodic job configuration for e2e-aws-ovn-conformance-techpreview was updated to simplify the TEST_SKIPS list by removing an obsolete VolumeGroupSnapshot-related skip entry while retaining the NLB internal hairpinning condition.

Changes

Periodic Job Test Skip Update

Layer / File(s)	Summary
TEST_SKIPS configuration update ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics.yaml	The TEST_SKIPS entry in the e2e-aws-ovn-conformance-techpreview job was simplified to remove the prior VolumeGroupSnapshot-related skip content, leaving only the NLB internal hairpinning/target-node-labels condition.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: removing storage test skips from the hypershift periodic job configuration.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies only CI configuration (TEST_SKIPS in YAML), not Ginkgo test code. Custom check for stable test names is inapplicable since no test declarations with It()/Describe()/etc. were modified.
Test Structure And Quality	✅ Passed	PR modifies CI configuration YAML only, not Ginkgo test code. The custom check for test structure and quality is not applicable to CI configuration changes.
Microshift Test Compatibility	✅ Passed	This PR modifies CI configuration (YAML), not adding new Ginkgo e2e tests. It reduces TEST_SKIPS for existing tests in the e2e-aws-ovn-conformance-techpreview job; therefore the MicroShift test che...
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added in this PR. The change only modifies a CI configuration file to reduce the TEST_SKIPS list for an existing periodic job. The custom check does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only a CI test job configuration file to remove test skips. Does not add or modify deployment manifests, operator code, controllers, or scheduling constraints, so the topology-aware sch...
Ote Binary Stdout Contract	✅ Passed	PR only modifies CI configuration YAML file; no test code or binary code changes that could violate OTE stdout contract.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR does not add new Ginkgo e2e tests; it only modifies CI configuration to enable existing storage tests by reducing the TEST_SKIPS list. Custom check only applies to new test code additions.
No-Weak-Crypto	✅ Passed	PR modifies test job configs and CI scripts with no cryptographic operations; no weak crypto algorithms, custom crypto, or insecure secret comparisons detected.
Container-Privileges	✅ Passed	PR modifies CI operator config for test jobs, not container/K8s manifests. No privileged containers or privilege escalation configurations present in modified files.
No-Sensitive-Data-In-Logs	✅ Passed	The PR modifies TEST_SKIPS environment variable in a YAML config file, removing test pattern strings and not introducing any logging of passwords, tokens, API keys, PII, session IDs, internal hostn...

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[jsafrane]

/pj-rehearse

[openshift-merge-bot]

@jsafrane: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

[openshift-merge-bot]

@jsafrane: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@jsafrane: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[mtulio]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane, mtulio
Once this PR has been reviewed and has the lgtm label, please assign cblecker for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/hypershift/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mtulio]

/assign @enxebre