Skip to content

ROSAENG-8194 | task: Migrate cs-rosa-hcp-ad-production-main#80434

Open
davidleerh wants to merge 1 commit into
openshift:mainfrom
davidleerh:ROSAENG-8194-NEW
Open

ROSAENG-8194 | task: Migrate cs-rosa-hcp-ad-production-main#80434
davidleerh wants to merge 1 commit into
openshift:mainfrom
davidleerh:ROSAENG-8194-NEW

Conversation

@davidleerh

@davidleerh davidleerh commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

This PR adds a new CI configuration for the ROSA HCP (Hosted Control Planes) production environment test suite. The change creates openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-production.yaml, a ci-operator configuration that defines how the production-level HCP validation tests are executed in the OpenShift CI/CD infrastructure.

What's being added:

The configuration establishes a dedicated periodic test job (ocm-fvt-periodic-cs-rosa-hcp-ad-production-main) that:

  • Runs daily at 3 AM UTC (cron: 0 3 * * *)
  • Executes the rosa-e2e-ocm-fvt test reference using nested podman capability
  • Targets the production OCM environment with the job name cs-rosa-hcp-ad-production-main
  • Has a 5-hour timeout window to complete

Infrastructure setup:

The config also specifies the build and runtime environment:

  • Uses OpenShift 4.22 nightly release stream
  • Builder image: rhel-9-golang-1.24-openshift-4.22
  • Resource constraints: 100m CPU and 200Mi memory requests, with 4Gi memory limit
  • Nested podman base image for test isolation

This migration consolidates production ROSA HCP test execution within the release repository's CI configuration system, enabling automated daily validation of HCP production deployments.

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 68ca8fcf-1982-4780-9c39-73c02a335ea8

📥 Commits

Reviewing files that changed from the base of the PR and between 036c670 and fda2700.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-production.yaml

Walkthrough

A new ROSA E2E CI configuration YAML file is added to define build root, image streams, release targeting (OCP nightly 4.22), resource constraints, and a daily cron-scheduled test job for OCM FVT ROSA HCP production testing with environment variables and metadata.

Changes

ROSA HCP Production E2E CI Configuration

Layer / File(s) Summary
ROSA HCP Production CI Configuration
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-production.yaml
Adds complete CI operator configuration with builder image stream (ocp/builder:rhel-9-golang-1.24-openshift-4.22), nested-podman base image, OCP nightly release tracking (version 4.22), default resource requests and 4Gi memory limits, and a cron-scheduled periodic test job (ocm-fvt-periodic-cs-rosa-hcp-ad-production-main) running daily at 03:00 UTC with OCM environment variables, test references, and 5-hour timeout.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 13 | ❌ 2

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Stable And Deterministic Test Names ❓ Inconclusive Custom check execution failed before a final verdict was produced. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Test Structure And Quality ❓ Inconclusive Custom check execution failed before a final verdict was produced. Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
✅ Passed checks (13 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: migration of a production ROSA HCP configuration for OpenShift CI/CD pipelines.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Microshift Test Compatibility ✅ Passed PR 80434 only adds/updates ci-operator YAML job configuration; diff shows no Go/Ginkgo (no It/Describe/Context) and only YAML files were changed.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR adds only a CI configuration YAML file with no new Ginkgo e2e test code (no It(), Describe(), Context(), etc.). The check applies only to new test code, not CI config files.
Topology-Aware Scheduling Compatibility ✅ Passed PR only adds a new ci-operator config + periodic prow job; the YAML contains resources/env/cron and no affinity, topologySpreadConstraints, nodeSelector, or control-plane targeting constraints.
Ote Binary Stdout Contract ✅ Passed PR #80434 only adds/updates ci-operator YAML configs (2 files); no OTE/Go binaries were modified, so no main/init/TestMain stdout contract can be violated.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only adds/updates ROSA E2E YAML configs (no new Ginkgo/Go e2e tests). Scanned changed YAML for IPv4 literals and public/external hosts/URLs; none found.
No-Weak-Crypto ✅ Passed Scanned the new ROSA E2E YAML config and found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or crypto keywords, and no '==/!=' comparisons involving tokens/secrets.
Container-Privileges ✅ Passed No matches for privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation/securityContext/runAsUser in the PR’s added YAML files; only nested-podman capability is set.
No-Sensitive-Data-In-Logs ✅ Passed The PR adds a CI configuration file with no sensitive data: only public image references, standard resource limits, non-sensitive job identifiers, and scheduling parameters.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from dustman9000 and tiwillia June 11, 2026 18:16
@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidleerh
Once this PR has been reviewed and has the lgtm label, please assign ravitri for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@davidleerh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-production-ocm-fvt-periodic-cs-rosa-hcp-ad-production-main N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@davidleerh

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-production-ocm-fvt-periodic-cs-rosa-hcp-ad-production-main

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@davidleerh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@davidleerh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-production-ocm-fvt-periodic-cs-rosa-hcp-ad-production-main fda2700 link unknown /pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-production-ocm-fvt-periodic-cs-rosa-hcp-ad-production-main

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant