INTEROP-9141: Onboard stolostron/console-e2e image for OPP interop#80436
INTEROP-9141: Onboard stolostron/console-e2e image for OPP interop#80436amp-rh wants to merge 4 commits into
Conversation
|
@amp-rh: This pull request references INTEROP-9141 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis pull request adds two CI configuration files for stolostron/console-e2e: an OWNERS file declaring approvers/reviewers and a ci-operator YAML that defines the image build, promotion target, prowgen exposure, resource defaults, and generated metadata for the main branch. Changesstolostron console-e2e CI Setup
🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/config/stolostron/console-e2e/stolostron-console-e2e-main.yaml`:
- Around line 1-25: The prowgen stanza in the stolostron-console-e2e-main config
(the prowgen: expose/private block in the provided YAML) indicates generated
Prow jobs are missing; run make update to generate the downstream job YAMLs for
stolostron-console-e2e-main and add the resulting job files to the repository
under the ci-operator jobs for stolostron console-e2e so the generated job
manifests (stolostron-console-e2e-main-*.yaml) are committed alongside the
config.
- Around line 1-5: The build_root.image_stream_tag.tag currently pins
rhel-8-release-golang-1.17-openshift-4.11; either update that tag to a supported
newer stream (e.g., rhel-9-release-golang-1.19-openshift-4.15 or
rhel-9-release-golang-1.25-openshift-4.21) to align with other repo configs, or
add an explicit justification comment in the same config explaining why Go
1.17/OCP 4.11 must be retained (security/compatibility/testing constraints),
ensuring the change targets the build_root.image_stream_tag.tag entry so
reviewers can verify the rationale or the new tag.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: d296904a-62ba-430d-85ea-927c96683716
📒 Files selected for processing (2)
ci-operator/config/stolostron/console-e2e/OWNERSci-operator/config/stolostron/console-e2e/stolostron-console-e2e-main.yaml
713cbfd to
daf7844
Compare
|
New changes are detected. LGTM label has been removed. |
daf7844 to
d113953
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amp-rh, smithbw88 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse pull-ci-stolostron-console-e2e-main-images |
|
@amp-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Run `make jobs` to generate presubmit and postsubmit YAML from the ci-operator config added in the previous commit.
Remove almen-ng and atifshafi (not openshift org members). Add cspi-qe-ocp-lp team alias matching other interop test configs. Retain dtthuynh as product-side owner.
The ci/prow/owners check requires OWNERS files in both config and jobs directories. Copies the same OWNERS from ci-operator/config/.
d113953 to
cebaef2
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@amp-rh: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Onboards stolostron/console-e2e into OpenShift CI. This adds a ci-operator
config that builds the Dockerfile.interop from the repo and promotes the
resulting image to acm-qe/main with the tag console-e2e.
This is part of INTEROP-9141
— migrating OPP ALC tests from Cypress to Playwright.
Pattern
Follows the existing stolostron/application-ui-test onboarding pattern.
The main branch config promotes to acm-qe/main. Release-branch configs
(e.g. release-2.17 promoting to acm-qe/2.17) should be added when
the repo creates release branches.
Depends on
Generated using Chai Bot (OpenShift AI Helpdesk)
Summary by CodeRabbit
This PR onboards the stolostron/console-e2e repository into OpenShift CI to build and promote a console-e2e image as part of INTEROP-9141 (migrating OPP ALC tests to Playwright).
Practical changes:
Notes: