Skip to content

INTEROP-9141: Onboard stolostron/console-e2e image for OPP interop#80436

Open
amp-rh wants to merge 4 commits into
openshift:mainfrom
amp-rh:console-e2e-onboarding
Open

INTEROP-9141: Onboard stolostron/console-e2e image for OPP interop#80436
amp-rh wants to merge 4 commits into
openshift:mainfrom
amp-rh:console-e2e-onboarding

Conversation

@amp-rh

@amp-rh amp-rh commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Onboards stolostron/console-e2e into OpenShift CI. This adds a ci-operator
config that builds the Dockerfile.interop from the repo and promotes the
resulting image to acm-qe/main with the tag console-e2e.

This is part of INTEROP-9141
— migrating OPP ALC tests from Cypress to Playwright.

Pattern

Follows the existing stolostron/application-ui-test onboarding pattern.
The main branch config promotes to acm-qe/main. Release-branch configs
(e.g. release-2.17 promoting to acm-qe/2.17) should be added when
the repo creates release branches.

Depends on

  • stolostron/console-e2e PR adding Dockerfile.interop

Generated using Chai Bot (OpenShift AI Helpdesk)

Summary by CodeRabbit

This PR onboards the stolostron/console-e2e repository into OpenShift CI to build and promote a console-e2e image as part of INTEROP-9141 (migrating OPP ALC tests to Playwright).

Practical changes:

  • Adds ci-operator config (stolostron-console-e2e-main.yaml) that builds from Dockerfile.interop in the stolostron/console-e2e repo, producing an image named console-e2e. The build uses the openshift/release image_stream_tag rhel-8-release-golang-1.17-openshift-4.11 as the build root.
  • Promotes the built image to the acm-qe/main image stream with tag console-e2e.
  • Exposes the job to prowgen while marking it private and sets default resource requests (100m CPU, 200Mi memory) for all resources.
  • Adds OWNERS file setting approvers and reviewers to the cspi-qe-ocp-lp team and user dtthuynh.

Notes:

  • Follows the existing stolostron/application-ui-test onboarding pattern; release-branch promotion configs (e.g., acm-qe/2.17) should be added when console-e2e creates release branches.
  • This onboarding depends on stolostron/console-e2e adding Dockerfile.interop.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 11, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@amp-rh: This pull request references INTEROP-9141 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Onboards stolostron/console-e2e into OpenShift CI. This adds a ci-operator
config that builds the Dockerfile.interop from the repo and promotes the
resulting image to acm-qe/main with the tag console-e2e.

This is part of INTEROP-9141
— migrating OPP ALC tests from Cypress to Playwright.

Pattern

Follows the existing stolostron/application-ui-test onboarding pattern.
The main branch config promotes to acm-qe/main. Release-branch configs
(e.g. release-2.17 promoting to acm-qe/2.17) should be added when
the repo creates release branches.

Depends on

  • stolostron/console-e2e PR adding Dockerfile.interop

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@amp-rh amp-rh marked this pull request as draft June 11, 2026 18:33
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 618e8f55-592b-429b-955f-a8a9e4ed2d33

📥 Commits

Reviewing files that changed from the base of the PR and between d113953 and cebaef2.

⛔ Files ignored due to path filters (3)
  • ci-operator/jobs/stolostron/console-e2e/OWNERS is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/stolostron/console-e2e/stolostron-console-e2e-main-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/stolostron/console-e2e/stolostron-console-e2e-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/stolostron/console-e2e/OWNERS
  • ci-operator/config/stolostron/console-e2e/stolostron-console-e2e-main.yaml
✅ Files skipped from review due to trivial changes (1)
  • ci-operator/config/stolostron/console-e2e/OWNERS
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/stolostron/console-e2e/stolostron-console-e2e-main.yaml

Walkthrough

This pull request adds two CI configuration files for stolostron/console-e2e: an OWNERS file declaring approvers/reviewers and a ci-operator YAML that defines the image build, promotion target, prowgen exposure, resource defaults, and generated metadata for the main branch.

Changes

stolostron console-e2e CI Setup

Layer / File(s) Summary
OWNERS access control
ci-operator/config/stolostron/console-e2e/OWNERS
OWNERS now lists approvers and reviewers as cspi-qe-ocp-lp, dtthuynh and sets options to {}.
Build pipeline configuration
ci-operator/config/stolostron/console-e2e/stolostron-console-e2e-main.yaml
Adds ci-operator build config with build_root image_stream_tag (openshift/release:rhel-8-release-golang-1.17-openshift-4.11), an image built from Dockerfile.interop producing console-e2e, promotion to acm-qe main, prowgen exposure marked private, default resource requests, and zz_generated_metadata for main/stolostron/console-e2e.

🎯 3 (Moderate) | ⏱️ ~20 minutes

suggested labels: lgtm, rehearsals-ack

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: onboarding a new stolostron/console-e2e image for OPP interop testing, which aligns perfectly with the PR's core objective of adding CI configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR changes only ci-operator OWNERS and stolostron-console-e2e-main.yaml; no Ginkgo test titles (It/Describe/Context/When) or dynamic name patterns were found in changed content.
Test Structure And Quality ✅ Passed PR #80436 only changes ci-operator OWNERS and YAML config; it contains no Ginkgo test code (*_test.go/onsi/ginkgo imports), so the test-structure/quality requirements are not applicable.
Microshift Test Compatibility ✅ Passed PR only adds ci-operator OWNERS/YAML build & prowgen configs; no new Ginkgo e2e tests or Go *_test.go code, so MicroShift API compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR changes only ci-operator OWNERS and stolostron-console-e2e-main.yaml; no new/modified Ginkgo e2e test code (It/Describe/Context/etc.) to assess for SNO assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed Inspected changed files (OWNERS + stolostron-console-e2e-main.yaml): only image build/promotion and ownership settings; no pod scheduling constraints (no affinity/anti-affinity, topology spread, no...
Ote Binary Stdout Contract ✅ Passed PR #80436 only adds ci-operator OWNERS and YAML configs (OWNERS + stolostron-console-e2e-main.yaml + job YAMLs); no OTE/Go main or suite stdout code modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR #80436 only adds ci-operator config/OWNERS and generated job YAMLs (no new Ginkgo e2e *_test.go code), so no IPv6/disconnected network test assumptions to flag.
No-Weak-Crypto ✅ Passed PR contains only configuration files (OWNERS and ci-operator YAML) with no executable code or cryptographic implementations; no weak crypto patterns detected.
Container-Privileges ✅ Passed Checked the PR’s added/updated files (OWNERS, stolostron-console-e2e-main.yaml) for privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation/runAsUser:0—none found.
No-Sensitive-Data-In-Logs ✅ Passed Inspected PR-added/updated OWNERS and stolostron-console-e2e-main.yaml; no passwords/tokens/api keys/PII or sensitive values found—only user names and build/promotion settings.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 11, 2026
@openshift-ci openshift-ci Bot requested review from mark-nc and smithbw88 June 11, 2026 18:34
@openshift-ci openshift-ci Bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jun 11, 2026
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 11, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ci-operator/config/stolostron/console-e2e/stolostron-console-e2e-main.yaml`:
- Around line 1-25: The prowgen stanza in the stolostron-console-e2e-main config
(the prowgen: expose/private block in the provided YAML) indicates generated
Prow jobs are missing; run make update to generate the downstream job YAMLs for
stolostron-console-e2e-main and add the resulting job files to the repository
under the ci-operator jobs for stolostron console-e2e so the generated job
manifests (stolostron-console-e2e-main-*.yaml) are committed alongside the
config.
- Around line 1-5: The build_root.image_stream_tag.tag currently pins
rhel-8-release-golang-1.17-openshift-4.11; either update that tag to a supported
newer stream (e.g., rhel-9-release-golang-1.19-openshift-4.15 or
rhel-9-release-golang-1.25-openshift-4.21) to align with other repo configs, or
add an explicit justification comment in the same config explaining why Go
1.17/OCP 4.11 must be retained (security/compatibility/testing constraints),
ensuring the change targets the build_root.image_stream_tag.tag entry so
reviewers can verify the rationale or the new tag.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d296904a-62ba-430d-85ea-927c96683716

📥 Commits

Reviewing files that changed from the base of the PR and between 5f3ec6a and cefe265.

📒 Files selected for processing (2)
  • ci-operator/config/stolostron/console-e2e/OWNERS
  • ci-operator/config/stolostron/console-e2e/stolostron-console-e2e-main.yaml

@openshift-merge-bot openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 12, 2026
@openshift-ci openshift-ci Bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jun 12, 2026

@smithbw88 smithbw88 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2026
@amp-rh amp-rh force-pushed the console-e2e-onboarding branch from 713cbfd to daf7844 Compare June 12, 2026 13:30
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2026
@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@amp-rh amp-rh force-pushed the console-e2e-onboarding branch from daf7844 to d113953 Compare June 12, 2026 13:30
@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amp-rh, smithbw88

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2026
@amp-rh amp-rh marked this pull request as ready for review June 12, 2026 13:43
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2026
@openshift-ci openshift-ci Bot requested a review from gurnben June 12, 2026 13:44
@amp-rh

amp-rh commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-stolostron-console-e2e-main-images

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@amp-rh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

amp-rh added 4 commits June 12, 2026 09:28
Run `make jobs` to generate presubmit and postsubmit YAML from the
ci-operator config added in the previous commit.
Remove almen-ng and atifshafi (not openshift org members).
Add cspi-qe-ocp-lp team alias matching other interop test configs.
Retain dtthuynh as product-side owner.
The ci/prow/owners check requires OWNERS files in both config and jobs
directories. Copies the same OWNERS from ci-operator/config/.
@amp-rh amp-rh force-pushed the console-e2e-onboarding branch from d113953 to cebaef2 Compare June 12, 2026 14:30
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@amp-rh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stolostron-console-e2e-main-images stolostron/console-e2e presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@amp-rh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/stolostron/console-e2e/main/images d113953 link unknown /pj-rehearse pull-ci-stolostron-console-e2e-main-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants