Skip to content

upgrade clusterpools for Obs ACM 5.0, 2.17, 2.16, 2.15, 2.14#80444

Open
subbarao-meduri wants to merge 1 commit into
openshift:mainfrom
subbarao-meduri:upgrade-clusterpools-422
Open

upgrade clusterpools for Obs ACM 5.0, 2.17, 2.16, 2.15, 2.14#80444
subbarao-meduri wants to merge 1 commit into
openshift:mainfrom
subbarao-meduri:upgrade-clusterpools-422

Conversation

@subbarao-meduri

@subbarao-meduri subbarao-meduri commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

ACM 5.0, ACM 2.17 to use OCP 4.22 pools (now GA) builds
ACM 2.16, ACM 2.15 will use OCP 4.22 pools as well (N+2 release support)
ACM 2.14 will use OCP 4.21 pools (N+2 release support)

Summary by CodeRabbit

This PR updates the OCP version requirements for clusterpool-based CI testing across multiple ACM releases in the stolostron/multicluster-observability-operator repository.

Changes made:

  • ACM 2.14: Updated clusterpool filters from OCP 4.17 to OCP 4.21 (moving to N+2 supported version)
  • ACM 2.15 & 2.16: Updated clusterpool filters from OCP 4.21 to OCP 4.22 (N+2 release support)
  • ACM 2.17 & 5.0: Updated clusterpool filters from OCP 4.21 to OCP 4.22 (using now-GA OCP 4.22 builds)

Each update modifies the CLUSTERPOOL_HUB_FILTER and CLUSTERPOOL_MANAGED_FILTER environment variables in the respective release configuration files, which control which cluster pools are selected for E2E testing workflows in the CI pipeline.

Impact: The CI infrastructure will now validate each ACM release against supported OpenShift versions, ensuring compatibility with current and near-current OpenShift releases as they move through their lifecycle.

…422, and ACM 2.14 to OCP 421

Signed-off-by: Subbarao Meduri <smeduri@redhat.com>
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

This PR updates clusterpool selection filters in CI operator configurations for the multicluster-observability-operator across five release versions. The hub and managed cluster filters are bumped to newer versions: release-2.14 transitions from 417 to 421, while releases 2.15 through 5.0 move from 421 to 422.

Changes

Clusterpool Filter Version Updates

Layer / File(s) Summary
Clusterpool filter version bumps
ci-operator/config/stolostron/multicluster-observability-operator/stolostron-multicluster-observability-operator-release-2.14.yaml, stolostron-multicluster-observability-operator-release-2.15.yaml, stolostron-multicluster-observability-operator-release-2.16.yaml, stolostron-multicluster-observability-operator-release-2.17.yaml, stolostron-multicluster-observability-operator-release-5.0.yaml
CLUSTERPOOL_HUB_FILTER and CLUSTERPOOL_MANAGED_FILTER environment variables are updated across five release configurations to point to newer cluster pool versions for e2e test workflows.

Estimated code review effort: 🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels: lgtm

Suggested reviewers:

  • hector-vido
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR #80444 only updates YAML clusterpool filter env vars; no Ginkgo It/Describe/Context/When test titles found in the changed files view.
Test Structure And Quality ✅ Passed PR 80444 only updates 5 YAML clusterpool filter values; no Ginkgo test code (It/BeforeEach/AfterEach) was changed, so quality checks are not applicable.
Microshift Test Compatibility ✅ Passed PR #80444 only updates CLUSTERPOOL_* filters in 5 YAML release config files; no Ginkgo e2e tests (It/Describe/etc.) are added or changed, so no MicroShift incompatibility to flag.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR #80444 only updates CLUSTERPOOL_* filters in 5 stolostron e2e YAML files; no new Ginkgo e2e tests are added, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR #80444 only changes CI clusterpool selection env vars (CLUSTERPOOL_HUB_FILTER/CLUSTERPOOL_MANAGED_FILTER) in 5 YAML files; no pod affinity/topology spread/node-role scheduling constraints were f...
Ote Binary Stdout Contract ✅ Passed PR #80444 changes only 5 ci-operator stolostron YAMLs (CLUSTERPOOL_HUB_FILTER/CLUSTERPOOL_MANAGED_FILTER values); no OTE/Go process-level code modified, so stdout contract not impacted.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only updates CLUSTERPOOL_HUB_FILTER/CLUSTERPOOL_MANAGED_FILTER in YAML configs for 2.14/2.15/2.16/2.17/5.0; no new Ginkgo e2e tests or external/IPv4 logic to flag.
No-Weak-Crypto ✅ Passed PR #80444 only changes CLUSTERPOOL_HUB_FILTER/CLUSTERPOOL_MANAGED_FILTER values in YAML; GitHub diff shows no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, crypto, or constant-time patterns.
Container-Privileges ✅ Passed PR only updates CLUSTERPOOL_HUB_FILTER/CLUSTERPOOL_MANAGED_FILTER in 5 YAMLs; web searches of those files found no privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation/runAsUser.
No-Sensitive-Data-In-Logs ✅ Passed PR diff shows only CLUSTERPOOL_HUB_FILTER/CLUSTERPOOL_MANAGED_FILTER value changes in five YAMLs; no added passwords/tokens/API keys or log-printing of sensitive data detected.
Title check ✅ Passed The title accurately summarizes the main change: upgrading clusterpools across multiple ACM/Obs releases, which is exactly what the changeset does.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from gurnben and ngraham20 June 11, 2026 20:10
@subbarao-meduri subbarao-meduri changed the title upgrade clusterpools for ACM 5.0, 2.17, 2.16, 2.15, 2.14 upgrade clusterpools for Obs ACM 5.0, 2.17, 2.16, 2.15, 2.14 Jun 11, 2026
@openshift-ci

openshift-ci Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: subbarao-meduri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@subbarao-meduri: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stolostron-multicluster-observability-operator-release-2.15-test-e2e stolostron/multicluster-observability-operator presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-observability-operator-release-2.16-test-e2e stolostron/multicluster-observability-operator presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-observability-operator-release-2.14-test-e2e stolostron/multicluster-observability-operator presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-observability-operator-release-5.0-test-e2e stolostron/multicluster-observability-operator presubmit Ci-operator config changed
pull-ci-stolostron-multicluster-observability-operator-release-2.17-test-e2e stolostron/multicluster-observability-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@subbarao-meduri

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-stolostron-multicluster-observability-operator-release-2.17-test-e2e pull-ci-stolostron-multicluster-observability-operator-release-5.0-test-e2e pull-ci-stolostron-multicluster-observability-operator-release-2.14-test-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@subbarao-meduri: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@subbarao-meduri: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/stolostron/multicluster-observability-operator/release-2.17/test-e2e 39f2f79 link unknown /pj-rehearse pull-ci-stolostron-multicluster-observability-operator-release-2.17-test-e2e
ci/rehearse/stolostron/multicluster-observability-operator/release-2.14/test-e2e 39f2f79 link unknown /pj-rehearse pull-ci-stolostron-multicluster-observability-operator-release-2.14-test-e2e
ci/rehearse/stolostron/multicluster-observability-operator/release-5.0/test-e2e 39f2f79 link unknown /pj-rehearse pull-ci-stolostron-multicluster-observability-operator-release-5.0-test-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant