Skip to content

OSAC-1377: Add skip_if_only_changed filters to osac-aap e2e-vmaas test#80463

Open
amej wants to merge 1 commit into
openshift:mainfrom
amej:osac-aap-OSAC-1377
Open

OSAC-1377: Add skip_if_only_changed filters to osac-aap e2e-vmaas test#80463
amej wants to merge 1 commit into
openshift:mainfrom
amej:osac-aap-OSAC-1377

Conversation

@amej

@amej amej commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

[OSAC-1377](https://redhat.atlassian.net/browse/OS[AC-1](https://redhat.atlassian.net/browse/AC-1)377): Add skip_if_only_changed filters to osac-aap e2e-vmaas test

Jira: https://issues.redhat.com/browse/OS[AC-1](https://redhat.atlassian.net/browse/AC-1)377
Story type: [DEV]

Summary

This PR adds skip_if_only_changed filters to the osac-aap e2e-vmaas Prow presubmit test to optimize CI resource usage. The filter skips expensive E2E tests when pull requests only modify documentation, sample configurations, Helm charts, GitHub workflow files, or linting configuration files.

The implementation uses a denylist approach (skip_if_only_changed) rather than an allowlist (run_if_changed) to ensure new file types trigger tests by default, providing a safe-by-default behavior.

Changes

CI Configuration:

  • Added skip_if_only_changed regex filter to e2e-vmaas test in ci-operator/config/osac-project/osac-aap/osac-project-osac-aap-main.yaml
  • Pattern covers: README, CLAUDE.md, AGENTS.md, docs/, samples/, charts/, .github/workflows/, .ansible-lint*, OWNERS, LICENSE

Generated Prow Jobs:

  • Regenerated ci-operator/jobs/osac-project/osac-aap/osac-project-osac-aap-main-presubmits.yaml via make update
  • Job now has always_run: false (changed from true)
  • Skip filter properly propagated to Prow job configuration

Testing

  • Regex validation: Manual testing against 20 file paths (13 documentation files, 7 functional files)
    • 100% accuracy: all documentation files correctly matched, all functional files correctly excluded
  • Configuration validation: make update successfully regenerated Prow jobs
  • Syntax validation: make checkconfig will validate in PR CI (worktree limitation)

Test coverage: Not applicable — this is a CI configuration change, not application code.

Acceptance Criteria

  • AC-1: skip_if_only_changed filter added to e2e-vmaas test
  • AC-2: Documentation files pattern included (README, CLAUDE, AGENTS, docs/*)
  • AC-3: Sample configs pattern included (samples/*)
  • AC-4: Helm charts pattern included (charts/*)
  • AC-5: GitHub workflows pattern included (.github/workflows/*)
  • AC-6: Linter configs pattern included (.ansible-lint*)
  • AC-7: Ownership files included (OWNERS, LICENSE)
  • AC-8: Prow job configuration correctly regenerated
  • AC-9: Denylist approach used (safe-by-default for new file types)

Related

Summary by CodeRabbit

This PR optimizes the CI pipeline for the osac-aap component by adding a skip_if_only_changed filter to the e2e-vmaas Prow presubmit test. The filter prevents the expensive end-to-end VMaaS test from running when pull requests only modify non-functional files such as:

  • Documentation files (README.md, AGENTS.md, CLAUDE.md, docs/*)
  • Sample configurations (samples/*)
  • Helm charts (charts/*)
  • GitHub workflow files (.github/workflows/*)
  • Linter configuration (.ansible-lint.*)
  • Repository metadata (OWNERS, LICENSE)

The filter is implemented as a regex pattern in the CI configuration (ci-operator/config/osac-project/osac-aap/osac-project-osac-aap-main.yaml) and is automatically propagated to the generated Prow job definition. By using a denylist approach (skip rather than trigger), the configuration remains safe-by-default—new file types will still trigger tests unless explicitly added to the skip pattern.

The change affects the osac-aap component's CI configuration in the openshift/release repository and has been validated against sample file paths to confirm accurate filtering.

[OSAC-1377]: https://redhat.atlassian.net/browse/OS[AC-1](https://redhat.atlassian.net/browse/AC-1)377?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

[OSAC-1377]: https://redhat.atlassian.net/browse/OS[AC-1](https://redhat.atlassian.net/browse/AC-1)377?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Skip e2e-vmaas tests when PRs only modify documentation, sample
configs, Helm charts, linting configs, or ownership files. Uses
skip_if_only_changed denylist approach to ensure new file types
trigger tests by default.

Filters documentation (*.md, docs/, samples/), Helm charts (charts/),
GitHub Actions workflows (.github/workflows/), linting configs
(.ansible-lint*), ownership (OWNERS, LICENSE), and AI guidance
(CLAUDE.md, AGENTS.md).

Relates to: OSAC-1377
Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com>

Signed-off-by: Ameya Sathe <asathe@redhat.com>

rh-pre-commit.version: 2.4.0
rh-pre-commit.check-secrets: ENABLED
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 12, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@amej: This pull request references [OSAC-1377](https://redhat.atlassian.net/browse/OS[AC-1](https://redhat.atlassian.net/browse/AC-1)377) which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

[OSAC-1377](https://redhat.atlassian.net/browse/OS[AC-1](https://redhat.atlassian.net/browse/AC-1)377): Add skip_if_only_changed filters to osac-aap e2e-vmaas test

Jira: https://issues.redhat.com/browse/OS[AC-1](https://redhat.atlassian.net/browse/AC-1)377
Story type: [DEV]

Summary

This PR adds skip_if_only_changed filters to the osac-aap e2e-vmaas Prow presubmit test to optimize CI resource usage. The filter skips expensive E2E tests when pull requests only modify documentation, sample configurations, Helm charts, GitHub workflow files, or linting configuration files.

The implementation uses a denylist approach (skip_if_only_changed) rather than an allowlist (run_if_changed) to ensure new file types trigger tests by default, providing a safe-by-default behavior.

Changes

CI Configuration:

  • Added skip_if_only_changed regex filter to e2e-vmaas test in ci-operator/config/osac-project/osac-aap/osac-project-osac-aap-main.yaml
  • Pattern covers: README, CLAUDE.md, AGENTS.md, docs/, samples/, charts/, .github/workflows/, .ansible-lint*, OWNERS, LICENSE

Generated Prow Jobs:

  • Regenerated ci-operator/jobs/osac-project/osac-aap/osac-project-osac-aap-main-presubmits.yaml via make update
  • Job now has always_run: false (changed from true)
  • Skip filter properly propagated to Prow job configuration

Testing

  • Regex validation: Manual testing against 20 file paths (13 documentation files, 7 functional files)
  • 100% accuracy: all documentation files correctly matched, all functional files correctly excluded
  • Configuration validation: make update successfully regenerated Prow jobs
  • Syntax validation: make checkconfig will validate in PR CI (worktree limitation)

Test coverage: Not applicable — this is a CI configuration change, not application code.

Acceptance Criteria

  • AC-1: skip_if_only_changed filter added to e2e-vmaas test
  • AC-2: Documentation files pattern included (README, CLAUDE, AGENTS, docs/*)
  • AC-3: Sample configs pattern included (samples/*)
  • AC-4: Helm charts pattern included (charts/*)
  • AC-5: GitHub workflows pattern included (.github/workflows/*)
  • AC-6: Linter configs pattern included (.ansible-lint*)
  • AC-7: Ownership files included (OWNERS, LICENSE)
  • AC-8: Prow job configuration correctly regenerated
  • AC-9: Denylist approach used (safe-by-default for new file types)

Related

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2026
@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot

openshift-ci-robot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@amej: This pull request references [OSAC-1377](https://redhat.atlassian.net/browse/OS[AC-1](https://redhat.atlassian.net/browse/AC-1)377) which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

[OSAC-1377](https://redhat.atlassian.net/browse/OS[AC-1](https://redhat.atlassian.net/browse/AC-1)377): Add skip_if_only_changed filters to osac-aap e2e-vmaas test

Jira: https://issues.redhat.com/browse/OS[AC-1](https://redhat.atlassian.net/browse/AC-1)377
Story type: [DEV]

Summary

This PR adds skip_if_only_changed filters to the osac-aap e2e-vmaas Prow presubmit test to optimize CI resource usage. The filter skips expensive E2E tests when pull requests only modify documentation, sample configurations, Helm charts, GitHub workflow files, or linting configuration files.

The implementation uses a denylist approach (skip_if_only_changed) rather than an allowlist (run_if_changed) to ensure new file types trigger tests by default, providing a safe-by-default behavior.

Changes

CI Configuration:

  • Added skip_if_only_changed regex filter to e2e-vmaas test in ci-operator/config/osac-project/osac-aap/osac-project-osac-aap-main.yaml
  • Pattern covers: README, CLAUDE.md, AGENTS.md, docs/, samples/, charts/, .github/workflows/, .ansible-lint*, OWNERS, LICENSE

Generated Prow Jobs:

  • Regenerated ci-operator/jobs/osac-project/osac-aap/osac-project-osac-aap-main-presubmits.yaml via make update
  • Job now has always_run: false (changed from true)
  • Skip filter properly propagated to Prow job configuration

Testing

  • Regex validation: Manual testing against 20 file paths (13 documentation files, 7 functional files)
  • 100% accuracy: all documentation files correctly matched, all functional files correctly excluded
  • Configuration validation: make update successfully regenerated Prow jobs
  • Syntax validation: make checkconfig will validate in PR CI (worktree limitation)

Test coverage: Not applicable — this is a CI configuration change, not application code.

Acceptance Criteria

  • AC-1: skip_if_only_changed filter added to e2e-vmaas test
  • AC-2: Documentation files pattern included (README, CLAUDE, AGENTS, docs/*)
  • AC-3: Sample configs pattern included (samples/*)
  • AC-4: Helm charts pattern included (charts/*)
  • AC-5: GitHub workflows pattern included (.github/workflows/*)
  • AC-6: Linter configs pattern included (.ansible-lint*)
  • AC-7: Ownership files included (OWNERS, LICENSE)
  • AC-8: Prow job configuration correctly regenerated
  • AC-9: Denylist approach used (safe-by-default for new file types)

Related

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

This PR adds a skip_if_only_changed rule to the e2e-vmaas test in the OSAC AAP CI configuration. The test is skipped when changes are limited to documentation, samples, workflows, and metadata files, reducing unnecessary CI runs for non-functional changes.

Changes

E2E-VMAAS Test Skip Configuration

Layer / File(s) Summary
Skip rule for non-functional changes
ci-operator/config/osac-project/osac-aap/osac-project-osac-aap-main.yaml
Adds skip_if_only_changed regex to the e2e-vmaas test definition to skip execution when only documentation (README, AGENTS, CLAUDE, docs/), samples (samples/, charts/), workflows (.github/workflows/), ansible lint configuration (.ansible-lint.*), and metadata files (OWNERS, LICENSE) are modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: adding skip_if_only_changed filters to the e2e-vmaas test in osac-aap configuration, with specific reference to the JIRA ticket OSAC-1377.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR #80463 changes only 2 CI YAML files (skip_if_only_changed + always_run:false); no Ginkgo test code/titles are modified, so stable test-name requirement is met.
Test Structure And Quality ✅ Passed Repo has no Ginkgo-related Go test code (0 files reference ginkgo/Describe/It). PR changes only CI YAML (skip_if_only_changed in osac-aap config & presubmits).
Microshift Test Compatibility ✅ Passed PR is a CI configuration change that modifies skip filters for an existing test; no new Ginkgo e2e tests are added, so the MicroShift compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR #80463 only updates ci-operator YAML configs for osac-aap e2e-vmaas (skip_if_only_changed/always_run); no new Ginkgo e2e test code is added, so SNO compatibility assumptions can’t be evaluated/a...
Topology-Aware Scheduling Compatibility ✅ Passed PR only updates osac-aap e2e-vmaas CI skip_if_only_changed config and presubmit job YAML; inspected both files for affinity/topologyKey/anti-affinity/PDB/taints—none present.
Ote Binary Stdout Contract ✅ Passed PR #80463 changes only two YAML files (osac-project-osac-aap-main.yaml and osac-project-osac-aap-main-presubmits.yaml); no Go OTE binary main/init/TestMain code was modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR modifies CI configuration metadata only (adding skip_if_only_changed filter to existing test); no new Ginkgo e2e tests are added, so the check does not apply.
No-Weak-Crypto ✅ Passed Reviewed PR #80463 YAML diffs; only skip_if_only_changed regex added/propagated. No MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, crypto, or constant-time comparisons found.
Container-Privileges ✅ Passed No privileged container configurations found. This is a CI configuration change that adds test-skipping filters without introducing any container privilege escalation, host access modes, or other s...
No-Sensitive-Data-In-Logs ✅ Passed Diff for #80463 only adds a skip_if_only_changed regex and sets always_run: false in two YAML files; no passwords/tokens/API keys/PII are introduced in the changes.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amej
Once this PR has been reviewed and has the lgtm label, please assign danmanor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot

openshift-ci-robot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@amej: This pull request references [OSAC-1377](https://redhat.atlassian.net/browse/OS[AC-1](https://redhat.atlassian.net/browse/AC-1)377) which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

[OSAC-1377](https://redhat.atlassian.net/browse/OS[AC-1](https://redhat.atlassian.net/browse/AC-1)377): Add skip_if_only_changed filters to osac-aap e2e-vmaas test

Jira: https://issues.redhat.com/browse/OS[AC-1](https://redhat.atlassian.net/browse/AC-1)377
Story type: [DEV]

Summary

This PR adds skip_if_only_changed filters to the osac-aap e2e-vmaas Prow presubmit test to optimize CI resource usage. The filter skips expensive E2E tests when pull requests only modify documentation, sample configurations, Helm charts, GitHub workflow files, or linting configuration files.

The implementation uses a denylist approach (skip_if_only_changed) rather than an allowlist (run_if_changed) to ensure new file types trigger tests by default, providing a safe-by-default behavior.

Changes

CI Configuration:

  • Added skip_if_only_changed regex filter to e2e-vmaas test in ci-operator/config/osac-project/osac-aap/osac-project-osac-aap-main.yaml
  • Pattern covers: README, CLAUDE.md, AGENTS.md, docs/, samples/, charts/, .github/workflows/, .ansible-lint*, OWNERS, LICENSE

Generated Prow Jobs:

  • Regenerated ci-operator/jobs/osac-project/osac-aap/osac-project-osac-aap-main-presubmits.yaml via make update
  • Job now has always_run: false (changed from true)
  • Skip filter properly propagated to Prow job configuration

Testing

  • Regex validation: Manual testing against 20 file paths (13 documentation files, 7 functional files)
  • 100% accuracy: all documentation files correctly matched, all functional files correctly excluded
  • Configuration validation: make update successfully regenerated Prow jobs
  • Syntax validation: make checkconfig will validate in PR CI (worktree limitation)

Test coverage: Not applicable — this is a CI configuration change, not application code.

Acceptance Criteria

  • AC-1: skip_if_only_changed filter added to e2e-vmaas test
  • AC-2: Documentation files pattern included (README, CLAUDE, AGENTS, docs/*)
  • AC-3: Sample configs pattern included (samples/*)
  • AC-4: Helm charts pattern included (charts/*)
  • AC-5: GitHub workflows pattern included (.github/workflows/*)
  • AC-6: Linter configs pattern included (.ansible-lint*)
  • AC-7: Ownership files included (OWNERS, LICENSE)
  • AC-8: Prow job configuration correctly regenerated
  • AC-9: Denylist approach used (safe-by-default for new file types)

Related

Summary by CodeRabbit

This PR optimizes the CI pipeline for the osac-aap component by adding a skip_if_only_changed filter to the e2e-vmaas Prow presubmit test. The filter prevents the expensive end-to-end VMaaS test from running when pull requests only modify non-functional files such as:

  • Documentation files (README.md, AGENTS.md, CLAUDE.md, docs/*)
  • Sample configurations (samples/*)
  • Helm charts (charts/*)
  • GitHub workflow files (.github/workflows/*)
  • Linter configuration (.ansible-lint.*)
  • Repository metadata (OWNERS, LICENSE)

The filter is implemented as a regex pattern in the CI configuration (ci-operator/config/osac-project/osac-aap/osac-project-osac-aap-main.yaml) and is automatically propagated to the generated Prow job definition. By using a denylist approach (skip rather than trigger), the configuration remains safe-by-default—new file types will still trigger tests unless explicitly added to the skip pattern.

The change affects the osac-aap component's CI configuration in the openshift/release repository and has been validated against sample file paths to confirm accurate filtering.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@amej: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-osac-project-osac-aap-main-e2e-vmaas osac-project/osac-aap presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot

openshift-ci-robot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@amej: This pull request references OSAC-1377 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

[OSAC-1377](https://redhat.atlassian.net/browse/OS[AC-1](https://redhat.atlassian.net/browse/AC-1)377): Add skip_if_only_changed filters to osac-aap e2e-vmaas test

Jira: https://issues.redhat.com/browse/OS[AC-1](https://redhat.atlassian.net/browse/AC-1)377
Story type: [DEV]

Summary

This PR adds skip_if_only_changed filters to the osac-aap e2e-vmaas Prow presubmit test to optimize CI resource usage. The filter skips expensive E2E tests when pull requests only modify documentation, sample configurations, Helm charts, GitHub workflow files, or linting configuration files.

The implementation uses a denylist approach (skip_if_only_changed) rather than an allowlist (run_if_changed) to ensure new file types trigger tests by default, providing a safe-by-default behavior.

Changes

CI Configuration:

  • Added skip_if_only_changed regex filter to e2e-vmaas test in ci-operator/config/osac-project/osac-aap/osac-project-osac-aap-main.yaml
  • Pattern covers: README, CLAUDE.md, AGENTS.md, docs/, samples/, charts/, .github/workflows/, .ansible-lint*, OWNERS, LICENSE

Generated Prow Jobs:

  • Regenerated ci-operator/jobs/osac-project/osac-aap/osac-project-osac-aap-main-presubmits.yaml via make update
  • Job now has always_run: false (changed from true)
  • Skip filter properly propagated to Prow job configuration

Testing

  • Regex validation: Manual testing against 20 file paths (13 documentation files, 7 functional files)
  • 100% accuracy: all documentation files correctly matched, all functional files correctly excluded
  • Configuration validation: make update successfully regenerated Prow jobs
  • Syntax validation: make checkconfig will validate in PR CI (worktree limitation)

Test coverage: Not applicable — this is a CI configuration change, not application code.

Acceptance Criteria

  • AC-1: skip_if_only_changed filter added to e2e-vmaas test
  • AC-2: Documentation files pattern included (README, CLAUDE, AGENTS, docs/*)
  • AC-3: Sample configs pattern included (samples/*)
  • AC-4: Helm charts pattern included (charts/*)
  • AC-5: GitHub workflows pattern included (.github/workflows/*)
  • AC-6: Linter configs pattern included (.ansible-lint*)
  • AC-7: Ownership files included (OWNERS, LICENSE)
  • AC-8: Prow job configuration correctly regenerated
  • AC-9: Denylist approach used (safe-by-default for new file types)

Related

Summary by CodeRabbit

This PR optimizes the CI pipeline for the osac-aap component by adding a skip_if_only_changed filter to the e2e-vmaas Prow presubmit test. The filter prevents the expensive end-to-end VMaaS test from running when pull requests only modify non-functional files such as:

  • Documentation files (README.md, AGENTS.md, CLAUDE.md, docs/*)
  • Sample configurations (samples/*)
  • Helm charts (charts/*)
  • GitHub workflow files (.github/workflows/*)
  • Linter configuration (.ansible-lint.*)
  • Repository metadata (OWNERS, LICENSE)

The filter is implemented as a regex pattern in the CI configuration (ci-operator/config/osac-project/osac-aap/osac-project-osac-aap-main.yaml) and is automatically propagated to the generated Prow job definition. By using a denylist approach (skip rather than trigger), the configuration remains safe-by-default—new file types will still trigger tests unless explicitly added to the skip pattern.

The change affects the osac-aap component's CI configuration in the openshift/release repository and has been validated against sample file paths to confirm accurate filtering.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@amej

amej commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

/test all

@amej

amej commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack pull-ci-osac-project-osac-aap-main-e2e-vmaas

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@amej: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@amej: job(s): auto-ack either don't exist or were not found to be affected, and cannot be rehearsed

@amej amej marked this pull request as ready for review June 12, 2026 10:20
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2026
@amej

amej commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@amej: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/core-valid 2577439 link true /test core-valid
ci/rehearse/osac-project/osac-aap/main/e2e-vmaas 2577439 link unknown /pj-rehearse pull-ci-osac-project-osac-aap-main-e2e-vmaas

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@amej

amej commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

@amej: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/core-valid 2577439 link true /test core-valid
ci/rehearse/osac-project/osac-aap/main/e2e-vmaas 2577439 link unknown /pj-rehearse pull-ci-osac-project-osac-aap-main-e2e-vmaas

Full PR test history. Your PR dashboard.
Details

Ref: https://redhat-internal.slack.com/archives/CFUGK0K9R/p1781233123968399
:alert-siren: The amd64 release controller has lost a significant amount of release data. The root cause is being analyzed and data recovered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants