OSAC-1377: Add skip_if_only_changed filters to osac-aap e2e-vmaas test#80463
OSAC-1377: Add skip_if_only_changed filters to osac-aap e2e-vmaas test#80463amej wants to merge 1 commit into
Conversation
Skip e2e-vmaas tests when PRs only modify documentation, sample configs, Helm charts, linting configs, or ownership files. Uses skip_if_only_changed denylist approach to ensure new file types trigger tests by default. Filters documentation (*.md, docs/, samples/), Helm charts (charts/), GitHub Actions workflows (.github/workflows/), linting configs (.ansible-lint*), ownership (OWNERS, LICENSE), and AI guidance (CLAUDE.md, AGENTS.md). Relates to: OSAC-1377 Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Ameya Sathe <asathe@redhat.com> rh-pre-commit.version: 2.4.0 rh-pre-commit.check-secrets: ENABLED
|
@amej: This pull request references [OSAC-1377](https://redhat.atlassian.net/browse/OS[AC-1](https://redhat.atlassian.net/browse/AC-1)377) which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
@amej: This pull request references [OSAC-1377](https://redhat.atlassian.net/browse/OS[AC-1](https://redhat.atlassian.net/browse/AC-1)377) which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThis PR adds a ChangesE2E-VMAAS Test Skip Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amej The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@amej: This pull request references [OSAC-1377](https://redhat.atlassian.net/browse/OS[AC-1](https://redhat.atlassian.net/browse/AC-1)377) which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@amej: This pull request references OSAC-1377 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test all |
|
/pj-rehearse auto-ack pull-ci-osac-project-osac-aap-main-e2e-vmaas |
|
@amej: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@amej: job(s): auto-ack either don't exist or were not found to be affected, and cannot be rehearsed |
|
/retest |
|
@amej: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Ref: https://redhat-internal.slack.com/archives/CFUGK0K9R/p1781233123968399 |
[OSAC-1377](https://redhat.atlassian.net/browse/OS[AC-1](https://redhat.atlassian.net/browse/AC-1)377): Add skip_if_only_changed filters to osac-aap e2e-vmaas test
Jira: https://issues.redhat.com/browse/OS[AC-1](https://redhat.atlassian.net/browse/AC-1)377
Story type: [DEV]
Summary
This PR adds
skip_if_only_changedfilters to the osac-aap e2e-vmaas Prow presubmit test to optimize CI resource usage. The filter skips expensive E2E tests when pull requests only modify documentation, sample configurations, Helm charts, GitHub workflow files, or linting configuration files.The implementation uses a denylist approach (
skip_if_only_changed) rather than an allowlist (run_if_changed) to ensure new file types trigger tests by default, providing a safe-by-default behavior.Changes
CI Configuration:
skip_if_only_changedregex filter to e2e-vmaas test inci-operator/config/osac-project/osac-aap/osac-project-osac-aap-main.yamlGenerated Prow Jobs:
ci-operator/jobs/osac-project/osac-aap/osac-project-osac-aap-main-presubmits.yamlviamake updatealways_run: false(changed fromtrue)Testing
make updatesuccessfully regenerated Prow jobsmake checkconfigwill validate in PR CI (worktree limitation)Test coverage: Not applicable — this is a CI configuration change, not application code.
Acceptance Criteria
Related
Summary by CodeRabbit
This PR optimizes the CI pipeline for the osac-aap component by adding a
skip_if_only_changedfilter to thee2e-vmaasProw presubmit test. The filter prevents the expensive end-to-end VMaaS test from running when pull requests only modify non-functional files such as:The filter is implemented as a regex pattern in the CI configuration (
ci-operator/config/osac-project/osac-aap/osac-project-osac-aap-main.yaml) and is automatically propagated to the generated Prow job definition. By using a denylist approach (skip rather than trigger), the configuration remains safe-by-default—new file types will still trigger tests unless explicitly added to the skip pattern.The change affects the osac-aap component's CI configuration in the openshift/release repository and has been validated against sample file paths to confirm accurate filtering.
[OSAC-1377]: https://redhat.atlassian.net/browse/OS[AC-1](https://redhat.atlassian.net/browse/AC-1)377?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[OSAC-1377]: https://redhat.atlassian.net/browse/OS[AC-1](https://redhat.atlassian.net/browse/AC-1)377?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ