Skip to content

openperouter: Edge image for Prow#80464

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
zeeke:openperouter/edge-image
Jun 12, 2026
Merged

openperouter: Edge image for Prow#80464
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
zeeke:openperouter/edge-image

Conversation

@zeeke

@zeeke zeeke commented Jun 12, 2026

Copy link
Copy Markdown
Contributor
  • Add Prow config for the Dockerfile.edge.openshift image
  • Disable git sparse checkout to allow submodules to be updated

Summary by CodeRabbit

This PR adds CI/Prow configuration for an edge image variant of the openperouter component in the OpenShift KNI organization.

Key changes:

  • New edge image build: Adds Dockerfile.edge.openshift as a new image build target (openperouter-operator) that uses CentOS Stream 10 as its base image.

  • Sparse checkout disabled: Disables git sparse checkout in the Prow jobs for this configuration. This allows git submodules (such as openshift/deps/dpdk) to be properly checked out and updated during CI builds, preventing checkout failures that previously occurred when sparse checkout was enabled.

These changes enable the OpenShift KNI team to build and test an edge variant of openperouter with proper submodule support in the CI pipeline.

zeeke added 2 commits June 12, 2026 11:18
Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
to avoid Prow failures when bumping git submodules like:
```
$ PWD=/home/prow/go/src/github.com/openperouter/openperouter  git sparse-checkout set Dockerfile.openshift operator/bundle.Dockerfile.openshift (runtime: 1.914726ms)
$ PWD=/home/prow/go/src/github.com/openperouter/openperouter  git checkout 645154fd58043a78fccf1931d0846fa15d8c60ba (runtime: 272.990849ms)
...
From https://github.com/openshift-kni/openperouter
 * branch            d67eb559a64912b33d0c8a977f51a13fab5c90b3 -> FETCH_HEAD
Could not access submodule 'openshift/deps/dpdk'
```

Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 283c6aee-838d-4cc6-97be-02298b12fd1e

📥 Commits

Reviewing files that changed from the base of the PR and between 4d87662 and eac11d4.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift-kni/openperouter/openshift-kni-openperouter-main-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-kni/openperouter/openshift-kni-openperouter-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift-kni/openperouter/openshift-kni-openperouter-main.yaml

Walkthrough

The OpenShift CI operator configuration for the openperouter project was updated to add an edge image build definition that uses Dockerfile.edge.openshift and CentOS stream10 as the base image. The prowgen configuration was also updated to disable sparse checkout.

Changes

CI Configuration Update

Layer / File(s) Summary
Edge image build and sparse checkout configuration
ci-operator/config/openshift-kni/openperouter/openshift-kni-openperouter-main.yaml
Added edge image build item under images.items that points to Dockerfile.edge.openshift, targets openperouter-operator, and supplies BASE_IMAGE build argument set to quay.io/centos/centos:stream10. Set prowgen.disable_sparse_checkout to true.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

lgtm, ok-to-test

Suggested reviewers

  • kaovilai
  • jmguzik
  • shubham-pampattiwar
  • Joeavaikath
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'openperouter: Edge image for Prow' directly and concisely summarizes the main change: adding an edge image build definition to the Prow configuration for the openperouter project.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR #80464 only modifies 3 YAML Prow/ci-operator config files (no .go/test files changed), so no Ginkgo test titles in It/Describe/Context/When were introduced or altered.
Test Structure And Quality ✅ Passed The PR changes CI YAML only; among 41 changed .go files and 11 _test.go files, none import github.com/onsi/ginkgo—no Ginkgo tests to review.
Microshift Test Compatibility ✅ Passed PR #80464 changes only ci-operator YAML for openperouter/Prow (edge image + disable sparse checkout); no Go/Ginkgo e2e tests added/modified, so MicroShift compatibility isn’t applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR #80464 changes only ci-operator YAML for openperouter edge image + disable sparse checkout; no new Ginkgo e2e tests (It/Describe/Context) added.
Topology-Aware Scheduling Compatibility ✅ Passed PR updates only CI/operator Prow image build config (edge image + BASE_IMAGE) and sets prowgen disable_sparse_checkout; no scheduling/affinity/topology constraints are added.
Ote Binary Stdout Contract ✅ Passed PR #80464 only changes ci-operator YAML (edge image build + disable_sparse_checkout). No OTE/openshift-tests Go code changes that could affect main/init/stdout JSON contract.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only ci-operator OpenShift KNI openperouter YAML (image build + sparse checkout); no new Ginkgo e2e tests/files are added or changed, so the IPv6/disconnected test compatibility check i...
No-Weak-Crypto ✅ Passed The PR modifies only a CI/CD configuration YAML file with no cryptographic code; no weak crypto algorithms, custom implementations, or unsafe comparisons detected.
Container-Privileges ✅ Passed PR updates ci-operator config to add edge image build args and disable sparse checkout; no privileged/hostPID/hostNetwork/hostIPC/allowPrivilegeEscalation or SYS_ADMIN capability fields appear in t...
No-Sensitive-Data-In-Logs ✅ Passed In openshift-kni-openperouter-main.yaml, the PR’s Prow/image additions include BASE_IMAGE and disable_sparse_checkout only; no password/token/secret/Authorization strings or echo-style log commands...

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from fedepaol and oribon June 12, 2026 09:20
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@zeeke: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kni-openperouter-main-ci-bundle-operator-bundle openshift-kni/openperouter presubmit Ci-operator config changed
pull-ci-openshift-kni-openperouter-main-images openshift-kni/openperouter presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@zeeke

zeeke commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@zeeke: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@zeeke

zeeke commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@zeeke: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 12, 2026
@fedepaol

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2026
@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fedepaol, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zeeke

zeeke commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@zeeke: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 57b22aa into openshift:main Jun 12, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants