ARO-HCP: Add slots for the new STG e2e subscription

[roivaz]

https://redhat.atlassian.net/browse/ARO-27550

Summary by CodeRabbit

This PR updates OpenShift CI Boskos configuration to add ARO-HCP end-to-end (e2e) testing slot resources for shard 0, affecting core-services/prow configuration used by the CI infrastructure for ARO-HCP tests.

What changed (practical terms)

• Adds two new Boskos slot resources to the Boskos inventory so CI jobs can reserve them:
  • aro-hcp-int-shard0-slot with aro-hcp-int-shard0-slot-00
  • aro-hcp-stg-shard0-slot with aro-hcp-stg-shard0-slot-00
    These entries are placed near the existing ARO-HCP quota-slice declarations in core-services/prow/02_config/_boskos.yaml.
• Updates core-services/prow/02_config/generate-boskos.py to include both aro-hcp-int-shard0-slot and aro-hcp-stg-shard0-slot in the generator CONFIG so the slot entries are produced automatically when the Boskos YAML is regenerated. The generator creates one instance (index 00) for each new slot type.

Additional context

• Commit message and PR description indicate this supports migrating the INT e2e subscription into the slot catalog and adds the new STG e2e subscription slot.
• References Jira: ARO-27550.

Impact

• Enables CI e2e jobs for ARO-HCP (INT and STG shard 0) to acquire dedicated Boskos slots for testing, improving resource reservation for end-to-end pipelines.

[coderabbitai]

Walkthrough

This PR adds two ARO-HCP E2E Boskos slot types for shard 0 (internal and staging), updates the Boskos generator to populate them with one instance each, and commits those instances to the static _boskos.yaml as free resources.

Changes

ARO-HCP E2E Shard 0 Slot Resources (internal and staging)

Layer / File(s)	Summary
Boskos generator CONFIG and population core-services/prow/02_config/generate-boskos.py	Adds aro-hcp-int-shard0-slot and aro-hcp-stg-shard0-slot keys to CONFIG and adds generation loops that populate each with ...-00 instance names.
Static Boskos YAML additions core-services/prow/02_config/_boskos.yaml	Commits the resulting resources to _boskos.yaml, reserving aro-hcp-int-shard0-slot-00 and aro-hcp-stg-shard0-slot-00 in free state.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title 'ARO-HCP: Add slots for the new STG e2e subscription' is directly related to the changeset, which adds Boskos resource slots for both INT and STG ARO-HCP shard 0, supporting the migration of e2e subscriptions to the slot catalog.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR #80465 changes only Boskos config (_boskos.yaml, generate-boskos.py) and contains no Ginkgo test titles to review, so no non-deterministic names were introduced. citeturn2view0turn6view0turn...
Test Structure And Quality	✅ Passed	PR 80465 changes only core-services/prow Boskos config + generator; no Ginkgo test code (no Describe/It/BeforeEach/AfterEach/Eventually/Consistently) is modified.
Microshift Test Compatibility	✅ Passed	PR #80465 only modifies core-services/prow/02_config/_boskos.yaml and generate-boskos.py; no new Ginkgo e2e tests (no *_test.go), so no MicroShift API incompatibilities to flag.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR #80465 only updates Boskos config/generator (_boskos.yaml, generate-boskos.py); no Ginkgo *_test.go or e2e tests added, so SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	This PR modifies Boskos CI/CD resource configuration files, not Kubernetes deployment manifests or operator code. No scheduling constraints, affinity rules, or topology-related directives are intro...
Ote Binary Stdout Contract	✅ Passed	PR only updates core-services/prow/02_config/_boskos.yaml and generate-boskos.py; no OTE binary Go files (main/init/TestMain/BeforeSuite) were changed, so the stdout contract isn’t affected.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	GitHub shows this PR only changes core-services/prow/02_config/_boskos.yaml and generate-boskos.py (2 files); no new Ginkgo e2e tests were added to assess for IPv4/internet assumptions.
No-Weak-Crypto	✅ Passed	PR adds Boskos slot entries and generates new slot names; scans of changed YAML/Python content found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or secret/token comparison logic.
Container-Privileges	✅ Passed	PR only updates core-services/prow/02_config/_boskos.yaml and generate-boskos.py; web scan finds no occurrences of privileged/hostNetwork/hostPID/hostIPC/SYS_ADMIN/allowPrivilegeEscalation/security...
No-Sensitive-Data-In-Logs	✅ Passed	PR only adds Boskos slot/resource entries. generate-boskos.py changes CONFIG/slot generation and contains no logging of passwords/tokens (no 'token'/'password' found in inspected script).
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@roivaz: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@roivaz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[raelga]

/lgtm
/approve

[hector-vido]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hector-vido, raelga, roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• core-services/prow/02_config/OWNERS [hector-vido]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@roivaz: Updated the resources configmap in namespace ci at cluster app.ci using the following files:

• key boskos.yaml using file core-services/prow/02_config/_boskos.yaml

Details

In response to this:

https://redhat.atlassian.net/browse/ARO-27550

Summary by CodeRabbit

This PR updates OpenShift CI Boskos configuration to add ARO-HCP end-to-end (e2e) testing slot resources for shard 0, affecting core-services/prow configuration used by the CI infrastructure for ARO-HCP tests.

What changed (practical terms)

• Adds two new Boskos slot resources to the Boskos inventory so CI jobs can reserve them:
• aro-hcp-int-shard0-slot with aro-hcp-int-shard0-slot-00
• aro-hcp-stg-shard0-slot with aro-hcp-stg-shard0-slot-00
  These entries are placed near the existing ARO-HCP quota-slice declarations in core-services/prow/02_config/_boskos.yaml.
• Updates core-services/prow/02_config/generate-boskos.py to include both aro-hcp-int-shard0-slot and aro-hcp-stg-shard0-slot in the generator CONFIG so the slot entries are produced automatically when the Boskos YAML is regenerated. The generator creates one instance (index 00) for each new slot type.

Additional context

• Commit message and PR description indicate this supports migrating the INT e2e subscription into the slot catalog and adds the new STG e2e subscription slot.
• References Jira: ARO-27550.

Impact

• Enables CI e2e jobs for ARO-HCP (INT and STG shard 0) to acquire dedicated Boskos slots for testing, improving resource reservation for end-to-end pipelines.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.