This repository was archived by the owner on Aug 29, 2018. It is now read-only.
Add gpgme and libassuan to install dependencies#535
Merged
stevekuznetsov merged 1 commit intoopenshift:masterfrom Apr 6, 2017
Merged
Add gpgme and libassuan to install dependencies#535stevekuznetsov merged 1 commit intoopenshift:masterfrom
stevekuznetsov merged 1 commit intoopenshift:masterfrom
Conversation
| Xvfb \ | ||
| yum-utils \ | ||
| zip No newline at end of file | ||
| gpgme \ |
Contributor
Author
There was a problem hiding this comment.
entire file? because that will make the diff bigger ;-)
Contributor
There was a problem hiding this comment.
We try to keep it sorted ... not everyone is as strict ;)
mfojtik
force-pushed
the
add_signature_dep
branch
from
43f438f to
b4e2ee2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@stevekuznetsov this is required for openshift/origin#13585 to pass the
godep restoretest.Long story short... We are not going to build Origin with these libraries as CGO deps as we will have special build tag that will disable it.. However,
godepis stupid and it will try to compile thecontainers/imageswhich will result in compilation error and test failure...So.. this is only needed to fix that test. After this merge, I guess I will have to kick new base_ami build.