Change slightly#106
Open
yutaro-sakamoto wants to merge 7 commits intoopensourcecobol:developfrom
Open
Conversation
Contributor
yutaro-sakamoto
commented
Oct 4, 2023
yutaro-sakamoto
commented
- Remove define.h
- Fix CI
- Change README
GitMensch
suggested changes
Nov 6, 2023
Contributor
GitMensch
left a comment
GitMensch
left a comment
There was a problem hiding this comment.
I highly suggest to not get back to require the user to run autogen.sh and have the necessary tools installed.
Apart from the README* changes this looks good to me.
|
|
||
| Then run: | ||
|
|
||
| ./autogen.sh |
Contributor
There was a problem hiding this comment.
This would mean to suggest users to recreate everything - this really should only be done when checking out from version control, while "normal users" should be provided a distribution tarball where this isn't necessary.
Note: the distribution tarball can (and should) be made available in the CI runner as artifact, too.
Contributor
There was a problem hiding this comment.
dropping that unused file is definitely good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.