Clear the program stack when executing CANCEL ALL.#58
Merged
n-isaka merged 2 commits intoopensourcecobol:developfrom Aug 1, 2025
Merged
Clear the program stack when executing CANCEL ALL.#58n-isaka merged 2 commits intoopensourcecobol:developfrom
n-isaka merged 2 commits intoopensourcecobol:developfrom
Conversation
* Fixed the program stack list to be initialized every time CANCEL ALL is executed.
GitMensch
reviewed
Aug 1, 2025
GitMensch
left a comment
GitMensch
left a comment
There was a problem hiding this comment.
Looks good.
You may want to check for more issues (outside this PRs scope) using valgrind's memcheck.
libcob/call.c
Outdated
Comment on lines
300
to
301
| new_list->name = malloc (strlen (name) + 1); | ||
| strcpy (new_list->name, name); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CANCEL ALL実行時に内部で持っているプログラムスタック用のメモリが開放されないため、多くのプログラムを繰り返し実行すると、メモリ使用量とCANCEL処理完了までの時間が増大する不具合が見つかった。
このため、CANCEL ALLが実行されるたびに対象のスタックリストをクリアするように修正した。
When CANCEL ALL is executed, the memory used for the program stack is not released internally, so when many programs are executed repeatedly, a problem was found where memory usage and the time required to complete the CANCEL process increased.
Therefore, we have made a fix so that the target stack list is cleared each time CANCEL ALL is executed.