Fix Java code generation bugs in VALUE ALL literal initialization#790
Merged
yutaro-sakamoto merged 2 commits intoopensourcecobol:developfrom Feb 25, 2026
Merged
Conversation
* Fix Java code generation for VALUE ALL literal initialization * Fix missing dot in memcpy method call and resolve variable scope error where loop variable i0 was referenced outside the for loop.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes two bugs in the Java code generation for COBOL VALUE ALL literal initialization in the file cobj/codegen.c. The bugs were in the joutput_initialize_literal function, which generates Java code for initializing fields with literal values.
Changes:
- Fixed missing dot prefix in generated
.memcpy()method call (line 2216) - Fixed incorrect loop variable reference
i0being used outside of loop scope (line 2237)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yutaro-sakamoto
approved these changes
Feb 25, 2026
yutaro-sakamoto
merged commit a727fec
into
opensourcecobol:develop
305 of 306 checks passed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #785
This pull request makes minor adjustments to the code generation logic in
cobj/codegen.crelated to how thememcpyfunction is invoked in the generated output. The changes focus on correcting the syntax and parameters used for the.memcpycalls.Most important changes:
Code generation output corrections:
memcpy (to.memcpy (to ensure correct method invocation syntax in the output..memcpyin a loop, replacingi0 * %uwith%uwhere the value is now explicitly calculated as(i * l->size).