Skip to content

Make 3rd party unit tests log "PERKELE" instead of "FUCKOFF"#554

Open
martinpaljak wants to merge 1 commit intoopenssh:masterfrom
martinpaljak:base64-rewording
Open

Make 3rd party unit tests log "PERKELE" instead of "FUCKOFF"#554
martinpaljak wants to merge 1 commit intoopenssh:masterfrom
martinpaljak:base64-rewording

Conversation

@martinpaljak
Copy link

@martinpaljak martinpaljak commented Jan 20, 2025

I'm using this sample file as input to known_hosts parsing unit tests. I don't mind a bit of swearing but this Finnish word is a bit less direct than "FUCKOFF".

Reference: https://www.youtube.com/watch?v=g56Izmup9zw

I'm using this sample file as input to known hosts parsing unit tests.
I don't mind a bit of swearing but this Finnish word is a bit more
indirect than "FUCKOFF"
@djmdjm
Copy link
Contributor

djmdjm commented Feb 15, 2025

I don't understand - nothing in OpenSSH logs this string

@martinpaljak
Copy link
Author

martinpaljak commented Feb 15, 2025

@djmdjm in OpenSSH maybe not, but try this from the source tree root: tail -1 ./regress/unittests/hostkeys/testdata/known_hosts | awk '{print $3}' | base64 -d

I'd like to keep using the latest file from OpenSSH source tree as input for my tests, which does dump the failing data in unit tests for debugging reasons.

@pinacoelho
Copy link

Why should the Finns have all the fun ?

If the issue is the swearing, then change it to "GoAway", it's both easy to understand and not swearing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants