Skip to content

just small clean-up to use better names for functions#84

Merged
Sashan merged 1 commit intoopenssl:mainfrom
Sashan:ha-proxy.nits
Mar 8, 2026
Merged

just small clean-up to use better names for functions#84
Sashan merged 1 commit intoopenssl:mainfrom
Sashan:ha-proxy.nits

Conversation

@Sashan
Copy link
Contributor

@Sashan Sashan commented Mar 3, 2026

and veriables. Adding few comments to clarify code.

also let setup_tests() function to use ssl_libs_haproxy list of libraries to test. The list is defined in common_util.sh and used by bench_run_haproxy.sh script. The common list helps to maintain conistency.

@Sashan
Copy link
Contributor Author

Sashan commented Mar 3, 2026

note ha-proxy does not build with openssl-4.0 currently.

to test those changes you need to clone and modify the script to clone haproxy from repo here which contains unofficial workaround for openssl https://github.com/Sashan/haproxy (branch openssl-4.0)

git clone -b openssl-4.0 --depth 1 https://github.com/sashan/haproxy

@Sashan Sashan added the approval: review pending This pull request needs review by a committer label Mar 3, 2026
@Sashan Sashan moved this to Waiting Review in Development Board Mar 3, 2026
@Sashan Sashan requested a review from jogme March 3, 2026 20:56
Copy link
Contributor

@jogme jogme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@github-project-automation github-project-automation bot moved this from Waiting Review to Waiting Merge in Development Board Mar 4, 2026
and veriables. Adding few comments to clarify code.

also let setup_tests() function to use ssl_libs_haproxy
list of libraries to test. The list is defined in common_util.sh
and used by bench_run_haproxy.sh script. The common list
helps to maintain conistency.

Co-authored-by: Pocs Norbert <norbertpocs0@gmail.com>
@Sashan Sashan merged commit a7e290a into openssl:main Mar 8, 2026
35 checks passed
@github-project-automation github-project-automation bot moved this from Waiting Merge to Done in Development Board Mar 8, 2026
@Sashan Sashan deleted the ha-proxy.nits branch March 8, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval: review pending This pull request needs review by a committer

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants