Skip to content

Introduce common controller#348

Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
kstrenkova:refactor-controllers
Mar 26, 2026
Merged

Introduce common controller#348
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
kstrenkova:refactor-controllers

Conversation

@kstrenkova
Copy link
Copy Markdown
Contributor

To remove duplicate code across the test-operator controllers, this patch introduces a common controller. This change should make fixing controller bugs easier and prepare the test-operator for new resource addition, if it is needed in the future.

Assisted-by: Claude AI

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/adfde4fcd4304119bd34f1850e6865e3

openstack-k8s-operators-content-provider FAILURE in 8m 07s
⚠️ podified-multinode-edpm-deployment-crc-test-operator SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d88e72ae94b345839b13e9924a10f912

✔️ openstack-k8s-operators-content-provider SUCCESS in 27m 00s
podified-multinode-edpm-deployment-crc-test-operator RETRY_LIMIT in 11m 45s

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/500729983e5a4460b8eef76457b2d54f

openstack-k8s-operators-content-provider FAILURE in 8m 28s
⚠️ podified-multinode-edpm-deployment-crc-test-operator SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/308dd766cd8e431ab9626de71046829a

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 34m 29s
podified-multinode-edpm-deployment-crc-test-operator TIMED_OUT in 3h 18m 25s

@kstrenkova kstrenkova force-pushed the refactor-controllers branch 4 times, most recently from ba993e6 to fdb7757 Compare March 4, 2026 15:49
@kstrenkova
Copy link
Copy Markdown
Contributor Author

Hi @stuggi 👋 I have this big change to create a common controller structure to reduce duplication in the controllers for different resource types. I wanted to ask if you could take a look at it logic-wise or if you know someone that could help me with reviewing this. I plan to do more local testing for different parts of the code, but as the check job passes I think the main logic should work, so I wanted to get some eyes on it now. Thank you in advance 🙏

@kstrenkova kstrenkova marked this pull request as ready for review March 11, 2026 15:32
@openshift-ci openshift-ci bot requested review from arxcruz and sdatko March 11, 2026 15:33
@kstrenkova kstrenkova force-pushed the refactor-controllers branch 3 times, most recently from 39678bf to de2bbad Compare March 19, 2026 13:21
To remove duplicate code across the test-operator controllers,
this patch introduces a common controller. This change should make
fixing controller bugs easier and prepare the test-operator for
new resource addition, if it is needed in the future.
@kstrenkova kstrenkova force-pushed the refactor-controllers branch from de2bbad to 677d079 Compare March 19, 2026 13:45
@kstrenkova
Copy link
Copy Markdown
Contributor Author

The change is ready for review. I will keep the hold label until enough people review the code, as it is a big change.

@adrianfusco @belolipa @sauragar @imatza-rh Please take a look when you have time 🙏

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 25, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianfusco, kstrenkova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 42f48d1 into openstack-k8s-operators:main Mar 26, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants