Refactor minor inconsistencies#425
Merged
openshift-merge-bot[bot] merged 2 commits intoopenstack-k8s-operators:mainfrom Mar 18, 2026
Merged
Refactor minor inconsistencies#425openshift-merge-bot[bot] merged 2 commits intoopenstack-k8s-operators:mainfrom
openshift-merge-bot[bot] merged 2 commits intoopenstack-k8s-operators:mainfrom
Conversation
The test-operator code still has some minor inconsistencies that need a refactor. This change will later help with creating a common controller. It is also needed to make the changes more modular and not change them as a part of bigger refactor.
|
Skipping CI for Draft Pull Request. |
Tobiko and HorizonTest have special config-map handling that is called in the main reconcile loop. This would be difficult to combine when creating a common controller loop later. That is the reason for this change, that puts the config-map handling into its own function. Additionally, it correctly assigns ServiceConfigReady condition to config-map creations and makes sure enviroment variables are set only when config-maps are correctly created.
kstrenkova
force-pushed
the
small-refactor-changes
branch
from
1e38e1b to
5796943
Compare
adrianfusco
approved these changes
Mar 18, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianfusco, kstrenkova The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 0bd3d12
into
openstack-k8s-operators:main
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test-operator code still has some minor inconsistencies that need a refactor. This change will later help with creating a common controller. It is also needed to make the changes more modular and not change them as a part of bigger refactor.