Fix logger and move failure case#430
Merged
openshift-merge-bot[bot] merged 2 commits intoopenstack-k8s-operators:mainfrom Apr 1, 2026
Merged
Conversation
The common logger was not taking context into consideration and therefore it was not printing out logs the same way as other loggers. With this PR the common logger should now print logs correctly.
Move error handling directly after NextAction call instead of deferring it until later in the reconcile flow. This prevents executing unnecessary operations when NextAction has already failed.
Contributor
Author
|
/retest |
adrianfusco
approved these changes
Apr 1, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrianfusco, kstrenkova The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 51df3a4
into
openstack-k8s-operators:main
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The common logger was not taking context into consideration and therefore it was not printing out logs the same way as other loggers. With this PR the common logger should now print logs correctly.
Additionally, it moves error handling directly after NextAction call instead of deferring it until later in the reconcile flow. This prevents executing unnecessary operations when NextAction has already failed.