Skip to content

Remove the dependency on "debug" #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MikeNicholls wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove the dependency on "debug" #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions lib/apkreader/parser/binaryxml.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
/*eslint no-console: "off"*/

const assert = require('assert')
const debug = require('debug')('adb:apkreader:parser:binaryxml')

const NodeType = {
ELEMENT_NODE: 1,
Expand Down Expand Up @@ -314,7 +313,7 @@ class BinaryXmlParser {
break
default: {
const type = dataType.toString(16)
debug(`Not sure what to do with typed value of type 0x${type}, falling \
this.debug && console.debug(`Not sure what to do with typed value of type 0x${type}, falling \
back to reading an uint32.`)
typedValue.value = this.readU32()
typedValue.type = 'unknown'
Expand All @@ -326,7 +325,7 @@ back to reading an uint32.`)
if (this.cursor !== end) {
const type = dataType.toString(16)
const diff = end - this.cursor
debug(`Cursor is off by ${diff} bytes at ${this.cursor} at supposed end \
this.debug && console.debug(`Cursor is off by ${diff} bytes at ${this.cursor} at supposed end \
of typed value of type 0x${type}. The typed value started at offset ${start} \
and is supposed to end at offset ${end}. Ignoring the rest of the value.`)
this.cursor = end
Expand Down Expand Up @@ -661,7 +660,7 @@ and is supposed to end at offset ${end}. Ignoring the rest of the value.`)
if (this.cursor !== end) {
const diff = end - this.cursor
const type = header.chunkType.toString(16)
debug(`Cursor is off by ${diff} bytes at ${this.cursor} at supposed \
this.debug && console.debug(`Cursor is off by ${diff} bytes at ${this.cursor} at supposed \
end of chunk of type 0x${type}. The chunk started at offset ${start} and is \
supposed to end at offset ${end}. Ignoring the rest of the chunk.`)
this.cursor = end
Expand Down
4 changes: 0 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
},
"dependencies": {
"bluebird": "^3.4.7",
"debug": "~0.7.4",
"yauzl": "^2.7.0"
},
"engines": {
Expand Down