Fixed #9406: By treating aerialway=station as valid start/end point which suppresses the false warning #11675
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/end point which suppresses the false warning
k-yle
reviewed
Dec 16, 2025
| }).filter((pair) => { | ||
| // noname=no is double-negation, thus positive and not conflicting. We'll ignore those | ||
| return !((pair[0].match(/^(addr:)?no[a-z]/) && entity.tags[pair[0]] === 'no') || | ||
| (pair[1].match(/^(addr:)?no[a-z]/) && entity.tags[pair[1]] === 'no')); |
Collaborator
There was a problem hiding this comment.
these changes seem to be unrelated to the PR description. Are they meant to be a different git branch?
Contributor
Author
There was a problem hiding this comment.
Yeah I mistakenly worked on different issue on the same branch, my bad. I will fix it asap.
Razen04
force-pushed
the
footways-fix
branch
from
d8446da to
2acf322
Compare
k-yle
reviewed
Jan 5, 2026
Collaborator
There was a problem hiding this comment.
we have another preset, called Aerialway Stopping Location, which seems to be used in much the same way, and also seems to be a routing sink.
Should this logic apply to that tag as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, iD warns for paths which are not connected to any other route any is contained within a building like gondola stations which is a false positive. This has been explained in detail in Issue #9406.
Fix
The fix to this is simple, we just add an extra check in the
isConnectedVertexfunction to check if a vertex in the path hasaerialway=stationand returntruefor that, which means the path is valid to have start/end in the gandola station even if they are not connected to any other roads or highway(which they aren't supposed to).Fixes #9406
Before:
After the if statement:
References
This is similar to issue #3906 - which showed problems with foothpaths connecting two buildings.