-
Notifications
You must be signed in to change notification settings - Fork 332
fix(icons): add the third batch of icon-saas icons. #3889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
WalkthroughA new batch of icons (batch3Icons) is defined as an exported constant and integrated into two Vue gallery components, each rendering the new batch alongside existing icons using identical grid and click-handling logic. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
examples/sites/demos/pc/app/icon/advance-usage.vue (1)
53-74: Second icon gallery forbatch3Iconsmirrors existing behaviorThe new
<hr />plus second.svgs-wrappercorrectly reuses the same filter and click‑to‑copy behavior forbatch3Icons, so UX stays consistent across both batches.If you expect more batches later, consider extracting this repeated wrapper into a small reusable icon-grid component that takes the icon list as a prop.
examples/sites/demos/pc/app/icon/advance-usage-composition-api.vue (1)
53-74: Composition API gallery forbatch3Iconsmatches the first galleryThe added block renders
batch3Iconswith the same visibility filter and click handler asadvanceIcons, so behavior stays aligned between the two sections.Same as in the Options API demo, if more batches are added in future, you could factor this markup into a small reusable icon-grid component to reduce duplication.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (297)
packages/theme-saas/src/svgs-raw/IconAbnormalCheckIn.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAbnormalCheckInFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAcceptance.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAcceptanceFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconActivation.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconActivationFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAdministrator.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAdministratorFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAgendaView.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAgendaViewFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAnalyse.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAnalyseFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconApproval.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconApprovalFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAreaChart.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAreaChartFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconArrowDown.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconArrowDownFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconArrowLeft.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconArrowLeftFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconArrowRight.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconArrowRightFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconArrowUp.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconArrowUpFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAscending.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAscendingFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAskForLeave.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAskForLeaveFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAssociation.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAssociationFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAttachment.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAttachmentFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAudio.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAudioFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAudit.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAuditFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAutomaticAssessment.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconAutomaticAssessmentFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconBank.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconBankFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconBarChart.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconBarChartFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconBatchFill.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconBatchFillFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconBefilter.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconBefilterFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconBoat.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconBoatFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCalculator.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCalculatorFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCalendar.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCalendarFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCancellationApplication.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCancellationApplicationFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCardModeline.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCardModelineFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCheck.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCheckFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCheckOut.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCheckOutFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCheckProperties.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCheckPropertiesFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCheckedLinear.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCheckedLinearFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconChevronDown.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconChevronDownFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconChevronLeft.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconChevronLeftFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconChevronRight.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconChevronRightFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconChevronUp.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconChevronUpFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconClearFilter.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconClearFilterFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconClockWork.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconClockWorkFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconClose.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCloseCircle.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCloseCircleFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCloseFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCloseSquare.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCloseSquareFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCloudDownload.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCloudDownloadFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCoin.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCoinFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCommission.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCommissionFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCompany.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCompanyFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconComputingJob.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconComputingJobFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconConfirmPayrollProfile.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconConfirmPayrollProfileFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconConmentRefresh.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconConmentRefreshFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconConnectSquare.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconConnectSquareFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCopy.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCopyFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCourse.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCourseFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCrop.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCropFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCrossOrganizationWarehousingList.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCrossOrganizationWarehousingListFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCueL.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCueLFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCurrency.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCurrencyFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCustom.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCustomFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCustomSclearance.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCustomSclearanceFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCustomerService.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCustomerServiceFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCustomsClearanceForm.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCustomsClearanceFormFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCustomsDeclaration.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCustomsDeclarationFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCustomsDeclarationList.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconCustomsDeclarationListFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDailyVisits.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDailyVisitsFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDefault.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDefaultFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDefinedFiltration.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDefinedFiltrationFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDefinitionOfProcessRoles.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDefinitionOfProcessRolesFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDelegatedProcessing.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDelegatedProcessingFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDeletePage.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDeletePageFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDeleted.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDeletedFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDeltaDownO.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDeltaDownOFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDeltaLeftO.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDeltaLeftOFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDeltaRightO.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDeltaRightOFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDeltaUpO.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDeltaUpOFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDemandOrderList.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDemandOrderListFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDescending.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDescendingFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDetailedList.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDetailedListFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDetailsPage.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDetailsPageFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDialog.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDialogFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDigitalassistant.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDigitalassistantFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDisallowance.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDisallowanceFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDotChart.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDotChartFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDotIpv4.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDotIpv4Filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDoubleLeft.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDoubleLeftFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDoubleRight.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDoubleRightFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDownload.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDownloadCloud.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDownloadCloudFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDownloadFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDrawFlowchart.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconDrawFlowchartFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEarthLined.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEarthLinedFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEdit.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorAlignCenter.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorAlignCenterFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorAlignLeft.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorAlignLeftFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorAlignRight.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorAlignRightFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorBold.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorBoldFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorCode.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorCodeFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorDeleteline.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorDeletelineFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorEraser.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorEraserFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorItalic.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorItalicFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorLeftBorder.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorLeftBorderFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorListDot.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorListDotFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorListNum.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorListNumFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorMenuLeft.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorMenuLeftFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorMenuRight.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorMenuRightFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorQuote.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorQuoteFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorRedo.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorRedoFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorRightBorder.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorRightBorderFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorSub.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorSubFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorSubtitle.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorSubtitleFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorSuper.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorSuperFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorTable.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorTableFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorTextcolor.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorTextcolorFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorTitle.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorTitleFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorUnderline.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorUnderlineFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorUndo.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorUndoFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorVideo.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEditorVideoFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEllipsis.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEllipsisFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEmailAdd.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEmailAddFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEmailCircle.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEmailCircleFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEmployeeInformation.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEmployeeInformationFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEnd.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEndFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEngineWorkflow.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEngineWorkflowFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEquipment.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEquipmentFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEspaceAuto.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEspaceAutoFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconExcelType.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconExcelTypeFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconException.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconExceptionFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconExchangerate.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconExchangerateFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconExecutionPhase.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconExecutionPhaseFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconExhibitionForum.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconExhibitionForumFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconExport.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconExportFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconExpressSearch.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconExpressSearchFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEyeclose.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEyecloseFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEyeopen.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconEyeopenFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFastCode.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFastCodeFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFemale.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFemaleFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFile.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFileCloudupload.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFileClouduploadFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFileExcel.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFileExcelFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFileFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFileType.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFileTypeFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFilesCircle.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFilesCircleFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFiletext.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFiletextFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFileupload.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFileuploadFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFiltered.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFilteredFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFlag.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFlagFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFolderClosed.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFolderClosedFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFreezeLeft.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFreezeLeftFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFreezeRight.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFreezeRightFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFrownO.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFrownOFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFullscreen.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFullscreenFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFullscreenLeft.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconFullscreenLeftFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconGeneralAi.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconGeneralAiFilled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs-raw/IconGeneralPageIndigo.svgis excluded by!**/*.svg
📒 Files selected for processing (3)
examples/sites/demos/pc/app/icon/advance-icons.js(1 hunks)examples/sites/demos/pc/app/icon/advance-usage-composition-api.vue(1 hunks)examples/sites/demos/pc/app/icon/advance-usage.vue(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (3)
examples/sites/demos/pc/app/icon/advance-icons.js (1)
288-412: Verify icon names added inbatch3IconsThe new
batch3Iconsexport is structurally consistent withadvanceIcons, and wiring it into the demos should work as expected. To avoid silent missing icons, it’s worth quickly confirming that every string matches a real entry onSvgs—a few likeIconInventoryLlist,IconPnventoryDiscrepancyAdjustmentList,IconCustomSclearance,IconPeography,IconPirplanelook like they might contain typos.examples/sites/demos/pc/app/icon/advance-usage.vue (1)
90-107: Import and data wiring forbatch3Iconsis consistentImporting
batch3IconsalongsideadvanceIconsand exposing it viadata()keeps the Options API component consistent with the existing pattern and correctly backs the new gallery.examples/sites/demos/pc/app/icon/advance-usage-composition-api.vue (1)
81-81:batch3Iconsimport is correctly exposed to the templateAdding
batch3Iconsto the named import works cleanly with<script setup>—the template can use bothadvanceIconsandbatch3Iconswithout additional boilerplate.
PR
新增第三批icon-saas图标 ------------- 需要发runtime, 杨
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.