Skip to content

Example project: Require django<2 #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bj00rn wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Example project: Require django<2 #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1a0f3d
require django<2 due to middleware changes as of django 2.0
bj00rn Jun 25, 2019
49ced05
add note to install dependencies
bj00rn Jun 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion example/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,13 @@

This is an example of a Django site with tracing implemented using the django_opentracing package. To run the example, make sure you've installed package `opentracing` and the `Tracer` of your choice (Jaeger, LightStep, etc).

Navigate to this directory and then run:
Navigate to this directory and install requirements:

```
> pip install -r requirements.txt
```

Run the server:
```
> python manage.py runserver 8000
```
Expand Down
2 changes: 2 additions & 0 deletions example/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Django<2
Copy link

@Jamim Jamim Jun 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of this PR is Example project: Require django>2, but here I see Django<2 🤔

Copy link
Author

@bj00rn bj00rn Jun 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, fixed typos in title and commits 😭.

need to get my 🐊s straight

django_opentracing