New features: Cabin temperature, AC status. Climate control button..#26
Open
mjuhanne wants to merge 2 commits intoopenvehicles:masterfrom
Open
New features: Cabin temperature, AC status. Climate control button..#26mjuhanne wants to merge 2 commits intoopenvehicles:masterfrom
mjuhanne wants to merge 2 commits intoopenvehicles:masterfrom
Conversation
- Do not require tire temperature in order to show tire pressure - Do not show temperatures as stale if cooling pump is inactive
Member
|
I think it looks ok. Please add the iPad storyboard, as I have some work to do here, and it makes sense to get this merged in at the same time. |
Member
|
Some conflicts here, as the storyboards have been changed. Please resolve and re-submit. |
|
The IOS app does not show the status of the CLIMATISATION. This is the feature to preheat or precool the cabin.. The OVSM command „xse charge hh mm“ will set the departure time for the climatisation and could preferably be SET or displayed in the app as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.. and few other changes.
These changes didn't require any modification to the server protocol (Cabin temp, HVAC status and ClimateControl are already there), although I would like to have a more fine-grained AC status (i.e. Starting, Started, Stopping, Stopped, Error..) in the future.
The demo vehicle shows "-127C" at this time (I didn't yet find out where the defaults for temperatures and tire pressures are set up), but for actual vehicle it reports it correctly.
Let me know how this looks, and if OK, then I can modify the iPad storyboard also (only iPhone done now).