This repository was archived by the owner on Apr 17, 2023. It is now read-only.
Draft
Conversation
druzhkov-paul
approved these changes
Dec 16, 2021
LeonidBeynenson
suggested changes
Dec 20, 2021
tests/test_ote_api.py
Outdated
Comment on lines
226
to
229
| if os.getenv("CUDA_VISIBLE_DEVICES") == "": | ||
| self.assertLess(time.time() - start_time, 400, 'Expected to stop within 400 seconds.') | ||
| else: | ||
| self.assertLess(time.time() - start_time, 100, 'Expected to stop within 100 seconds.') |
There was a problem hiding this comment.
2 @aiarkinx : I propose to do as follows
if os.getenv("CUDA_VISIBLE_DEVICES") == "":
timeout = 400
else:
timeout = 100
self.assertLess(time.time() - start_time, timeout, f'Expected to stop within {timeout} seconds.')(please, do not move complicated code inside if - then - else clause if it is possible to move only one variable into it.)
tests/test_ote_api.py
Outdated
| if os.getenv("CUDA_VISIBLE_DEVICES") == "": | ||
| self.assertLess(time.time() - start_time, 400) | ||
| else: | ||
| self.assertLess(time.time() - start_time, 25) # stopping process has to happen in less than 25 seconds |
There was a problem hiding this comment.
Make the same changes related timeout variable as I wrote above
|
@LeonidBeynenson Please review once again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix for run tests on CPU