[fix] Load charts using dashboard domain by Adityashandilya555 · Pull Request #528 · openwisp/docker-openwisp

Adityashandilya555 · 2025-10-26T06:12:28Z

Checklist

I have read the OpenWISP Contributing Guidelines.
I have manually tested the changes proposed in this pull request.
I have written new test cases for new code and/or updated existing tests for changes to existing code.
I have updated the documentation.

Reference to Existing Issue

Closes #526.

Description of Changes

Added DASHBOARD_BASEURL configuration variable using dashboard domain
Changed OPENWISP_MONITORING_API_BASEURL to use DASHBOARD_BASEURL instead of API_BASEURL
Chart loading now uses the same domain as the dashboard interface

Screenshot

Please include any relevant screenshots.

…p#477 Replaced archived django-celery-email with actively maintained django-post-office for async email handling. - Updated requirements.txt: django-celery-email -> django-post-office - Changed email backend configuration in Dockerfile - Updated settings.py to use post_office app conditionally Fixes openwisp#477

…penwisp#477 The archived django-celery-email package has been replaced with django-celery-email-reboot, a maintained fork that provides Django 4.x/5.x compatibility. This is a drop-in replacement with identical API. Changes: - Updated requirements.txt to use django-celery-email-reboot>=4.1.0,<5.0.0 - Changed EMAIL_BACKEND to djcelery_email.backends.CeleryEmailBackend - Updated settings.py to check for djcelery_email backend Testing performed following maintainer's approach: - Built all Docker images successfully with django-celery-email-reboot 4.1.0 - Tested email flow: docker compose run dashboard python manage.py sendtestemail - Verified postfix logs showing successful email pipeline: Django → Celery → Postfix (queue ID 95C4120370E8) - Email queued and delivery attempted successfully The entire email pipeline is working correctly with the new package. Fixes openwisp#477

This change addresses issue openwisp#526 by making monitoring charts load from the dashboard domain instead of the API domain. This prevents SSL certificate issues that can confuse new users when the API domain doesn't have a trusted certificate. Changes: - Added DASHBOARD_BASEURL configuration variable - Changed OPENWISP_MONITORING_API_BASEURL to use dashboard domain - Chart loading now uses the same domain as the dashboard interface Fixes openwisp#526

nemesifier

@Adityashandilya555

nemesifier · 2025-12-19T16:49:50Z

images/openwisp_dashboard/module_settings.py

 OPENWISP_NOTIFICATIONS_HOST = API_BASEURL
 OPENWISP_CONTROLLER_API_HOST = API_BASEURL
-OPENWISP_MONITORING_API_BASEURL = API_BASEURL
+OPENWISP_MONITORING_API_BASEURL = DASHBOARD_BASEURL


Would removing OPENWISP_MONITORING_API_BASEURL completely work?

Yes, removing OPENWISP_MONITORING_API_BASEURL completely should work. I checked the openwisp-monitoring source and the default value is None, which means the charts will use relative URLs and load from the current domain (the dashboard domain).

Let's do that then and simplify this. This way we don't need to define DASHBOARD_BASEURL.
Keep it simple. Please do manual testing to ensure the approach work and record a video showing the result.

requirements-test.txt

nemesifier · 2025-12-24T08:54:37Z

images/openwisp_dashboard/module_settings.py

 OPENWISP_NOTIFICATIONS_HOST = API_BASEURL
 OPENWISP_CONTROLLER_API_HOST = API_BASEURL
-OPENWISP_MONITORING_API_BASEURL = API_BASEURL
+OPENWISP_MONITORING_API_BASEURL = DASHBOARD_BASEURL


Let's do that then and simplify this. This way we don't need to define DASHBOARD_BASEURL.
Keep it simple. Please do manual testing to ensure the approach work and record a video showing the result.

nemesifier · 2026-01-12T22:00:03Z

@Adityashandilya555 ping

coderabbitai · 2026-01-13T04:07:02Z

Walkthrough

Removed the OPENWISP_MONITORING_API_BASEURL variable from images/openwisp_dashboard/module_settings.py; no other configuration lines were changed. The file no longer exposes a public setting that assigned the monitoring API base URL to API_BASEURL.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title '[fix] Load charts using dashboard domain' clearly summarizes the main change: using the dashboard domain for chart loading instead of the API domain.
Description check	✅ Passed	The PR description covers all required template sections: checklist completion, linked issue reference (#526), and detailed description of changes with a screenshot.
Linked Issues check	✅ Passed	The PR successfully addresses issue #526's objective to load charts using the dashboard domain instead of the API domain to avoid SSL certificate failures.
Out of Scope Changes check	✅ Passed	The code change (removing OPENWISP_MONITORING_API_BASEURL assignment) is directly in scope with the objective to change chart loading to use the dashboard domain instead of the API domain.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9990783 and 4105107.

📒 Files selected for processing (1)

images/openwisp_dashboard/module_settings.py

💤 Files with no reviewable changes (1)

images/openwisp_dashboard/module_settings.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: CI Build

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Adityashandilya555 · 2026-01-13T04:16:08Z

@Adityashandilya555 ping
@nemesifier my apologies i had a viral fever for 10 days will send you video by todsy

Adityashandilya555 · 2026-01-13T06:39:59Z

Change.Device._.OpenWISP.Admin.1.mp4

Removed OPENWISP_MONITORING_API_BASEURL so that monitoring charts use relative URLs and load from the dashboard domain. This fixes SSL certificate issues for users without trusted certs on the API domain. Closes openwisp#526

Adityashandilya555 and others added 8 commits October 4, 2025 09:15

Merge branch 'master' into issues/477-migrate-django-celery-email

35d7e8e

Merge branch 'master' into issues/477-migrate-django-celery-email

3077748

Merge branch 'master' into issues/477-migrate-django-celery-email

68ee23e

Merge branch 'master' into fix/chart-loading-use-dashboard-domain

39b7131

Merge branch 'master' into fix/chart-loading-use-dashboard-domain

ef44967

pandafy added this to OpenWISP Contributor's Board Nov 3, 2025

github-project-automation bot moved this to To do (general) in OpenWISP Contributor's Board Nov 3, 2025

pandafy moved this from To do (general) to Needs review in OpenWISP Contributor's Board Nov 3, 2025

pandafy moved this from Needs review to In progress in OpenWISP Contributor's Board Nov 3, 2025

Adityashandilya555 and others added 4 commits November 5, 2025 20:22

Merge branch 'master' into fix/chart-loading-use-dashboard-domain

5ec703d

Merge branch 'master' into fix/chart-loading-use-dashboard-domain

e2546cb

[qa] Fix RST formatting

5734605

[deps] Pin sphinx<8.0.0 for docstrfmt compatibility

8cb14af

Adityashandilya555 force-pushed the fix/chart-loading-use-dashboard-domain branch from f063d92 to 8cb14af Compare December 9, 2025 10:43

Merge branch 'master' into fix/chart-loading-use-dashboard-domain

ee0055e

nemesifier reviewed Dec 19, 2025

View reviewed changes

requirements-test.txt Outdated Show resolved Hide resolved

nemesifier changed the title ~~Fix/chart loading use dashboard domain~~ [fix] Load charts use dashboard domain Dec 19, 2025

nemesifier changed the title ~~[fix] Load charts use dashboard domain~~ [fix] Load charts using dashboard domain Dec 19, 2025

Merge branch 'master' into fix/chart-loading-use-dashboard-domain

a21271c

nemesifier assigned Adityashandilya555 Dec 24, 2025

nemesifier requested changes Dec 24, 2025

View reviewed changes

Merge branch 'master' into fix/chart-loading-use-dashboard-domain

05c9296

Adityashandilya555 force-pushed the fix/chart-loading-use-dashboard-domain branch from 9990783 to 4105107 Compare January 13, 2026 06:41

Adityashandilya555 requested a review from nemesifier January 13, 2026 07:25

coderabbitai bot approved these changes Jan 24, 2026

View reviewed changes

Merge branch 'master' into fix/chart-loading-use-dashboard-domain

f54a5c1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[fix] Load charts using dashboard domain#528

[fix] Load charts using dashboard domain#528
Adityashandilya555 wants to merge 17 commits intoopenwisp:masterfrom
Adityashandilya555:fix/chart-loading-use-dashboard-domain

Adityashandilya555 commented Oct 26, 2025 •

edited

Loading

Uh oh!

nemesifier left a comment

Uh oh!

nemesifier Dec 19, 2025

Uh oh!

Adityashandilya555 Dec 24, 2025

Uh oh!

nemesifier Dec 24, 2025

Uh oh!

Uh oh!

nemesifier Dec 24, 2025

Uh oh!

nemesifier commented Jan 12, 2026

Uh oh!

coderabbitai bot commented Jan 13, 2026 •

edited

Loading

Uh oh!

Adityashandilya555 commented Jan 13, 2026

Uh oh!

Adityashandilya555 commented Jan 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Adityashandilya555 commented Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Reference to Existing Issue

Description of Changes

Screenshot

Uh oh!

nemesifier left a comment

Choose a reason for hiding this comment

Uh oh!

nemesifier Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Adityashandilya555 Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

nemesifier Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nemesifier Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

nemesifier commented Jan 12, 2026

Uh oh!

coderabbitai bot commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Uh oh!

Adityashandilya555 commented Jan 13, 2026

Uh oh!

Adityashandilya555 commented Jan 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Adityashandilya555 commented Oct 26, 2025 •

edited

Loading

coderabbitai bot commented Jan 13, 2026 •

edited

Loading