-
Notifications
You must be signed in to change notification settings - Fork 31
ts refactor #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
ts refactor #168
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f16c01b
Switch to TypeScript project references
jamescmartinez e9b7cdb
Clean up "development" imports
jamescmartinez 9cccce5
Switch benchmarks and examples to use ts project references
jamescmartinez 386bc4e
Remove rootDir from tsconfigs
jamescmartinez 9220391
Remove outDir from base tsconfig
jamescmartinez 77f99e6
Remove test files from tsconfig exclusion
jamescmartinez b17908e
Add ts project references doc link
jamescmartinez b0fa7b7
Add project-wide settings to root tsconfig
jamescmartinez f3a3597
Set dashboard tsconfig to noEmit to resolve TS6310
jamescmartinez 7fe12f6
Add dist outDir/exclude to project tsconfig
jamescmartinez 8c3706f
Add tsconfig.test.json for references workaround
jamescmartinez 8286045
Disable allowImportingTsExtensions in dashboard tsconfig
jamescmartinez 0cdeaff
Include openworkflow package tests in root tsconfig
jamescmartinez c9226dd
Add exclusion for test suite files in coverage configuration
jamescmartinez 7b06f13
Remove include and exclude from base tsconfig
jamescmartinez fc098d7
build before lint
jamescmartinez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,7 +1,6 @@ | ||||||
| { | ||||||
| "extends": ["../../tsconfig.json"], | ||||||
| "extends": "../../tsconfig.base.json", | ||||||
|
||||||
| "extends": "../../tsconfig.base.json", | |
| "extends": ["../../tsconfig.base.json"], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,7 +1,6 @@ | ||||||
| { | ||||||
| "extends": ["../../tsconfig.json"], | ||||||
| "extends": "../../tsconfig.base.json", | ||||||
|
||||||
| "extends": "../../tsconfig.base.json", | |
| "extends": ["../../tsconfig.base.json"], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,7 +1,6 @@ | ||||||
| { | ||||||
| "extends": ["../../tsconfig.json"], | ||||||
| "extends": "../../tsconfig.base.json", | ||||||
|
||||||
| "extends": "../../tsconfig.base.json", | |
| "extends": ["../../tsconfig.base.json"], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,7 +1,7 @@ | ||||||
| { | ||||||
| "extends": "../../tsconfig.json", | ||||||
| "extends": "../../tsconfig.base.json", | ||||||
|
||||||
| "extends": "../../tsconfig.base.json", | |
| "extends": ["../../tsconfig.base.json"], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| { | ||
| "extends": ["../../tsconfig.json"], | ||
| "extends": ["../../tsconfig.base.json"], | ||
| "compilerOptions": { | ||
| "rootDir": ".", | ||
| "outDir": "dist" | ||
| }, | ||
| "references": [{ "path": "../openworkflow" }], | ||
| "include": ["**/*.ts"], | ||
| "exclude": ["dist"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,9 +1,9 @@ | ||||||
| { | ||||||
| "extends": ["../../tsconfig.json"], | ||||||
| "extends": "../../tsconfig.base.json", | ||||||
|
||||||
| "extends": "../../tsconfig.base.json", | |
| "extends": ["../../tsconfig.base.json"], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,9 +1,9 @@ | ||||||
| { | ||||||
| "extends": ["../../tsconfig.json"], | ||||||
| "extends": "../../tsconfig.base.json", | ||||||
|
||||||
| "extends": "../../tsconfig.base.json", | |
| "extends": ["../../tsconfig.base.json"], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,9 +1,9 @@ | ||||||
| { | ||||||
| "extends": ["../../tsconfig.json"], | ||||||
| "extends": "../../tsconfig.base.json", | ||||||
|
||||||
| "extends": "../../tsconfig.base.json", | |
| "extends": ["../../tsconfig.base.json"], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,17 @@ | ||
| { | ||
| "extends": [ | ||
| "../../tsconfig.json", | ||
| "../../tsconfig.base.json", | ||
| "@tsconfig/vite-react/tsconfig.json" // https://www.npmjs.com/package/@tsconfig/vite-react | ||
| ], | ||
| "compilerOptions": { | ||
| "noEmit": false, // TS6310 | ||
| "allowImportingTsExtensions": false, // TS5096, caused by disabling noEmit | ||
| "types": ["vite/client"], | ||
| "paths": { | ||
| "@/*": ["./src/*"] | ||
| } | ||
| }, | ||
| "references": [{ "path": "../cli" }, { "path": "../openworkflow" }], | ||
| "include": ["**/*.ts", "**/*.tsx"], | ||
| "exclude": ["dist"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,11 @@ | ||
| { | ||
| "extends": ["../../tsconfig.json"], | ||
| "extends": ["../../tsconfig.base.json"], | ||
| "compilerOptions": { | ||
| "rootDir": ".", | ||
| "outDir": "dist" | ||
| }, | ||
| "include": ["**/*.ts"], | ||
| "exclude": ["**/*.test.ts", "dist"] | ||
| "exclude": [ | ||
| "dist", | ||
| "**/*.test.ts" // see note in ./tsconfig.test.json | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| // this config is a workaround to add backend-postgres as a reference for our | ||
| // test files without a circular reference in the main tsconfig.json | ||
| { | ||
| "extends": ["./tsconfig.json"], | ||
| "compilerOptions": { | ||
| "outDir": "dist" | ||
| }, | ||
| "references": [{ "path": "." }, { "path": "../backend-postgres" }], | ||
| "include": ["**/*.test.ts"], | ||
| "exclude": ["dist"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "extends": [ | ||
| "@tsconfig/strictest/tsconfig.json", // https://www.npmjs.com/package/@tsconfig/strictest | ||
| "@tsconfig/node22/tsconfig.json" // https://www.npmjs.com/package/@tsconfig/node22 | ||
| ], | ||
| "compilerOptions": { | ||
| "composite": true, | ||
| "declaration": true, | ||
| "sourceMap": true, | ||
| "declarationMap": true | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,29 @@ | ||
| { | ||
| "extends": [ | ||
| "@tsconfig/strictest/tsconfig.json", // https://www.npmjs.com/package/@tsconfig/strictest | ||
| "@tsconfig/node22/tsconfig.json" // https://www.npmjs.com/package/@tsconfig/node22 | ||
| // https://www.typescriptlang.org/docs/handbook/project-references.html#overall-structure | ||
| "files": [], | ||
| "references": [ | ||
| { "path": "./benchmarks/basic" }, | ||
| { "path": "./examples/basic" }, | ||
| { "path": "./examples/declare-workflow" }, | ||
| { "path": "./examples/with-schema-validation" }, | ||
| { "path": "./examples/workflow-discovery" }, | ||
| { "path": "./packages/openworkflow" }, | ||
| { "path": "./packages/backend-postgres" }, | ||
| { "path": "./packages/backend-sqlite" }, | ||
| { "path": "./packages/backend-test" }, | ||
| { "path": "./packages/cli" }, | ||
| { "path": "./packages/dashboard" } | ||
| ], | ||
| "compilerOptions": { | ||
| "rootDir": ".", | ||
| "outDir": "dist", | ||
| "customConditions": ["development"], | ||
|
|
||
| "composite": true, | ||
| "declaration": true, | ||
| "sourceMap": true, | ||
| "declarationMap": true | ||
| // project-wide settings for configs, workflows, etc. | ||
| "extends": "./tsconfig.base.json", | ||
| "compilerOptions": { | ||
| "outDir": "dist" | ||
| }, | ||
| "include": ["**/*.ts"], | ||
|
|
||
| // temporary - run `npm run typecheck` from the package root until we migrate | ||
| // our typechecks over to turbo | ||
| "exclude": ["packages/dashboard", "dist"] | ||
| "include": [ | ||
| "openworkflow/**/*.ts", | ||
| "*.config.ts", | ||
| "packages/openworkflow/**/*.test.ts" // needed to work with packages/openworkflow/tsconfig.test.json | ||
| ], | ||
| "exclude": ["dist"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent format for "extends" field across the project. Some tsconfig files use a string format while others use an array format. For consistency, consider using the same format across all tsconfig files (preferably array format to allow for easier future additions).