Skip to content

[#73354] add deletion confirmation dialog for page links#23193

Draft
Kharonus wants to merge 7 commits into
devfrom
implementation/73354-add-deletion-action-to-wiki-page-link
Draft

[#73354] add deletion confirmation dialog for page links#23193
Kharonus wants to merge 7 commits into
devfrom
implementation/73354-add-deletion-action-to-wiki-page-link

Conversation

@Kharonus
Copy link
Copy Markdown
Member

@Kharonus Kharonus commented May 13, 2026

Ticket

73354

What are you trying to accomplish?

  • added workflow of deleting relation page links
  • show confirmation dialog on click and call deletion action on submitting the dialog
  • ⚠️ Actual deletion not yet triggered, this PR is for introducing the deletion dialog and the corresponsing controllers, data and routes. Those are now up for discussion.

What approach did you choose and why?

  • add confirmation dialog component
  • add delete action and controller
  • add action to permission
  • add page link data to page info object
  • add additional routes

Hint

This PR is based on #23142, so the changes of the other still polutes the diff. Please review and merge the other first.

The major focus of this PR and the discussion involed is:

  • page info object now includes an optional page link reference. Reasoning here is, that page info is used as a view model for the page link representations in the UI - among other uses. Especially for the deletion data of the page link entity is needed (own id, wp and project reference for constructing the correct route).
    • one additional thought: should the page_link_component validate the input it gets? e.g. if there an action refined :remove, but the page info does not contain a page link entity, should we raise a meaningful message?
  • controller and route naming - are we fine with dedicated, focused controllers, i.e. separating the macro controller from the controller managing the relation page links of the wiki tab.
  • test coverage: this PR mostly contains UI and connection logic (permissions, actions, routes, etc.). Are any component/unit tests needed here?

@Kharonus Kharonus requested a review from a team May 13, 2026 13:17
@Kharonus Kharonus self-assigned this May 13, 2026
- https://community.openproject.org/work_packages/73354
- add confirmation dialog component
- add delete action and controller
- add action to permission
- add page link data to page info object
- add additional routes
- NOT ADDED: deletion service
@Kharonus Kharonus force-pushed the implementation/73354-add-deletion-action-to-wiki-page-link branch from 6ad6a9e to 75a9c95 Compare May 13, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant