[#73354] add deletion confirmation dialog for page links#23193
Draft
Kharonus wants to merge 7 commits into
Draft
[#73354] add deletion confirmation dialog for page links#23193Kharonus wants to merge 7 commits into
Kharonus wants to merge 7 commits into
Conversation
- https://community.openproject.org/work_packages/74710 - show page link as turbo frame - add route for loading the macro - update ckeditor build
- remove unused code
…to implementation/73354-add-deletion-action-to-wiki-page-link
- https://community.openproject.org/work_packages/73354 - add confirmation dialog component - add delete action and controller - add action to permission - add page link data to page info object - add additional routes - NOT ADDED: deletion service
6ad6a9e to
75a9c95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
73354
What are you trying to accomplish?
What approach did you choose and why?
Hint
This PR is based on #23142, so the changes of the other still polutes the diff. Please review and merge the other first.
The major focus of this PR and the discussion involed is:
page_link_componentvalidate the input it gets? e.g. if there an action refined:remove, but the page info does not contain a page link entity, should we raise a meaningful message?