Extract semantic project identifier regex into a composed constant#23197
Merged
Conversation
The [A-Z][A-Z0-9_]* shape that defines a semantic project identifier appears in three places that each redefine it inline: the validator's body check, the work-package semantic-id pattern composed into the route constraint, and the wiki reverse-link parser. Lift the unanchored shape to Projects::Identifier::SEMANTIC_FORMAT and have WorkPackage::SemanticIdentifier::SEMANTIC_ID_PATTERN compose from it via .source, with ID_ROUTE_CONSTRAINT in turn composing from that. The validator keeps its own anchored start/body patterns because each pattern produces a distinct error message — composing the two from SEMANTIC_FORMAT would obscure that contract. Split out of #22976 so #23186 can introduce its CLASSIC_IDENTIFIER_CHARS counterpart without conflicting with the larger feature PR.
akabiru
force-pushed
the
refactor/extract-semantic-project-identifier-format
branch
from
b264708 to
741aea9
Compare
This was referenced May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #22976 at the reviewer's request so #23186 can land its symmetric
CLASSIC_IDENTIFIER_CHARSrefactor without waiting on the larger feature PR.