Skip to content

[WIP] [WIP] Address feedback on semantic identifiers and classic-mode lookup regression#23222

Closed
Copilot wants to merge 1 commit into
feature/text-macro-semantic-id-renderingfrom
copilot/sub-pr-23203
Closed

[WIP] [WIP] Address feedback on semantic identifiers and classic-mode lookup regression#23222
Copilot wants to merge 1 commit into
feature/text-macro-semantic-id-renderingfrom
copilot/sub-pr-23203

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 15, 2026

Thanks for the feedback on #23203. I've created this new PR, which merges into #23203, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.

Original PR: #23203
Triggering review: #23203 (comment)

@copilot you're right that the classic-mode lookup regresses what the prior cache short-circuited. The structural fix is in the stacked follow-up #23221, which restores the per-render preload: with_preloaded_resources returns before priming the lookup unless semantic mode is active, so work_package_for yields nil in classic mode and the handler renders from fallback_id without any SELECT. The classic-mode spec at work_packages_spec.rb:125 pins this with expect(wp_selects).to be_empty.

@akabiru
Copy link
Copy Markdown
Member

akabiru commented May 15, 2026

Already done!

@akabiru akabiru closed this May 15, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators May 15, 2026
Copilot AI requested a review from akabiru May 15, 2026 07:43
Copilot stopped work on behalf of akabiru due to an error May 15, 2026 07:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants