Skip to content

Conversation

@ogenstad
Copy link
Contributor

@ogenstad ogenstad commented Dec 30, 2025

Summary by CodeRabbit

  • Chores
    • Updated development tooling dependencies.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 30, 2025

Walkthrough

This pull request contains two changes: the first refactors file reading in infrahub_sdk/schema/repository.py by replacing an explicit file context manager with the Path.read_text(encoding="UTF-8") method in the InfrahubRepositoryGraphQLConfig.load_query function. The second change updates the Ruff linting tool dependency version from 0.14.5 to 0.14.10 in the pyproject.toml tests dependency group. No functional logic or error handling modifications are introduced by these changes.

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects both main changes: upgrading Ruff to 0.14.10 and fixing a violation caused by the upgrade, which aligns with the file modifications shown (pyproject.toml update and schema/repository.py fix).

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 25ead97 and 627bae0.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • infrahub_sdk/schema/repository.py
  • pyproject.toml
🧰 Additional context used
📓 Path-based instructions (2)
**/*.py

📄 CodeRabbit inference engine (AGENTS.md)

**/*.py: Use type hints on all function signatures
Never mix async/sync inappropriately
Never bypass type checking without justification

Files:

  • infrahub_sdk/schema/repository.py
infrahub_sdk/**/*.py

📄 CodeRabbit inference engine (AGENTS.md)

Follow async/sync dual pattern for new features in the Python SDK

Files:

  • infrahub_sdk/schema/repository.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Cloudflare Pages
🔇 Additional comments (2)
infrahub_sdk/schema/repository.py (1)

152-154: LGTM! Cleaner, more idiomatic file reading.

The refactor to use Path.read_text(encoding="UTF-8") is an improvement. It's more concise, Pythonic, and addresses the new Ruff violation while maintaining identical functionality and error handling behavior.

pyproject.toml (1)

83-83: Verify Ruff version 0.14.10 availability on PyPI.

The requested version 0.14.10 does not appear in the current PyPI registry (only versions up to 0.14.9 are listed). Web sources indicate a potential release date of Dec 18, 2025, but this needs confirmation that the version is actually published and available for installation. Ensure the version exists before merging, or use an available version like 0.14.9.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link

Deploying infrahub-sdk-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 627bae0
Status: ✅  Deploy successful!
Preview URL: https://454c6797.infrahub-sdk-python.pages.dev
Branch Preview URL: https://pog-upgrade-ruff.infrahub-sdk-python.pages.dev

View logs

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##           stable     #724      +/-   ##
==========================================
- Coverage   76.84%   76.84%   -0.01%     
==========================================
  Files         113      113              
  Lines        9768     9767       -1     
  Branches     1497     1497              
==========================================
- Hits         7506     7505       -1     
  Misses       1757     1757              
  Partials      505      505              
Flag Coverage Δ
integration-tests 34.59% <100.00%> (-0.01%) ⬇️
python-3.10 50.82% <100.00%> (-0.01%) ⬇️
python-3.11 50.82% <100.00%> (-0.01%) ⬇️
python-3.12 50.80% <100.00%> (-0.01%) ⬇️
python-3.13 50.78% <100.00%> (-0.03%) ⬇️
python-3.14 52.43% <100.00%> (-0.03%) ⬇️
python-filler-3.12 23.88% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
infrahub_sdk/schema/repository.py 87.33% <100.00%> (-0.09%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ogenstad ogenstad marked this pull request as ready for review December 30, 2025 09:48
@ogenstad ogenstad requested a review from a team December 30, 2025 09:51
@ogenstad ogenstad merged commit 646e075 into stable Dec 30, 2025
21 checks passed
@ogenstad ogenstad deleted the pog-upgrade-ruff branch December 30, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants