Raise an error when a user provided schema include inherited
#8017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unit test that reproduces the KeyError bug when a schema defines a relationship with `inherited: true` but the relationship doesn't exist in any generic that the node inherits from. The bug occurs in _generate_weight_nodes_profiles when it assumes that any field with inherited=True will be found in generic_fields_map.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
the
group/backend
dgarros
force-pushed
the
claude/investigate-issue-8014-TE3qF
branch
3 times, most recently
from
a68bcc4 to
90ae67f
Compare
The `inherited` field on attributes and relationships is an internal property that should only be set by the system during schema processing. When users explicitly set `inherited: true` in their schema definitions, it would cause a KeyError later during weight generation because the field wasn't found in the generic fields map. This fix adds Pydantic field validators to AttributeSchema and RelationshipSchema that reject any schema with `inherited=True`, providing a clear error message that explains this is an internal property. Fixes #8014
dgarros
force-pushed
the
claude/investigate-issue-8014-TE3qF
branch
from
90ae67f to
d040324
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8014