Skip to content

Conversation

@Mat001
Copy link
Contributor

@Mat001 Mat001 commented Jan 20, 2026

  • Adds missing lint job to CI (completely absent before)
  • Fixes deprecated config: run.skip-dirs → issues.exclude-dirs, govet.check-shadowing → govet.enable: [shadow]
  • Replaces deprecated exportloopref with copyloopvar
  • Suppresses revive rules that would require breaking API changes (var-naming, exported, unused-parameter, superfluous-else, context-keys-type)
  • Adds exclusions for existing code patterns (nakedret in rest_ups.go, SA1029 context keys, ST1020/ST1021 comments)
  • Fixes typo: "protocal" → "protocol" in main.go:232
  • Fixes shadow variable bug in auth.go (err → rawErr)
  • Simplifies for-select loop in notification.go

https://optimizely-ext.atlassian.net/browse/FSSDK-11780

- Update golangci-lint to v1.64.2 (matching go-sdk)
- Fix deprecated config: exportloopref → copyloopvar, skip-dirs → exclude-dirs, check-shadowing → shadow
- Add lint job to CI workflow (was missing)
- Fix real bugs: shadow variable in auth.go, typo "protocal" → "protocol"
- Fix Go 1.22+ loop variable copies (copyloopvar)
- Simplify code: for-select pattern, redundant nil check
- Suppress style-only rules to avoid breaking changes

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@Mat001 Mat001 self-assigned this Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants