Skip to content

Conversation

@Mat001
Copy link
Contributor

@Mat001 Mat001 commented Jan 20, 2026

  • Updated golangci-lint from v1.54.2 → v1.64.2
  • Replaced deprecated golint linter with revive
  • Replaced deprecated exportloopref with copyloopvar
  • Fixed deprecated config: run.skip-dirs → issues.exclude-dirs, govet.check-shadowing → govet.enable: [shadow]
  • Suppressed revive rules that would require breaking API changes (var-naming, exported, unused-parameter, superfluous-else)
  • Updated CI lint job to use Go 1.24 (go.mod stays at 1.21 for user compatibility)
  • Fixed G115 integer overflow bug

https://optimizely-ext.atlassian.net/browse/FSSDK-11733

Mat001 and others added 2 commits January 14, 2026 14:39
- Update golangci-lint from v1.54.2 to v1.64.2
- Replace deprecated golint with revive
- Replace deprecated exportloopref with copyloopvar
- Update CI lint job to use Go 1.24
- Fix G115 integer overflow in notification/manager.go
- Suppress style-only rules to avoid breaking API changes

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@Mat001 Mat001 self-assigned this Jan 20, 2026
Copy link

@muzahidul-opti muzahidul-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- uses: actions/setup-go@v3
with:
go-version: '1.21.0'
go-version: '1.24.0'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does linter enforce to update the go version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants