AB#251996 Status bar color warning on API 35+#63
AB#251996 Status bar color warning on API 35+#63k-antipochkin wants to merge 3 commits intomasterfrom
Conversation
![baz-reviewer[bot]](https://avatars.githubusercontent.com/in/933528?s=60&v=4){kind=small}
| wv.evaluateJavascript(script, null); | ||
| } else { | ||
| wv.loadUrl("javascript:" + script); | ||
| wv.evaluateJavascript(script, null); |
There was a problem hiding this comment.
Removing the API level check for evaluateJavascript could cause crashes on devices below API 19. Should we keep the fallback to loadUrl?
| wv.evaluateJavascript(script, null); | |
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) { | |
| wv.evaluateJavascript(script, null); | |
| } else { | |
| wv.loadUrl("javascript:" + script); | |
| } |
Finding type: Logical Bugs
There was a problem hiding this comment.
The SDK's minimal API is 21
There was a problem hiding this comment.
Got it! I'll remember that the SDK's minimal API is 21 after the PR is merged.
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) { | ||
| settings.setMediaPlaybackRequiresUserGesture(false); | ||
| } | ||
| settings.setMediaPlaybackRequiresUserGesture(false); |
There was a problem hiding this comment.
Removing the API level check for setMediaPlaybackRequiresUserGesture could cause crashes on devices below API 17. Consider adding the version check back?
| settings.setMediaPlaybackRequiresUserGesture(false); | |
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) { | |
| settings.setMediaPlaybackRequiresUserGesture(false); | |
| } |
Finding type: Logical Bugs
There was a problem hiding this comment.
The SDK's minimal API is 21
There was a problem hiding this comment.
Got it! I'll remember that the SDK's minimal API is 21 after the PR is merged.
Co-authored-by: baz-reviewer[bot] <174234987+baz-reviewer[bot]@users.noreply.github.com>
1 participant
User description
Description of Changes
Use reflective status bar color painting on pre‑Android 15 (API <35) to avoid Play deprecation warnings
Breaking Changes
Release Checklist
Prepare:
-
[ ] Detail any breaking changes. Breaking changes require a new major version number, and a migration guide in wiki / README.mdBump versions in:
-
[ ] add links to newly created wiki pages to readme-
[ ] Update major version numbers in wiki (basic integration + push guides)Integration tests
T&T Only
Mobile Only
Deferred Deep Links
Combined
Release Procedure
devtomasterGenerated description
Below is a concise technical summary of the changes proposed in this PR:
graph LR setStatusBarColorForDialog_("setStatusBarColorForDialog"):::modified getStatusBarColorLegacy_("getStatusBarColorLegacy"):::added setStatusBarColorLegacy_("setStatusBarColorLegacy"):::added unsetStatusBarColorForDialog_("unsetStatusBarColorForDialog"):::modified closeDialog_("closeDialog"):::modified onPageFinished_("onPageFinished"):::modified showWebView_("showWebView"):::modified WebView_("WebView"):::added setStatusBarColorForDialog_ -- "Uses reflection to get status bar color on legacy Android." --> getStatusBarColorLegacy_ setStatusBarColorForDialog_ -- "Sets status bar color via reflection for legacy Android." --> setStatusBarColorLegacy_ unsetStatusBarColorForDialog_ -- "Restores previous status bar color on legacy Android devices." --> setStatusBarColorLegacy_ closeDialog_ -- "Resets status bar color on dialog close for legacy Android." --> unsetStatusBarColorForDialog_ onPageFinished_ -- "Updates status bar color after page load on legacy Android." --> setStatusBarColorForDialog_ showWebView_ -- "Enables WebView debugging unconditionally in debug builds." --> WebView_ classDef added stroke:#15AA7A classDef removed stroke:#CD5270 classDef modified stroke:#EDAC4C linkStyle default stroke:#CBD5E1,font-size:13pxImplement reflective access to
Window.setStatusBarColor()andWindow.getStatusBarColor()within theInAppMessageViewcomponent for Android versions below API 35, addressing Play Store deprecation warnings related to status bar color painting. Update the SDK version and changelog to reflect these changes.Window.setStatusBarColor()andWindow.getStatusBarColor()for Android versions below API 35 to manage status bar colors for in-app messages, avoiding Play Store deprecation warnings.Modified files (1)
Latest Contributors(2)
7.7.1and version code to70701ingradle.properties, and add a corresponding entry toCHANGELOG.md.Modified files (2)
Latest Contributors(2)