feat(collector): implement panic recovery and crash-loop safety#157
Open
wazer24 wants to merge 5 commits into
Open
feat(collector): implement panic recovery and crash-loop safety#157wazer24 wants to merge 5 commits into
wazer24 wants to merge 5 commits into
Conversation
Signed-off-by: wazer24 <24wazer@rbunagpur.in>
Signed-off-by: wazer24 <24wazer@rbunagpur.in>
|
🚀 First PR — welcome aboard! A few things to expect:
If you get stuck, reply here or jump to Discussions. We want this PR to land. |
Author
|
@btwshivam apologies for the delay but i fixed the remaining issues the solution of mine was having please review it,and tell me if anything needed to be changed thankyou |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Addresses PR review feedback: replaces brittle string-sniffing exit-code logic with a typed sentinel error, sweeps remaining
interface{}back toany, adds missing doc comments for the no-restart contract and unbounded panic logs, and fixes CI failures (govet shadow, missing import close paren, linter pre-build step).Why
Fixes #54 review comments from @btwshivam
How
cli.ErrDaemonPanicsentinel;runStartassigns it via named return on panic recovery.cmd/kerno/main.gonow useserrors.Is(err, cli.ErrDaemonPanic)instead of string-matchingerr.Error()[:6] == "daemon".interface{}→any: Revertedmap[string]interface{}back tomap[string]anyinhealthzHandler; changedr interface{}tor anyinHandlePanicandHandleDaemonPanic.RunSafeCollectorGoroutine; added operator-responsible note for unbounded panic log files onHandlePanic.errtorootErrinrunStart(govet); restored missing)after import block; addedgo build ./...pre-build step before golangci-lint inci.yml.Testing
go build ./...passesgo test ./...passesgo vet ./...passesgolangci-lint run ./...passesChecklist
feat(core): implement panic recovery and crash-loop safety)git commit -s)