fix: remove misleading error prefix for exit-code#191
Merged
Conversation
|
🚀 First PR — welcome aboard! A few things to expect:
If you get stuck, reply here or jump to Discussions. We want this PR to land. |
github-actions
Bot
added
the
level:intermediate
btwshivam
requested changes
Jun 6, 2026
| func main() { | ||
| if err := cli.New().Execute(); err != nil { | ||
| fmt.Fprintf(os.Stderr, "Error: %v\n", err) | ||
| fmt.Fprintln(os.Stderr, err) |
Member
There was a problem hiding this comment.
this still prints the exitError message to stderr on an expected --exit-code outcome, just without the Error: prefix. #122 asks to type-assert interface{ ExitCode() int }, exit with that code and skip the message, or drop the unused ExitCode(). a non-exitError still needs an Error: line, so a blanket Fprintln also regresses real errors.
btwshivam
approved these changes
Jun 7, 2026
Member
btwshivam
left a comment
btwshivam
left a comment
There was a problem hiding this comment.
thanks, this is the right fix now, main type-asserts ExitCode() and skips the Error line for the expected exit-code outcome.
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the misleading
"Error:"prefix from CLI output when using--exit-code.This ensures expected critical findings are displayed cleanly without being framed as unexpected errors.
Fixes #122